[Bug 35532] New: Calendar in booking modal requires 2 clicks to take date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Bug ID: 35532 Summary: Calendar in booking modal requires 2 clicks to take date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 29002 When making a booking in the staff interface, clicking on the date once won't take, you need to click a second time. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #1 from David Nind <david@davidnind.com> --- I can also confirm that this is happening. To replicate: 1. In the staff interface, go to the details page for a record with items. 2. Click on the 'Items' tab. 3. For an item, change 'Bookable' to 'Yes' and click on 'Update'. 4. Go back to the normal tab for the record. 5. Click on the "Place booking" button. 6. Select a patron for the patron field. 7. Click in the period field. 8. Note that if you select a date (single click as normal for a date field), and then try to press the "Submit" button, the period field is blank. 9. Click on the period field again, then double click a date - this time it remains, and you can click the "Submit" button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- You are picking a start AND an end date.. it's not a double click.. it's a start (click one date) then end (click another date). Katrin suggests a hint should be added to clarify this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yes, because we didn't get it :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Calendar in booking modal |Use of calendar for date |requires 2 clicks to take |range in bookings is not |date |clear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 |35426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 [Bug 35426] Improve layout of bookings modal form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Honestly.. I'm not sure where to put a hint or what to write in it... To me 'Period' means 'Two dates.. start and end'... and the visual queues are also clear in the picker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160857&action=edit Picker open -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35426 |29002 Assignee|martin.renvoize@ptfs-europe |koha-bugs@lists.koha-commun |.com |ity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 [Bug 35426] Improve layout of bookings modal form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #6 from David Nind <david@davidnind.com> --- It was not obvious to me. However, it seems obvious now that you've pointed it out! I don't think I've seen this pattern elsewhere in Koha (but I'm probably wrong about that...). Since I'm not familiar with the booking feature, I "assumed" it was just for one day. Normally, with the date picker, I pick a day then click outside the picker so that the date appears in the input field. So I hope that this didn't come across as too negative! Some ideas - not tied to any of them: 1. Label for Period: . Start and end date of booking (this is quite long though) . Booking dates . Start and end date 2. Hint for the field (like for the patron): . Select the booking start and end date 3. Not sure how these would work for translation. I think I prefer a combination of "Booking dates" as the label and a hint for the field "Select the booking start and end date". Other things noted (outside scope for this bug, just noting - happy to open bugs if they don't exist already): 1. Not sure how to use the 'Tomorrow' date link in the picker - does nothing for me. Should this be disabled? 2. Accessibility things - using keyboard instead of a mouse (I don't know enough to know if these are fixable, or even issues): . Patron field: works OK with tab, search, and then the down arrow to select a patron . Item field: can tab to it, but can't select item using down or up arrows . Period: tab opens date picker, but not sure how to select a date range 3. You need to pick a date range: what if you only wanted to book for one day? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 |35426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 [Bug 35426] Improve layout of bookings modal form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162266&action=edit Bug 35532: Update date select field and add hint This patch updates the 'Period' select from 'Period' to 'Booking dates' and adds a hint beneath it too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162267&action=edit Bug 35532: Remove shortcut buttons from flatpickr It doesn't make sense to have the shortcut buttons in the range picker for bookings. This patch adds the ability to remove them entirely from display and uses that option in the bookings modal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162266|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 162274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162274&action=edit Bug 35532: Update date select field and add hint This patch updates the 'Period' select from 'Period' to 'Booking dates' and adds a hint beneath it too. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162267|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 162275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162275&action=edit Bug 35532: Remove shortcut buttons from flatpickr It doesn't make sense to have the shortcut buttons in the range picker for bookings. This patch adds the ability to remove them entirely from display and uses that option in the bookings modal. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #11 from David Nind <david@davidnind.com> --- Thanks Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162274|0 |1 is obsolete| | Attachment #162275|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 162844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162844&action=edit Bug 35532: Update date select field and add hint This patch updates the 'Period' select from 'Period' to 'Booking dates' and adds a hint beneath it too. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 162845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162845&action=edit Bug 35532: Remove shortcut buttons from flatpickr It doesn't make sense to have the shortcut buttons in the range picker for bookings. This patch adds the ability to remove them entirely from display and uses that option in the bookings modal. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Even I couldn't miss it now, thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the bookings release notes| |feature to make selecting | |the booking period clearer: | |- Changes field label from | |'Period' to 'Booking dates' | |- Adds a hint added to | |indicate that you need to | |select a start and end date | |('Select the booking start | |and end date') | |- Removes | |the date shortcut options | |from the date picker, as | |they do not make sense for | |bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35426 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #16)
Depends on Bug 35426 not in 23.11.x
Maye worth reconsidering - a lot of us didn't understand this new type of date selector and this improves things quite a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #17)
(In reply to Fridolin Somers from comment #16)
Depends on Bug 35426 not in 23.11.x
Maye worth reconsidering - a lot of us didn't understand this new type of date selector and this improves things quite a bit.
If needed for 23.11.x please provide new patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.04 released in| | --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #18)
(In reply to Katrin Fischer from comment #17)
(In reply to Fridolin Somers from comment #16)
Depends on Bug 35426 not in 23.11.x
Maye worth reconsidering - a lot of us didn't understand this new type of date selector and this improves things quite a bit.
If needed for 23.11.x please provide new patches
No need, I understood the conflict. Now calendar.inc is identical between 23.11.x and master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Bug 35532 depends on bug 35426, which changed state. Bug 35426 Summary: Improve layout of bookings modal form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Missing 23.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org