[Bug 42548] New: Add possibility to list multiple barcodes or one biblionumber on attach item action
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Bug ID: 42548 Summary: Add possibility to list multiple barcodes or one biblionumber on attach item action Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Hello When you want to attach items on biblio record it will be useful to add a list of barcodes or a biblionumber (if you want to attacn all items in one shot). So this patch will introduce this feature, I will add bug 6532 and 42451 dependants cause I added a method to move all items in a batch and this patch adds refactoring of this to prevent duplicate code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6532, 42451 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6532 [Bug 6532] Way to move items to another record in batches https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 [Bug 42451] "convert" op in guided_reports.pl is broken due to JS error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|6532, 42451 | Depends on| |6532, 42451 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6532 [Bug 6532] Way to move items to another record in batches https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 [Bug 42451] "convert" op in guided_reports.pl is broken due to JS error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 --- Comment #1 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 198712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198712&action=edit Bug 42548: Refactor Koha::Items->move_to_biblio with extended options New optional parameters: merge_biblio_holds, delete_empty_source_biblios, callback (reference invoked once per item to see background jobs report progress). The method now returns ( $report, $self ) following the same convention as Koha::Items->batch_update. Test plan ========= 1. Apply this patch and restart_all 2. Open record B, Edit -> "Attach items". 2 options here: - by item barcodes -> The form now has a textarea. Paste 3 barcodes for example and submit them. - by biblionumber -> Add destination biblionumber record to move all items. Both : processes are separated so you perform both options in same time. Note that you will see "Delete record" button per source biblio that became empty. 3. Include a barcode of an item linked to an order line and another linked to a serial issue: page reloads with a modal introduced by bug 42451. 4. prove t/db_dependent/Koha/BackgroundJob/BatchMoveItem.t prove t/db_dependent/Koha/Items.t Notice that I used AI to perform some checks and help me to improve feature without crashing a Koha part behavior. Also for building unit tests. This is the first time on a patch, so I made it also by curiosity. Assisted-by: Opus 4.7 (Anthropic) Sponsored-by: Université Côte d'Azur -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 --- Comment #2 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 198713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198713&action=edit Bug 42548: Use Koha::Items->move_to_biblio in BatchMoveItem Replace item move loop, hold transfer, biblio deletion and reindex logic with a single call to Koha::Items->move_to_biblio. Sponsored-by: Université Côte d'Azur -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 --- Comment #3 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 198714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198714&action=edit Bug 42548: Allow attaching multiple items at once via Attach items Replace the single barcode input with a textarea that accepts one barcode per line. Sponsored-by: Université Côte d'Azur -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 --- Comment #4 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 198715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198715&action=edit Bug 42548: Confirm Attach items move when items are linked to orders or serials Add same logic around checks (order and subscription) introduced by bug 42451 (patch dependant). Sponsored-by: Université Côte d'Azur -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 --- Comment #5 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 198716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198716&action=edit Bug 42548: Add tests for the new Koha::Items->move_to_biblio options Extend the existing 'move_to_biblio() tests' Sponsored-by: Université Côte d'Azur -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Not sure why this one depends on bug 42451. Is that a typo? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|42451 |42541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 [Bug 42451] "convert" op in guided_reports.pl is broken due to JS error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42541 [Bug 42541] Add order and serial controls before moving items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 --- Comment #7 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- (In reply to David Cook from comment #6)
Not sure why this one depends on bug 42451. Is that a typo?
Hello ! Yep totally :) thanks for the catch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43039 [Bug 43039] Biblio level hold follows the last item during move on new biblio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #8 from Mathieu Saby <mathsabypro@gmail.com> --- prove t/db_dependent/Koha/BackgroundJob/BatchMoveItem.t gives me an error : t/db_dependent/Koha/BackgroundJob/BatchMoveItem.t .. 4/5 # Looks like you planned 5 tests but ran 6. t/db_dependent/Koha/BackgroundJob/BatchMoveItem.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 5 subtests passed Test Summary Report ------------------- t/db_dependent/Koha/BackgroundJob/BatchMoveItem.t (Wstat: 65280 (exited 255) Tests: 6 Failed: 1) Failed test: 6 Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 6. Files=1, Tests=6, 4 wallclock secs ( 0.02 usr 0.03 sys + 2.96 cusr 0.52 csys = 3.53 CPU) Result: FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 --- Comment #9 from Mathieu Saby <mathsabypro@gmail.com> --- Functionally it works as expected but I fail qa for BatchMoveItem.t Could you please check it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198716|0 |1 is obsolete| | --- Comment #10 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 205108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205108&action=edit Bug 42548: Add tests for the new Koha::Items->move_to_biblio options Extend the existing 'move_to_biblio() tests' Sponsored-by: Université Côte d'Azur -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 --- Comment #11 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- (In reply to Mathieu Saby from comment #9)
Functionally it works as expected but I fail qa for BatchMoveItem.t Could you please check it?
Hello Mathieu.. my bad I forgot to update the number of test. Fixed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 crosenthal@pwcgov.org <crosenthal@pwcgov.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crosenthal@pwcgov.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Failed QA --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried this. It's really interesting. I'm not sure if this issues I ran into are from this bug or one of the dependents. - When entering barcodes, they are in italics, I don't know if this is normal (I don't remember how it is in main) - Could the box to enter more than one barcode be a big bigger (maybe like on http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) ? - When you attach all the items from a record, and none are left, there's a delete record button, but it looks all wonky/too big. - In the terminology, it says not to use "biblio" when referring to a bibliographic record, could you change " Or attach all items from biblio: " to " Or attach all items from bibliographic record: " Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org