[Bug 27936] New: AllowItemsOnHoldCheckoutSIP does not allow checkout of items currently waiting for a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Bug ID: 27936 Summary: AllowItemsOnHoldCheckoutSIP does not allow checkout of items currently waiting for a hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: kyle@bywatersolutions.com Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The syspref text says "[Allow/Don't allow] checkouts of items reserved to someone else via SIP checkout messages. If allowed do not generate RESERVE_WAITING and RESERVED warning. This allows self checkouts for those items. If using the holds queue items with pending holds will be marked as "unavailable" if this set to "Don't allow"." However, setting the syspref to Allow *only* allows sets sip to ignore the RESERVED warning. Items that are currently waiting for hold pickup will still generate a RESERVE_WAITING message and block the checkout. Either the description or the behavior needs to change to make this accurate. In contrast, AllowItemsOnHoldCheckoutSCO also says "If allowed do not generate RESERVE_WAITING and RESERVED warning" and, for the SCO, this is accurate. With AllowItemsOnHoldCheckoutSCO set to allow, items waiting for another patron's hold can be checked out without a warning at the SCO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- To test: 1 - place a hold on Item1 for PatronA, check it in to set the hold to waiting 2 - place a hold on Item2 for PatronA, do not check it in so the hold stays at pending 3 - confirm AllowItemsOnHoldCheckoutSIP is set to Don't allow 4 - attempt to check Item1 out to PatronB via SIP, get an error that the item is on hold for another patron 5 - attempt to check Item2 out to PatronB via SIP, get an error that the item is on hold for another patron 6 - set AllowItemsOnHoldCheckoutSIP to Allow 7 - attempt to check Item1 out to PatronB via SIP again, still get an error that the item is on hold for another patron 8 - attempt to check Item2 out to PatronB via SIP, success! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- What version of Koha did you test this on? If not master, can you make sure master exhibits the same behavior? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I tested on master and then made Nick look at the code around it, in which he reports it only prevents RESERVE warnings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Jeff Gaines <jgaine@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jgaine@arlingtonva.us --- Comment #4 from Jeff Gaines <jgaine@arlingtonva.us> --- The syspref is working as we were looking for, so if you do change this, please leave this functionality as an alternate option for it. I cannot imagine the use case for Patron B to be able to walk up to the self-serve Hold Shelf, take an item held for Patron A, and check it out at a self checkout station without staff intervention/approval. Is that truly the intent of this? If Patron B finds an item on the regular shelf that is on the Holds Queue report for Patron A but staff have not gone out and pulled it yet, then it's "finders keepers" and we want Patron B to be able to check it out. But once an item is trapped and on the Hold Shelf for patron A (and Patron A has been notified to come get it), we don't want anyone other than Patron A to be able to check it out without staff approval. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25690 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks like it has been caused by commit 338ba1d7692c1f75af7b0fb75eb5aac00a04a3df Bug 25690: Remove duplicated logic in SIP2 checkouts Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi Assignee|kyle@bywatersolutions.com |joonas.kylmala@helsinki.fi --- Comment #6 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Hi, the behaviour has been always to prevent waiting holds being checked out via SIP2, the syspref text has been inaccurate. I can send patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 --- Comment #7 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118366&action=edit Bug 27936: Clarify AllowItemsOnHoldCheckoutSIP syspref help text The waiting reserves have always been impossible to checkout via SIP2. There was some confusion whether this is actually true but if you check the commit "Bug 25690: Remove duplicated logic in SIP2 checkouts" (fc1848746da) and the removed code around line $self->screen_msg("Item is on hold for another patron."); you will be sure that it has been impossible to checkout waiting holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21572 --- Comment #8 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Regarding the AllowItemsOnHoldCheckoutSCO behaviour being different see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572#c3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25690 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118366|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118367&action=edit Bug 27936: Clarify AllowItemsOnHoldCheckoutSIP syspref help text The waiting reserves have always been impossible to checkout via SIP2. There was some confusion whether this is actually true but if you check the commit "Bug 25690: Remove duplicated logic in SIP2 checkouts" (338ba1d769) and the removed code around line $self->screen_msg("Item is on hold for another patron."); you will be sure that it has been impossible to checkout waiting holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118367|0 |1 is obsolete| | --- Comment #10 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118455&action=edit Bug 27936: Clarify AllowItemsOnHoldCheckoutSIP syspref help text The waiting reserves have always been impossible to checkout via SIP2. There was some confusion whether this is actually true but if you check the commit "Bug 25690: Remove duplicated logic in SIP2 checkouts" (338ba1d769) and the removed code around line $self->screen_msg("Item is on hold for another patron."); you will be sure that it has been impossible to checkout waiting holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 --- Comment #11 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- The syspref description was also in sysprefs.sql which I missed in the earlier revision of the patch. Attached now a new version with the text there also corrected. Ready for Sign-Off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118455|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 118458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118458&action=edit Bug 27936: Clarify AllowItemsOnHoldCheckoutSIP syspref help text The waiting reserves have always been impossible to checkout via SIP2. There was some confusion whether this is actually true but if you check the commit "Bug 25690: Remove duplicated logic in SIP2 checkouts" (338ba1d769) and the removed code around line $self->screen_msg("Item is on hold for another patron."); you will be sure that it has been impossible to checkout waiting holds. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118458|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118808&action=edit Bug 27936: Clarify AllowItemsOnHoldCheckoutSIP syspref help text The waiting reserves have always been impossible to checkout via SIP2. There was some confusion whether this is actually true but if you check the commit "Bug 25690: Remove duplicated logic in SIP2 checkouts" (338ba1d769) and the removed code around line $self->screen_msg("Item is on hold for another patron."); you will be sure that it has been impossible to checkout waiting holds. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Improved wording.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.05 released in| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27936 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org