[Bug 30475] New: Convert tools pages tabs to Bootstrap (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Bug ID: 30475 Summary: Convert tools pages tabs to Bootstrap (part 2) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 29226 Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in a few tools templates with Bootstrap: - modborrowers.tt - export.tt - overduerules.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133047&action=edit Bug 30475: Convert tools pages tabs to Bootstrap (part 2) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. To test, apply the patch and go to Tools -> Export. - You should see at least two tabs, "Export bibliographic records" and "Export authority records." - Confirm that they look correct and work correctly. Go to Tools -> Batch patron modification. - Check the "By card number," "By borrowernumber," and "By patron list" tabs. Go to Tools -> Overdue notice/status triggers. - Check the "First," "Second," and "Third" tabs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133047|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133474&action=edit Bug 30475: Convert tools pages tabs to Bootstrap (part 2) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. The patch contains indentation changes, so diff accordingly. To test, apply the patch and go to Tools -> Export. - You should see at least two tabs, "Export bibliographic records" and "Export authority records." - Confirm that they look correct and work correctly. Go to Tools -> Batch patron modification. - Check the "By card number," "By borrowernumber," and "By patron list" tabs. Go to Tools -> Overdue notice/status triggers. - Check the "First," "Second," and "Third" tabs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133474|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133489&action=edit Bug 30475: Convert tools pages tabs to Bootstrap (part 2) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. The patch contains indentation changes, so diff accordingly. To test, apply the patch and go to Tools -> Export. - You should see at least two tabs, "Export bibliographic records" and "Export authority records." - Confirm that they look correct and work correctly. Go to Tools -> Batch patron modification. - Check the "By card number," "By borrowernumber," and "By patron list" tabs. Go to Tools -> Overdue notice/status triggers. - Check the "First," "Second," and "Third" tabs. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks great, Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133489|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133769&action=edit Bug 30475: Convert tools pages tabs to Bootstrap (part 2) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. The patch contains indentation changes, so diff accordingly. To test, apply the patch and go to Tools -> Export. - You should see at least two tabs, "Export bibliographic records" and "Export authority records." - Confirm that they look correct and work correctly. Go to Tools -> Batch patron modification. - Check the "By card number," "By borrowernumber," and "By patron list" tabs. Go to Tools -> Overdue notice/status triggers. - Check the "First," "Second," and "Third" tabs. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30884 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 [Bug 30884] Incomplete replace of jQuery UI tabs in batch patron modification breaks the form sending -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org