https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |alexbuckley@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78103|0 |1 is obsolete| | --- Comment #4 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 85201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85201&action=edit Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: <li class="top-level"> <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl"> <span class="self-issue"> Self issue an item </span> </a> </li> 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel this needs additional clean-up of the CSS to go with it. The colors in the top navigation bar are off on the fonts and mouse overs and not the same as on the front page. Overall I think the style doesn't work so well here because the sco pages haven't been restyled. At the moment, there are also issues with readabillity and contrast beside it not being so pretty - so I think we need to fix those at least. (Please compare toolbar on top with language switcher before and after change) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85202|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 117218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117218&action=edit Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #6)

I feel this needs additional clean-up of the CSS to go with it. The colors in the top navigation bar are off on the fonts and mouse overs and not the same as on the front page. Overall I think the style doesn't work so well here because the sco pages haven't been restyled. At the moment, there are also issues with readabillity and contrast beside it not being so pretty - so I think we need to fix those at least. (Please compare toolbar on top with language switcher before and after change)

Can you please provide some examples or screenshots of what you mean? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Aleisha Amohia from comment #10)

(In reply to Katrin Fischer from comment #6)

...

I feel this needs additional clean-up of the CSS to go with it. The colors in the top navigation bar are off on the fonts and mouse overs and not the same as on the front page. Overall I think the style doesn't work so well here because the sco pages haven't been restyled. At the moment, there are also issues with readabillity and contrast beside it not being so pretty - so I think we need to fix those at least. (Please compare toolbar on top with language switcher before and after change)

Can you please provide some examples or screenshots of what you mean?

I am not sure the comments still apply since then some work probably has been done on the pages. And even back then I might have been missing something. I'd have to check again, but the patches don't apply now :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117217|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132276&action=edit Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: <li class="top-level"> <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl"> <span class="self-issue"> Self issue an item </span> </a> </li> 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117219|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 132278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132278&action=edit Bug 21266: (follow-up) Remove unnecessary vars passed to template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Hammat wele <hammat.wele@inlibro.com> --- error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41113 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from David Cook <dcook@prosentient.com.au> --- I think I've found a little regression. Before the patch, SCOUserCSS would be applied after sco.css. After the patch, SCOUserCSS is applied before sco.css, so you can't override sco.css using SCOUserCSS. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191718&action=edit Bug 21266: (follow-up) Fix inclusion of SCOUserCSS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries, Central Agencies | |(Treasury), New Zealand Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 206587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206587&action=edit Bug 21266: Added missing doc-head-close and cssinclude to sco-main.tt This is a re-implementation of the previous patch set with additional de-duplication of markup. The patch also removes some redunancy from sco.scss and makes a few minor changes to markup to bring the templates in better alignment with the OPAC. Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 3. Go to the self checkout page and notice the OPAC theme is not being applied to the self check interface. 4. Apply patch and rebuild the OPAC CSS. 5. Refresh the page and notice the custom theme is being applied. 6. Perform the same test with the SCOUserCSS preference. Sponsored-By: Central Agencies (Treasury), New Zealand Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 41144 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited|Athens County Public |Athens County Public list of Sponsors|Libraries, Central Agencies |Libraries, Central Agencies |(Treasury), New Zealand |(Treasury), Central | |Agencies (Treasury), New | |Zealand, New Zealand Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 206947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206947&action=edit Bug 21266: Added missing doc-head-close and cssinclude to sco-main.tt This is a re-implementation of the previous patch set with additional de-duplication of markup. The patch also removes some redunancy from sco.scss and makes a few minor changes to markup to bring the templates in better alignment with the OPAC. Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 3. Go to the self checkout page and notice the OPAC theme is not being applied to the self check interface. 4. Apply patch and rebuild the OPAC CSS. 5. Refresh the page and notice the custom theme is being applied. 6. Perform the same test with the SCOUserCSS preference. Sponsored-By: Central Agencies (Treasury), New Zealand Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #27 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Used external stylesheet from bug 41113 for OpacAdditionalStylesheet (adds a blue background): https://static.myacpl.org/public/css/test.css 2. AutoSelfCheckAllowed: use self_checkout (update password after resetting using the patron module, as I'm not sure what the default password is). 3. The web self-checkout is enabled by default in KTD, accessed from OPAC-URL/cgi-bin/koha/sco/sco-main.pl 4. Note: error when rebuilding CSS (yarn build): Error in plugin "sass" Message: koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss Error: Undefined variable. ╷ 2 │ color: $sci-link-color; │ ^^^^^^^^^^^^^^^ ╵ koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss 2:12 root stylesheet 5. Step 5: SCOUserCSS preference - removed OpacAdditionalStylesheet and added this CSS to SCOUserCSS (background should now be red): body { background-color: #ff0000; } -- You are receiving this mail because: You are watching all bug changes.