[Bug 7885] New: Change filename of TransferLog suggested by packages to fit with logrotate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 Priority: P5 - low Change sponsored?: --- Bug ID: 7885 Assignee: robin@catalyst.net.nz Summary: Change filename of TransferLog suggested by packages to fit with logrotate QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: magnus@enger.priv.no Hardware: All Status: NEW Version: master Component: Packaging Product: Koha debian/templates/apache-site.conf.in creates a per-site Apache conf file that contains this: # TransferLog /var/log/koha/__KOHASITE__/opac-access_log If this line is simply uncommented (by naive people like me), it will result in an access log like this: /var/log/koha/mysite/opac-access_log Now, the packages set up logrotate, but it only looks for this pattern: /var/log/koha/*/*.log which results in the TransferLog not getting picked up by logrotate. Is there a specific reason for doing it this way, or would it be better if we changed the Apache conf file to this: # TransferLog /var/log/koha/__KOHASITE__/opac-access.log --- Apache conf template: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=debian/templates/a... logrotate config: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=debian/koha-common... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- It's a weird apache default thing. I usually end up changing it manually whenever I enable the transfer log. So yes, I very much think it should be .log too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 8856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8856&action=edit Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate The apache accesslogs suggested by the default config files are called *_log, which results in them not getting picked up by logrotate, which looks for *.log. This patch changes the suggested filenames to *.log. To test: Not much to test here, just apply the patch and check that all occurences of TransferLog and CustomLog are now on the form *.log All the lines where these occur are commented out, so this will not actually change any behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 8860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8860&action=edit Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate The apache accesslogs suggested by the default config files are called *_log, which results in them not getting picked up by logrotate, which looks for *.log. This patch changes the suggested filenames to *.log. To test: Not much to test here, just apply the patch and check that all occurences of TransferLog and CustomLog are now on the form *.log All the lines where these occur are commented out, so this will not actually change any behaviour. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- Verified that it's totally harmless and ultimately a good thing to do. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Very simple change, _ to . in several cases. If the Package Manager verifies it's safe, I'm inclined to believe. Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Severity|enhancement |normal --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- in fact, I even think it's not an enhancement, but a bugfix, so updating severity -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7885 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch will be included in 3.6.5. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org