[Bug 7153] New: Show Open Library as Search Target in "More Searches" in OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Bug #: 7153 Summary: Show Open Library as Search Target in "More Searches" in OPAC detail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: savitra.sirohi@osslabs.biz QAContact: ian.walls@bywatersolutions.com Created attachment 6190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6190 Patch Show Open Library as Search Target in "More Searches" in OPAC detail page. Updated syspref OPACSearchForTitleIn to include Open Library as a search target -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6190|0 |1 is patch| | Attachment #6190|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-04 18:19:17 UTC --- The updatedatabase call here will wipe out any existing customized values libraries have in the SearchForTitleIn; I know several libraries with that done, and they would be very angry to have their customizations lost. I recommend adding a WHERE clause to the SQL to only do the update if the system preference is still it's default value. Only in that case can you assume it's safe to replace the data in the preference. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2011-11-04 18:59:31 UTC --- I agree with the failing of this - I'd be very cross if my customizations in that field were wiped out. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6190|0 |1 is obsolete| | --- Comment #3 from Savitra Sirohi <savitra.sirohi@osslabs.biz> 2011-11-05 04:34:42 UTC --- Created attachment 6218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6218 Updated patch Fresh patch, this time fixing issue raised by QA. The Open Library search target is appended to whatever list of search targets the library may have in the syspref at the time of update -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-05 07:24:16 UTC --- I think we should not change existing entries at all. People can add the search target if they want to - we can give examples for search targets on the wiki, the release notes or the newsletter. Also some libraries don't use the feature and leave the sys pref empty. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6218|0 |1 is patch| | Attachment #6218|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-05 08:26:04 UTC --- The hack I use to add Facebook and Twitter links to the biblio detail page would break if this attribute was appended. We cannot assume that the value of the system preference is still just a list; it could be arbitrary HTML. If the WHERE clause checked that the current value of SearchForTitleIn was the same as the default value (that is, unchanged since default), I think it would be safe to append it, but not in any other case. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-05 08:34:09 UTC --- I think perhaps do no updatedatabase at all - leave the running installations alone and only do it for new installations. That's how we do it for a lot of other things too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-11-05 20:37:25 UTC --- I agree with Katrin - this should effect upgrades cause I customize this preference for every library I train and I'd hate to see my work erased - and I'm sure so would they. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Noufal Ibrahim <noufal@archive.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noufal@archive.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-11-22 01:19:19 UTC --- I meant to say that it 'should not' effect upgrades. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org --- Comment #9 from Dobrica Pavlinusic <dpavlin@rot13.org> 2011-11-24 17:02:36 UTC --- Would adding commented link if current value doesn't end in </li> be sensible solution here? I would love to get commented-out link which I can than integrate into my html as opposed to hunting in database upgrades to find sensible template. We don't really have good place to leave upgrade message for staff with sensible default link I think, or am I missing something? (other than inserting news in staff interface, and I don't really want to go there in the middle of conversation about database upgrades on koha-dev :-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master AssignedTo|oleonard@myacpl.org |savitra.sirohi@osslabs.biz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-12-14 14:22:06 UTC --- I'm not sure I want any code going in my preferences if I have set them already. The more searches code box can have things other than list items and your comment might not hurt anything ... but then again it might. I see no reason not add this to new installs, but it shouldn't touch upgraded systems. I can however put a note in the manual on how to add a link to Open Library to your more searches menu for those who upgrade. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-14 14:22:59 UTC --- +1 for Nicole's suggestion -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #12 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-14 22:05:50 UTC --- Agreed. Let's add the new option to new installs, and provide documentation on how to add it into existing installs. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6218|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9991&action=edit Update syspref OPACSearchForTitleIn to include Open Library as a target in More Searches in the OPAC detail page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #14 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9992&action=edit Bug 7153 - Followup - Remove syspref modification Remove the database update that is modifying an existing systempreference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11044&action=edit [SIGNED-OFF] Bug 7153 - Show Open Library as Search Target in "More Searches" in OPAC detail page Update syspref OPACSearchForTitleIn to include Open Library as a target in More Searches in the OPAC detail page http://bugs.koha-community.org/show_bug.cgi?id=7153 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Updatedatabase conflicts fixed, twice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- 2 first patches are obsoletes ? And just the last one needs QA ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9992|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #16)
2 first patches are obsoletes ? And just the last one needs QA ?
Correct. Sorry about that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- It seems good for me. But I let Ian make the decision (he is the QA contact for this bug). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #18)
It seems good for me. But I let Ian make the decision (he is the QA contact for this bug). Jonathan, that was done default by the system (see history). You can take over the QA field.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha.sekjal@gmail.com |jonathan.druart@biblibre.co | |m --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Change the default value for syspref OPACSearchForTitleIn. Impact only the new installations. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Version|rel_3_10 |master --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Safe tiny enhancement that has no effect on upgrading users. But gives new Koha users Open Library as a search target in More Searches. Pushed to 3.8.x, will be 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org