https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 lulihua@ibwya.net changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |lib.ibwya.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|lib.ibwya.net | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70811&action=edit Bug 19975: Fix search by tags at the OPAC This bug has certainly be caused by commit 091d6c513bcbee224ff06477e79be48cea7fe825 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes The reason is quite simple, in Koha::ItemType->translated_description (called in opac-search.pl l.229) there is an eval to know if we have access to the translated description of the item type, to avoid retrieving it again. The evaluation of $@ later in opac-search.pl is supposed to test the 2 eval made few lines before (a "normal" search, without tags), but $@ contains the error message from the *last* eval command. So we are raising an error that have been correctly handled in Koha::ItemType. Test plan: At the OPAC, click Tag cloud, then click any of the tags => Without the patch you get Koha::ItemType::get_column generated this error: DBIx::Class::Row::get_column(): No such column 'translated_description' on Koha::Schema::Result::Itemtype at /usr/share/koha/lib/Koha/Object.pm line 307 => With the patch applied the page is correctly displayed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70811|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 70850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70850&action=edit Bug 19975: Fix search by tags at the OPAC This bug has certainly be caused by commit 091d6c513bcbee224ff06477e79be48cea7fe825 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes The reason is quite simple, in Koha::ItemType->translated_description (called in opac-search.pl l.229) there is an eval to know if we have access to the translated description of the item type, to avoid retrieving it again. The evaluation of $@ later in opac-search.pl is supposed to test the 2 eval made few lines before (a "normal" search, without tags), but $@ contains the error message from the *last* eval command. So we are raising an error that have been correctly handled in Koha::ItemType. Test plan: At the OPAC, click Tag cloud, then click any of the tags => Without the patch you get Koha::ItemType::get_column generated this error: DBIx::Class::Row::get_column(): No such column 'translated_description' on Koha::Schema::Result::Itemtype at /usr/share/koha/lib/Koha/Object.pm line 307 => With the patch applied the page is correctly displayed Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> https://bugs.koha-community.org/show_bug.cgi?id=19775 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19975 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! This patch has been pushed to 17.11.x and will be in 17.11.03 -- You are receiving this mail because: You are watching all bug changes.