[Bug 8812] New: Staff Client: Patron search should display branch name instead of branch code in results table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Priority: P5 - low Change sponsored?: --- Bug ID: 8812 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Staff Client: Patron search should display branch name instead of branch code in results table Severity: normal Classification: Unclassified OS: All Reporter: veron@veron.ch Hardware: All Status: NEW Version: master Component: Staff Client Product: Koha Result list in patron search should display branchname instead of branchcode. Similar reason as with Bug 8810: The name of the branch can change and the original meaning of the branchcode could be lost (that happened to us and we need a solution asap). Since branchcode is used as database key as well it would be very difficult to change it in all the tables. Patch follows. Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 12479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12479&action=edit Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |marc@msys.ch Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 12580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12580&action=edit Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 12584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12584&action=edit Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #5)
Created attachment 12584 [details] Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table
Patch to display branchname instead of branch code.
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
works as expected, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * af7db2e Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt members/member.pl * members/member.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: the branchname information is available, so I accept this patch. But it could have been written using the Koha::Template::Plugin::Branchname template plugin. With caching + new code structure, that will reduce global code size & be as efficient. Would you be OK to provide an alternative patch ? (if no, I'll push this one, no problem with it. But if you can provide a better one, I won't miss that ;-) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #8 from Marc Véron <veron@veron.ch> --- Sorry, I'm afraid I have no time at the moment to find out how to make use of Koha::Template::Plugin::Branchname template plugin. Would appreciate to see it pushed. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org