[Bug 33748] New: UI issue on addorderiso2709.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Bug ID: 33748 Summary: UI issue on addorderiso2709.pl page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org How I recreated: 1. Set MarcItemFieldsToOrder like this: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 2. Set MarcFieldsToOrder like this: price: 975$p quantity: 975$q budget_code: 975$h 3. Stage a MARC file that has bibs with items. 4. From acquisitions create a new basket and add 'From a staged file' Notices that the Item record X info is pushed to the left and the 'Match' label has a border running right through it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 151315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151315&action=edit Bug 33748: Fix UI issue when importing records from a staged MARC file To test: 1. Set MarcItemFieldsToOrder like this: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 2. Set MarcFieldsToOrder like this: price: 975$p quantity: 975$q budget_code: 975$h 3. Stage a MARC file that has bibs with items. 4. From acquisitions create a new basket and add 'From a staged file' 5. APPLY PATCH 6. Try 3 - 4 again, the display should now look correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #2 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- The patch did help improve the style but I see several issues: In 22.05 the data for Item record 1, item record 2, etc. displayed on the right side of the screen. It was nice to be able to visually connect the item data with the order data displayed directly to the left. It also makes good use of screen real estate and decreases the amount of scrolling down to the bottom in order to save. In 22.05 if there was no matching record nothing was displayed. In 22.11 the word Match: displays with no additional info since there is no match. It seems like this is extraneous and should be removed for non-matches. I attached two screenshots for the display in 22.05 and two for how it is now displaying in 22.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #3 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 151323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151323&action=edit 22.05 match -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #4 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 151324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151324&action=edit 22.05 no match -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #5 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 151325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151325&action=edit 22.11 style match -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #6 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 151326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151326&action=edit 22.11 style no match -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151315|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 151329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151329&action=edit Bug 33748: Fix UI issue when importing records from a staged MARC file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Barbara, Can you test my new patch? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- The display is much better now. Here are several things to take a look at: The three action buttons for the items are sitting right on top of a thin border line. Some space between the buttons would look better. Or, is the line needed at all? Since the item labels are of different widths it makes the input boxes display in a staggered fashion. It would be easier to view if the labels were all one width so that the input boxes could align. It was that way for me in 22.05 but it's possible I put some code in place to do that. If there is no match for the bib then 'Match:' is just hanging above the order info with no purpose. It did not display at all in 22.05 if there was no match. When clicking on the 'Item information' tab the edit_item_form does not display. I've attached a few screenshots. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #10 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 151345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151345&action=edit Original display after updated patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #11 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 151346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151346&action=edit Display after suggested tweaks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #12 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 151347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151347&action=edit Missing edit_item_form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151329|0 |1 is obsolete| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 151713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151713&action=edit Bug 33748: Fix UI issue when importing records from a staged MARC file This patch attempts to fix a UI issue on addorderiso2709.tt. It removes the <td> which contains the actoin buttons MARC, Card, and Add Order and adds them to the title line. This is so there is more space for the fieldsets. 1. Apply patch 2. Set MarcItemFieldsToOrder like this: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 3. Stage a MARC file where the bibs have items attached 4. From acquisitions create a new basket and add 'From a staged file'. 5. Add the staged files to a basket. 6. Make sure the display looks correct. 7. Expand the data by clicking on the checkbox on the left hand side, or by clicking 'Select all'. 8. Make sure the display looks correct. 9. Tab over to 'Item informtion' and make sure that display looks correct. 10. Shrink the screen size down to less that 992px, ensuring the display remains correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151713|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 151714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151714&action=edit Bug 33748: Fix UI issue when importing records from a staged MARC file This patch attempts to fix a UI issue on addorderiso2709.tt. It removes the <td> which contains the actoin buttons MARC, Card, and Add Order and adds them to the title line. This is so there is more space for the fieldsets. 1. Apply patch 2. Set MarcItemFieldsToOrder like this: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 3. Stage a MARC file where the bibs have items attached 4. From acquisitions create a new basket and add 'From a staged file'. 5. Add the staged files to a basket. 6. Make sure the display looks correct. 7. Expand the data by clicking on the checkbox on the left hand side, or by clicking 'Select all'. 8. Make sure the display looks correct. 9. Tab over to 'Item informtion' and make sure that display looks correct. 10. Shrink the screen size down to less that 992px, ensuring the display remains correct. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151714|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151896&action=edit Bug 33748: Fix UI issue when importing records from a staged MARC file This patch attempts to fix a UI issue on addorderiso2709.tt. It removes the <td> which contains the actoin buttons MARC, Card, and Add Order and adds them to the title line. This is so there is more space for the fieldsets. 1. Apply patch 2. Set MarcItemFieldsToOrder like this: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 3. Stage a MARC file where the bibs have items attached 4. From acquisitions create a new basket and add 'From a staged file'. 5. Add the staged files to a basket. 6. Make sure the display looks correct. 7. Expand the data by clicking on the checkbox on the left hand side, or by clicking 'Select all'. 8. Make sure the display looks correct. 9. Tab over to 'Item informtion' and make sure that display looks correct. 10. Shrink the screen size down to less that 992px, ensuring the display remains correct. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.01 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33748 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org