https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- We've certainly had libraries ask for something like this, although it would also need to take into account patron searching, as I've had librarians say they want to be able to search for patrons using their preferred name rather than their legal name. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123008&action=edit Bug 28633: DB Update -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123010&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferredname' to the patron record. Additionally it adds a method 'effective_name' to choose the preferred name if present and fall back to firstname To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name now displays on patron details 6 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 7 - Sign in as patron to opac 8 - Confirm preferred name shows 9 - Edit account on opac and confirm field is present -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Lisette Scheer <lisetteslatah@gmail.com> --- Signed off in the Bywater Sandbox. I also checked and you can still search by first name. I do think it's a little strange that the only place to see the first name on the staff client is by editing the patron. Might be confusing if someone is trying to figure out why a patron came up in a search. Excited for this! Lisette -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125498&action=edit Bug 28633: DO NOT PUSH Schema Changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125500&action=edit Bug 28633: (follow-up) Show legal name and add preferredname to searches This patch adds to the DB update a condition to add 'preferredname' to DefaultPatronSearchFields. It also adjust the koha defaults to include it if the pref is empty The 'firstname' is displayed as 'Legal name' on the details page, with id/class to allow ajusting via JS/CSS PatronAutoComplete/ysearch is updated to use 'effective_name' method To test: 1 - Aply patches and updatedatabase and restart_all 2 - Add a preferredname to a patron 3 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname Add preferredname if not 4 - Perform checkout and patron search using preferredname, confirm patron is found 5 - On patron's detail page confirm 'Legal name' shows 6 - Remove patron's first name, confirm 'Legal name' is no longer present 7 - Enable PatronAutoComplete system preference 8 - Type patron's surname into Checkout or patron search but don't hit enter 9 - Confirm patron is dsiplayed with 'preferredname' in the preview -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens from comment #15)

(In reply to David Cook from comment #14)

...

I'm not sure what I think about "Legal name" in this context.

I suppose if there are any cases where they have something other than their legal name in first name when also using a preferred name it just becomes a data problem which can be fixed...

"Given name"? Or should it just remain 'First name'?

Personally I think it should remain 'First name', but I'm not an expert on name terminology either heh. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #17)

A rename here would have quite a lot of consequences for documentation and such. I see a potential issue with confusing people by having a lot of different name variations and options. I think keeping the 'first name' would be good.

Another +1 for "first name." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125500|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126591&action=edit Bug 28633: (follow-up) Show first name and add preferredname to searches This patch adds to the DB update a condition to add 'preferredname' to DefaultPatronSearchFields. It also adjust the koha defaults to include it if the pref is empty The 'firstname' is displayed as 'First name' on the details page, with id/class patron_first_name to allow ajusting via JS/CSS if library wants to highlight/hide the non-preferred name PatronAutoComplete/ysearch is updated to use 'effective_name' method To test: 1 - Apply patches and updatedatabase and restart_all 2 - Add a preferredname to a patron 3 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname Add preferredname if not 4 - Perform checkout and patron search using preferredname, confirm patron is found 5 - On patron's detail page confirm 'First name' shows 6 - Remove patron's first name, confirm 'First name' is no longer present 7 - Enable PatronAutoComplete system preference 8 - Type patron's surname into Checkout or patron search but don't hit enter 9 - Confirm patron is dsiplayed with 'preferredname' in the preview -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128969&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferred_name' to the patron record. Additionally it adds a method 'effective_name' to choose the preferred name if present and fall back to firstname The 'firstname' is displayed as 'First name' on the details page, with id/class patron_first_name to allow ajusting via JS/CSS if library wants to highlight/hide the non-preferred name PatronAutoComplete/ysearch is updated to use 'effective_name' method To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name and first name now displays on patron details 6 - Remove first name from patron record and confirm it no longer shows 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 8 - Sign in as patron to opac 9 - Confirm preferred name shows 10 - Edit account on opac and confirm field is present 11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname 12 - Perform checkout and patron search using preferred_name, confirm patron is found 13 - Enable PatronAutoComplete system preference 14 - Type patron's surname into Checkout or patron search but don't hit enter 15 - Confirm patron is displayed with 'preferred_name' in the preview -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Coming back to this... sorry for the hiatus. First name works fine and I agree with all the reasoning given, well argued :) A quick test run and I'll SO.. the code all looks good to me :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128969|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130001&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferred_name' to the patron record. Additionally it adds a method 'effective_name' to choose the preferred name if present and fall back to firstname The 'firstname' is displayed as 'First name' on the details page, with id/class patron_first_name to allow ajusting via JS/CSS if library wants to highlight/hide the non-preferred name PatronAutoComplete/ysearch is updated to use 'effective_name' method To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name and first name now displays on patron details 6 - Remove first name from patron record and confirm it no longer shows 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 8 - Sign in as patron to opac 9 - Confirm preferred name shows 10 - Edit account on opac and confirm field is present 11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname 12 - Perform checkout and patron search using preferred_name, confirm patron is found 13 - Enable PatronAutoComplete system preference 14 - Type patron's surname into Checkout or patron search but don't hit enter 15 - Confirm patron is displayed with 'preferred_name' in the preview Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This works nicely now; To me, the name appears in the right places, looks good and isn't confusing and is searchable where one would expect it to be. So.. signing off on that front. It did make me take a look at some of the other name fields in patrons though, and that, I found, confusing. 'othernames' appears to partially try to do what this patch does (I'd always thought of it as 'middle names', but I note that othernames actually appears at the top of the 'contact information in double-quotes and not aligned with the rest of the information and with no label. I also find it slightly strange that 'lastname' doesn't appear in that contact information block. So.. in short.. I like this patch, but would like to see a little effort go into tidying up the members display data in some future bugs.. perhaps Owen could help there.? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- See also bug 21978 where people are requesting 'middlename' get added as another field too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30568 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130001|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133446&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferred_name' to the patron record. Additionally it adds a method 'effective_name' to choose the preferred name if present and fall back to firstname The 'firstname' is displayed as 'First name' on the details page, with id/class patron_first_name to allow ajusting via JS/CSS if library wants to highlight/hide the non-preferred name PatronAutoComplete/ysearch is updated to use 'effective_name' method To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name and first name now displays on patron details 6 - Remove first name from patron record and confirm it no longer shows 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 8 - Sign in as patron to opac 9 - Confirm preferred name shows 10 - Edit account on opac and confirm field is present 11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname 12 - Perform checkout and patron search using preferred_name, confirm patron is found 13 - Enable PatronAutoComplete system preference 14 - Type patron's surname into Checkout or patron search but don't hit enter 15 - Confirm patron is displayed with 'preferred_name' in the preview Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133448&action=edit Bug 28633: (follow-up) Account for changes with bug 30063 Bug 30063 removes the C4/Utils/DataTables/Members.pm module and instead uses the API and a patron-search include to define the default search fields. This follow-up adds preferred_name into the default fields in that include now the the module has been removed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133450&action=edit Bug 28633: (QA follow-up) Add preferred_name to ysearch This adds preferred_name to the search fields in the autocomplete search system. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133451&action=edit Bug 28633: (follow-up) Display effective name in JS search Also I fix the other header search, and ensure the 'Standard' option wil appear in dropdowns -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Nick Clemens from comment #39)

(In reply to Katrin Fischer from comment #30)

...

1) Tiny typo + description: patron's preferred named

I am not sure where you are referring to

I fixed it inline 'named -> name' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133446|0 |1 is obsolete| | --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133959&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferred_name' to the patron record. Additionally it adds a method 'effective_name' to choose the preferred name if present and fall back to firstname The 'firstname' is displayed as 'First name' on the details page, with id/class patron_first_name to allow ajusting via JS/CSS if library wants to highlight/hide the non-preferred name PatronAutoComplete/ysearch is updated to use 'effective_name' method To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name and first name now displays on patron details 6 - Remove first name from patron record and confirm it no longer shows 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 8 - Sign in as patron to opac 9 - Confirm preferred name shows 10 - Edit account on opac and confirm field is present 11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname 12 - Perform checkout and patron search using preferred_name, confirm patron is found 13 - Enable PatronAutoComplete system preference 14 - Type patron's surname into Checkout or patron search but don't hit enter 15 - Confirm patron is displayed with 'preferred_name' in the preview Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133448|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133961&action=edit Bug 28633: (follow-up) Account for changes with bug 30063 Bug 30063 removes the C4/Utils/DataTables/Members.pm module and instead uses the API and a patron-search include to define the default search fields. This follow-up adds preferred_name into the default fields in that include now the the module has been removed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133451|0 |1 is obsolete| | --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133963&action=edit Bug 28633: (follow-up) Display effective name in JS search Also I fix the other header search, and ensure the 'Standard' option wil appear in dropdowns -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133965&action=edit Bug 28633: Fix ysearch sorting This adds an IF conditional to the sorting to sort by preferred name or firstname I add the colmns to data for main patron searhc, but I cannot solve sorting there -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Suzanne <smhodson123extra@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smhodson123extra@yahoo.com --- Comment #52 from Suzanne <smhodson123extra@yahoo.com> --- Wow! There has been a lot of work on this! We are interested in being able to have the patron record show "Preferred Name" in quotation marks in the first position followed by first and middle names and then last name. So, for example, it might show as "Sammy" Suzanne Michelle Hodson, with everything being searchable and all showing up on the patron record side bar. My idea would be to let registering patrons fill in the first and middle name field and also the preferred name field and have them show up in that order on Koha, or let libraries choose how they would like the names to show up or whether to have them hidden, if that is possible. Thanks for the great efforts on this! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #53 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #51)

Should/can we revive this one?

I still have people asking for this, so it would be great to see it make it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133958|0 |1 is obsolete| | Attachment #133959|0 |1 is obsolete| | Attachment #133960|0 |1 is obsolete| | Attachment #133961|0 |1 is obsolete| | Attachment #133962|0 |1 is obsolete| | Attachment #133963|0 |1 is obsolete| | Attachment #133964|0 |1 is obsolete| | Attachment #133965|0 |1 is obsolete| | --- Comment #54 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166792&action=edit Bug 28633: DB update This adds the field to necessary tables and updates API and columns def Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #56 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166794&action=edit Bug 28633: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens (kidclamp) from comment #57)

(In reply to Katrin Fischer from comment #50)

...

Sorting in the patron search results is a little off:

I have:

Katrin Fischer Katrina Fischer Cait Fischer (where Cait is preferred name)

I think the last should be the first entry?

Otherwise all fixes from last testing appear to be ok.

I still cannot fix this - patrons without a preferred_name sort before those with one - we need some sort of conditional or function to make this sort correctly afaict, and I can't seem to make that work. If someone with more datatables or API knowledge can help I'd appreciate it.

Thanks for checking Nick. I think what was I was thinking is if we could create a sortable string like it works for dates and similar that matches the display format. But I have no idea how this works in detail. Before we give up on the idea, maybe we could get some more eyes on it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166792|0 |1 is obsolete| | Attachment #166793|0 |1 is obsolete| | Attachment #166794|0 |1 is obsolete| | --- Comment #59 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166813&action=edit Bug 28633: DB update This adds the field to necessary tables and updates API and columns def Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166815&action=edit Bug 28633: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #63 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166817&action=edit Bug 28633: Make 'effective_name' embeddable This patch makes the calculated value of `Koha::Patron->effective_name` embeddable in the patrons routes. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #65 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- After soliciting some more opinions, I am marking this FQA for the search results issue. Inaccurate sorting of patrons by name will cause too much confusion for thi to be usable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #67 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #66)

Hi Andrew, thanks for doing that - asking around. I still hope that the sorting is a solvable issue.

Strong agree, I'm very much in favor of this feature and would love to see it move forward! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com --- Comment #69 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- Could sort be based on effective_name? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #71 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 167164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167164&action=edit Bug 28633: POC - Add sort_name for patron This is just a possible solution, add a new "sort" name for patrons - we could expand the calculations here if needed, but essentially we just store the effective name, making it available for SQL sorting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #73 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #72)

BUT things go weird if preferred_name is NULL -- in KTD the default data has preferred_name null but saves new/edited patrons with a blank instead. In the real world, I imagine patrons could be imported with a NULL value. With NULL preferred_names I get:

- surname: Acevedo, preferred_name: NULL, firstname: Henry - surname: Acevedo, preferred_name: NULL, firstname: Hosea - surname: Acevedo, preferred_name: NULL, firstname: Hank

I originally thought we could simply add a default value - however, TEXT columns cannot have a default value in MySQL - MariaDB does allow this Either we need to supply the default on storing - or build and internal functions - OR make sort_name a VARCHAR, but it would be storing a longtext so would be problematic - I am not sure why name fields are longtext This may mean sort_name is a unacceptable solution -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #75 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Emily Lamancusa from comment #74)

Andrew, how are you setting the preferred_names to NULL in your last example? I'm wondering if it's the NULLs per se that are causing the issue, or if the problem is that sort_name isn't getting updated.

I don't believe there is a way to use the GUI to either create a patron with a NULL preferred name or edit a patron to have one. I believe patron imports are the only way to get a NULL. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Something like `ORDER BY COALESCE(NULLIF(preferred_name, ''), first_name), last_name` you mean? We'll still need to work out how to wrap that for the API... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #80 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #79)

(In reply to Martin Renvoize from comment #78)

...

Something like `ORDER BY COALESCE(NULLIF(preferred_name, ''), first_name), last_name` you mean?

We'll still need to work out how to wrap that for the API...

Yes, because I think having it as a real database column might add some technical debt/more stuff to maintain. If we could avoid it with reasonable effort that might be nice.

It's the combination of API and Datatables here that I was unable to resolve - the query is being bult by datatables, so I think we would need to intercept the sorting column in the API and convert it to the SQL we need. IMO the column simplifies the code we need in the end, but am happy to see if someone else can solve the API issue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It has been coded and working through issues wince 2021... we can't sit at 'perfect it more' forever ;P That said.. I'll take a look and see if there's a way we can overload at the dbic level for sorting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This 'might' be achievable with an extension to the query_fixer stuff. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #85 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Maybe time to come back to this one, and work on API improvements in a separate bug? :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166813|0 |1 is obsolete| | Attachment #166814|0 |1 is obsolete| | Attachment #166815|0 |1 is obsolete| | Attachment #166816|0 |1 is obsolete| | Attachment #166817|0 |1 is obsolete| | Attachment #167163|0 |1 is obsolete| | Attachment #167164|0 |1 is obsolete| | --- Comment #86 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173628&action=edit Bug 28633: DB update This adds the field to necessary tables and updates API and columns def Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #88 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173630&action=edit Bug 28633: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #90 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173632&action=edit Bug 28633: Make 'effective_name' embeddable This patch makes the calculated value of `Koha::Patron->effective_name` embeddable in the patrons routes. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #92 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173634&action=edit Bug 28633: DO NOT PUSH: Schema changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173628|0 |1 is obsolete| | --- Comment #94 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173664&action=edit Bug 28633: DB update This adds the field to necessary tables and updates API and columns def Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173630|0 |1 is obsolete| | --- Comment #96 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173666&action=edit Bug 28633: DO NOT PUSH Schema changes Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173632|0 |1 is obsolete| | --- Comment #98 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173668&action=edit Bug 28633: Make 'effective_name' embeddable This patch makes the calculated value of `Koha::Patron->effective_name` embeddable in the patrons routes. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173634|0 |1 is obsolete| | --- Comment #100 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173670&action=edit Bug 28633: DO NOT PUSH: Schema changes Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #103 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173718&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferred_name' to the patron record. On storage (creation or update) the preferred_name is set to the firstname if no value is passed. Patron modifications will set the preferred name to the firstname if the preferred_name field is hidden With this patchset preferred_name will always be set - either to the firstname, or a specified value. PatronAutoComplete/ysearch is updated to use 'preferred_name' To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name and first name now displays on patron details 6 - Remove first name from patron record and confirm it no longer shows 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 8 - Sign in as patron to opac 9 - Confirm preferred name shows 10 - Edit account on opac and confirm field is present 11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname 12 - Perform checkout and patron search using preferred_name, confirm patron is found 13 - Enable PatronAutoComplete system preference 14 - Type patron's surname into Checkout or patron search but don't hit enter 15 - Confirm patron is displayed with 'preferred_name' in the preview 16 - Set 'preferred_name' in all 'Unwanted' preferences 17 - Confirm editing a patron in staff interface sets both fields when firstname updated 18 - Confirm a patron modification sets both fields when firstname updated 19 - Create a patron / perform self registration and confirm both fields set when preferred_name is hidden 20 - Remove preferred_name from Unwanted prefs and confirm preferred_name is set to firstname if nothing passed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #105 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- New patches based on feedback from Martin - removed effective_name and sort_name in favor of setting preferred_name from firstname if not defined When the field is hidden, it should be largely invisible to users, except in action log changes When visible - it will always be set, so may be duplicated for patrons with no preferred name, but I think it is better to be obvious than to hide what is happening. Patron displays will always use preferred_name, only on patron details/etc would you see both -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #108 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173814&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferred_name' to the patron record. On storage (creation or update) the preferred_name is set to the firstname if no value is passed. Patron modifications will set the preferred name to the firstname if the preferred_name field is hidden With this patchset preferred_name will always be set - either to the firstname, or a specified value. PatronAutoComplete/ysearch is updated to use 'preferred_name' To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name and first name now displays on patron details 6 - Remove first name from patron record and confirm it no longer shows 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 8 - Sign in as patron to opac 9 - Confirm preferred name shows 10 - Edit account on opac and confirm field is present 11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname 12 - Perform checkout and patron search using preferred_name, confirm patron is found 13 - Enable PatronAutoComplete system preference 14 - Type patron's surname into Checkout or patron search but don't hit enter 15 - Confirm patron is displayed with 'preferred_name' in the preview 16 - Set 'preferred_name' in all 'Unwanted' preferences 17 - Confirm editing a patron in staff interface sets both fields when firstname updated 18 - Confirm a patron modification sets both fields when firstname updated 19 - Create a patron / perform self registration and confirm both fields set when preferred_name is hidden 20 - Remove preferred_name from Unwanted prefs and confirm preferred_name is set to firstname if nothing passed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #110 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173816&action=edit Bug 28633 (follow-up) Add note about disabling/hiding preferred name to sysprefs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173814|0 |1 is obsolete| | --- Comment #112 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173827&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferred_name' to the patron record. On storage (creation or update) the preferred_name is set to the firstname if no value is passed. Patron modifications will set the preferred name to the firstname if the preferred_name field is hidden With this patchset preferred_name will always be set - either to the firstname, or a specified value. PatronAutoComplete/ysearch is updated to use 'preferred_name' To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name and first name now displays on patron details 6 - Remove first name from patron record and confirm it no longer shows 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 8 - Sign in as patron to opac 9 - Confirm preferred name shows 10 - Edit account on opac and confirm field is present 11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname 12 - Perform checkout and patron search using preferred_name, confirm patron is found 13 - Enable PatronAutoComplete system preference 14 - Type patron's surname into Checkout or patron search but don't hit enter 15 - Confirm patron is displayed with 'preferred_name' in the preview 16 - Set 'preferred_name' in all 'Unwanted' preferences 17 - Confirm editing a patron in staff interface sets both fields when firstname updated 18 - Confirm a patron modification sets both fields when firstname updated 19 - Create a patron / perform self registration and confirm both fields set when preferred_name is hidden 20 - Remove preferred_name from Unwanted prefs and confirm preferred_name is set to firstname if nothing passed Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #114 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173829&action=edit Bug 28633: (follow-up) Add note about disabling/hiding preferred name to sysprefs Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38317 [Bug 38317] Support hiding preferred_name from patron modification screen on OPAC but not staff client (or vice versa) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173827|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173931&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferred_name' to the patron record. On storage (creation or update) the preferred_name is set to the firstname if no value is passed. Patron modifications will set the preferred name to the firstname if the preferred_name field is hidden With this patchset preferred_name will always be set - either to the firstname, or a specified value. PatronAutoComplete/ysearch is updated to use 'preferred_name' To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name and first name now displays on patron details 6 - Remove first name from patron record and confirm it no longer shows 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 8 - Sign in as patron to opac 9 - Confirm preferred name shows 10 - Edit account on opac and confirm field is present 11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname 12 - Perform checkout and patron search using preferred_name, confirm patron is found 13 - Enable PatronAutoComplete system preference 14 - Type patron's surname into Checkout or patron search but don't hit enter 15 - Confirm patron is displayed with 'preferred_name' in the preview 16 - Set 'preferred_name' in all 'Unwanted' preferences 17 - Confirm editing a patron in staff interface sets both fields when firstname updated 18 - Confirm a patron modification sets both fields when firstname updated 19 - Create a patron / perform self registration and confirm both fields set when preferred_name is hidden 20 - Remove preferred_name from Unwanted prefs and confirm preferred_name is set to firstname if nothing passed Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173829|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173933&action=edit Bug 28633: (follow-up) Add note about disabling/hiding preferred name to sysprefs Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #120 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173935&action=edit Bug 28633: (QA follow-up) Tidy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #122 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Some odd rebase issues, but I fixed those in QA follow-ups. All looking great here, thanks for all the work Nick. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #126 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 174419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174419&action=edit Bug 28633: (follow-up) Set preferred name and adjust counts for tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #128 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked follow-up for main: Bug 28633: (follow-up) Set preferred name and adjust counts for tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #130 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I don't believe those come from this - it's unrelated code, Tomas is looking -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #132 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174472&action=edit Bug 28633: Fix patrons_search.t This does not belong here, but raised to me here, so attaching on this one. This feels like it's coming from bug 33484, but those tests were passing after it has been pushed. This patch fixes the following error: Error while executing command: stale element reference: The element reference of <input type="text"> is stale; either the element is no longer attached to the DOM, it is not in the current frame context, or the document has been refreshed at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. Since bug 33484 the row with the filters is redrawn on table redraw. So we need to search for the input every time the table is redrawn. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |column to the borrowers | |table, 'preferred_name'. | |This will be visible in | |staff and opac patron | |information forms by | |default. This column takes | |precedence in display and | |will show where patrons are | |displayed throughout Koha. | |If not populated or field | |is hidden, the firstname | |will be copied into the | |preferred_name field fir | |display. Use of 'firstname' | |in notices and other | |templates will continue to | |display the firstname, | |switching to | |'preferred_name' will | |display the new field. | |When | |hiding this field, it | |should be hidden in all | |interfaces to avoid any | |discrepancies or confusion. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a new |This patch adds a new release notes|column to the borrowers |column to the borrowers |table, 'preferred_name'. |table, 'preferred_name'. |This will be visible in |This will be visible in |staff and opac patron |staff and OPAC patron forms |information forms by |by default. This column |default. This column takes |takes precedence in display |precedence in display and |and will show where patrons |will show where patrons are |are displayed throughout |displayed throughout Koha. |Koha. If not populated or |If not populated or field |field is hidden, the first |is hidden, the firstname |name will be copied into |will be copied into the |the preferred name field |preferred_name field fir |for display. Use of |display. Use of 'firstname' |'firstname' in notices and |in notices and other |other templates will |templates will continue to |continue to display the |display the firstname, |first name, switching to |switching to |'preferred_name' will |'preferred_name' will |display the new field. |display the new field. |When |When |hiding this field, it |hiding this field, it |should be hidden in all |should be hidden in all |interfaces to avoid any |interfaces to avoid any |discrepancies or confusion. |discrepancies or confusion. | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the|This patch adds a new |This new feature adds a new release notes|column to the borrowers |"Preferred name" field to |table, 'preferred_name'. |patron information. This is |This will be visible in |visible in staff and OPAC |staff and OPAC patron forms |patron forms by default. |by default. This column | |takes precedence in display |Notes: |and will show where patrons |1. The "Preferred |are displayed throughout |name" field takes |Koha. If not populated or |precedence, and is |field is hidden, the first |displayed where patron |name will be copied into |names are displayed |the preferred name field |throughout Koha. |for display. Use of |2. If the |'firstname' in notices and |"Preferred name" field has |other templates will |no value, or it is hidden, |continue to display the |the first name will be |first name, switching to |displayed. |'preferred_name' will |3. Notices: Use |display the new field. |of 'firstname' in notices |When |and other templates will |hiding this field, it |continue to display the |should be hidden in all |first name, using |interfaces to avoid any |'preferred_name' will |discrepancies or confusion. |display the patron's | |preferred name. | |4. Hiding | |fields: When hiding this | |field, it should be hidden | |in all interfaces to avoid | |any discrepancies or | |confusion | |(BorrowerUnwantedField, | |PatronSelfModificationBorro | |werUnwantedField, | |PatronSelfRegistrationBorro | |werUnwantedField, | |PatronSelfModificationManda | |toryField, | |PatronSelfRegistrationBorro | |werMandatoryField). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #136 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175177&action=edit Bug 28633: (follow-up) Update sample data with preferred_name This patch updates the sample_date, as used in koha-testing-docker, with the new preferred_name field. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #137 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could you move the patch to a separate bug please? Only reason: that way I don't need to remember to remove this "new feature" form release notes for 25.05 manually in 6 months :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38622 [Bug 38622] Fix Koha sample data to include preferred_name -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #139 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #138)

(In reply to Katrin Fischer from comment #137)

...

Could you move the patch to a separate bug please? Only reason: that way I don't need to remember to remove this "new feature" form release notes for 25.05 manually in 6 months :)

... or I will do it in a few mins.

Moved to bug 38622. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38735 [Bug 38735] New installations should include preferred_name in DefaultPatronSearchFields by default -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |inkeri.hakulinen+bugz@helsi | |nki.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40484 [Bug 40484] Add a way for staff to view firstname in patron search results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #142 from David Cook <dcook@prosentient.com.au> --- This change doesn't play so nicely with older third-party tools... The logic on which name to display when/where is a bit weird and can lead to no first name or preferred name showing anywhere but c'est la vie. I'll figure something out... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 [Bug 39587] Patron surname missing from contact information list on patron details tab -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41986 [Bug 41986] Names in "Contact information" need more clarity -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43476 [Bug 43476] updatedatabase.pl produces warnings -- You are receiving this mail because: You are watching all bug changes.