[Bug 9879] New: Use DataTables on suggestions management page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 Bug ID: 9879 Summary: Use DataTables on suggestions management page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/suggestion/suggestion.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The suggestions management page uses the old tablesorter plugin. It should use the DataTables plugin instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16558&action=edit Bug 9879 - Use DataTables on suggestions management page Replace the tablesorter plugin with the DataTables plugin on the suggestions management page. Table sorting has been coverted from using multiple specific IDs to a more efficient class-based selector. Unrelated change: Prevent page-jumping when checkbox links are clicked. To test, open the suggestions management page (Acquisitions -> Suggestions). Confirm that table sorting, paging, and searching works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I will accept this for 3.12, since it is fixing the general bug "Koha still uses tablesorter." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16558|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16572&action=edit Bug 9879 - Use DataTables on suggestions management page Replace the tablesorter plugin with the DataTables plugin on the suggestions management page. Table sorting has been coverted from using multiple specific IDs to a more efficient class-based selector. Unrelated change: Prevent page-jumping when checkbox links are clicked. To test, open the suggestions management page (Acquisitions -> Suggestions). Confirm that table sorting, paging, and searching works correctly. Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch replaces tablesorter with Datatable on the suggestions management page. Owen uses "e.preventDefault()" where I would use "return false;", but it does the same job! Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16572|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16668&action=edit Bug 9879 - Use DataTables on suggestions management page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9879 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org