https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Something sounds wrong here, I'd suggest that GetCategoryByKohaField should be replaced with Koha::AuthorisedValues->search_by_koha_field->categories, do not you think? Failing QA because of CamelCase for GetCategoryByKohaField and lack of tests. Note: I did not test but I'd expect my @items = Koha::Items->search({ itemnumber => { -in => \@itemnumbers } }); to be faster and easier to read than: my @items; foreach my $itemnumber (@itemnumbers) { my $item = Koha::Items->find($itemnumber); if ($item) { push @items, $item; } } -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #3)

Something sounds wrong here, I'd suggest that GetCategoryByKohaField should be replaced with Koha::AuthorisedValues->search_by_koha_field->categories, do not you think?

I'm not sure, what would be the return value of Koha::AuthorisedValues->search_by_koha_field('items.barcode') for example ? A list of the authorised values of the category linked to items.barcode ? What I want is a single AV category, so for me it makes sense to have a Koha::AVCategories->findBy... method.

Failing QA because of CamelCase for GetCategoryByKohaField and lack of tests.

All Koha::Template::Plugin::* methods are in CamelCase. I think you meant findByKohaField, right ?

Note: I did not test but I'd expect my @items = Koha::Items->search({ itemnumber => { -in => \@itemnumbers } });

to be faster and easier to read than:

my @items; foreach my $itemnumber (@itemnumbers) { my $item = Koha::Items->find($itemnumber); if ($item) { push @items, $item; } }

Probably, I'm not familiar with the search() parameters yet, that's why I dit it that way. (In reply to Jonathan Druart from comment #4)

You should also use Text::CSV to build the CSV content.

It's not really CSV, just a simple text file with one barcode per line, so what's the benefit of using Text::CSV ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 62358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62358&action=edit Bug 18433: QA fixes - Use snake_case for Koha::AuthorisedValueCategories method name - Replace a loop of Koha::Items->find by a single call to Koha::Items->search - Add unit tests for Koha::AuthorisedValueCategories::find_by_koha_field -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Koha::Item->biblioitem should be moved to its own bug report and covered by tests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62358|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 62389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62389&action=edit Bug 18433: QA fixes - Use snake_case for Koha::AuthorisedValueCategories method name - Replace a loop of Koha::Items->find by a single call to Koha::Items->search - Add unit tests for Koha::AuthorisedValueCategories::find_by_koha_field -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18459 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18459 [Bug 18459] Add the Koha::Item->biblioitem method -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62416&action=edit Bug 18433: Add new subroutine GetDescriptionByKohaField to AuthorisedValues TT plugin To allow quick access to AV description -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think I finally found what was wrong. Take a look at the 2 last patches. What you actually want is Koha::AuthorisedValues->get_description_by_koha_field. But you missed a TT plugin for an easy access. This method is cached and so certainly much powerful than what your were trying to do. Let me know if you have any questions. If you agree we will need to use this sub from the 2 other files, remove the tests and the new method you added. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 62449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62449&action=edit Bug 18433: Remove Koha::AuthorisedValueCategories::find_by_koha_field Use Koha::AuthorisedValues::*_by_koha_field instead -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62388|0 |1 is obsolete| | Attachment #62389|0 |1 is obsolete| | Attachment #62390|0 |1 is obsolete| | Attachment #62416|0 |1 is obsolete| | Attachment #62417|0 |1 is obsolete| | Attachment #62449|0 |1 is obsolete| | --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 62472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62472&action=edit Bug 18433: Allow to select results to export in item search This adds a column of checkboxes in the results table to be able to select the items to be exported Test plan: 1. Go to item search and click 'Search' 2. Without checking any checkbox, verify that the export still works (it should export all results) 3. Tick some checkboxes and re-export, verify that only selected items are exported Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Bug 18433 depends on bug 18459, which changed state. Bug 18459 Summary: Add the Koha::Item->biblioitem method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18459 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #24)

Hum, I get "Template process failed: undef error - The method biblioitem is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121." when I export to CSV.

If I apply the patch on a fresh master, I don't get this error, as Koha::Item::biblioitem is defined. You said on bug 18459 that the patch isn't in master, but it is (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6527b3b67506db02...) so a git fetch + git rebase should fix the problem

Something else I completely missed before: if you select rows then switch to another page the behaviour will not work as expected.

What are you expecting exactly ? That the hidden rows keep their 'selected' state ? Or that the "Export selected results to" label changes back to "Export all results to" because there is no visible selected rows anymore ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- I agree with Jonathan that the best behavior would be to allow the user to select items on multiple pages and have it remember across pages. I say this not knowing how difficult it might be to implement it. At the very least the "Export selected results" button should return to its default state if the first page of selections is getting lost, but I don't think it's enough. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #28)

Maybe this should be splitted into one bug changing Koha::Template::Plugin::AuthorisedValues and this bug focusing on changes in item search.

The 2 methods added to the TT plugin are part of master now (since bug 9573). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #30 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #29)

(In reply to Fridolin SOMERS from comment #28)

...

Maybe this should be splitted into one bug changing Koha::Template::Plugin::AuthorisedValues and this bug focusing on changes in item search.

The 2 methods added to the TT plugin are part of master now (since bug 9573).

Ah super. Only needs rebase then. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 97479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97479&action=edit Bug 18433: Remember item search results selected rows in session storage Session storage is not shared between browser tabs, and is cleared when a tab is closed, so it seems like a good fit for storing selected rows Test plan: 1. Go to item search (intranet) and submit the form 2. Select some rows on the first page by clicking on checkboxes 3. Go to another page of results 4. Select more rows 5. Go back to the first page 6. Selected rows should still be checked 7. Play with sorting and filtering, and see that selected rows are always checked 8. Export as CSV and as a barcodes file, verify that the export contains all selected rows 9. Click on 'Clear selection', it should deselect all rows from all pages 10. Select some rows again 11. Click on 'Edit search' and submit the same search 12. No row should be selected 13. Select some rows again 14. Refresh the page and submit again the same search 15. No row should be selected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #35 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #33)

This is still valid.

Not anymore ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97479|0 |1 is obsolete| | --- Comment #37 from David Nind <david@davidnind.com> --- Created attachment 99124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99124&action=edit Bug 18433: Remember item search results selected rows in session storage Session storage is not shared between browser tabs, and is cleared when a tab is closed, so it seems like a good fit for storing selected rows Test plan: 1. Go to item search (intranet) and submit the form 2. Select some rows on the first page by clicking on checkboxes 3. Go to another page of results 4. Select more rows 5. Go back to the first page 6. Selected rows should still be checked 7. Play with sorting and filtering, and see that selected rows are always checked 8. Export as CSV and as a barcodes file, verify that the export contains all selected rows 9. Click on 'Clear selection', it should deselect all rows from all pages 10. Select some rows again 11. Click on 'Edit search' and submit the same search 12. No row should be selected 13. Select some rows again 14. Refresh the page and submit again the same search 15. No row should be selected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99160&action=edit Bug 18433: Remember item search results selected rows in session storage Session storage is not shared between browser tabs, and is cleared when a tab is closed, so it seems like a good fit for storing selected rows Test plan: 1. Go to item search (intranet) and submit the form 2. Select some rows on the first page by clicking on checkboxes 3. Go to another page of results 4. Select more rows 5. Go back to the first page 6. Selected rows should still be checked 7. Play with sorting and filtering, and see that selected rows are always checked 8. Export as CSV and as a barcodes file, verify that the export contains all selected rows 9. Click on 'Clear selection', it should deselect all rows from all pages 10. Select some rows again 11. Click on 'Edit search' and submit the same search 12. No row should be selected 13. Select some rows again 14. Refresh the page and submit again the same search 15. No row should be selected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99162&action=edit Bug 18433: Display the number of selected items Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #44 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #43)

Do you agree with that patch?

Yep. I haven't tested it, but patch looks good. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com Resolution|--- |FIXED --- Comment #46 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #47 from David Cook <dcook@prosentient.com.au> --- This change causes the regression reported in Bug 27565. -- You are receiving this mail because: You are watching all bug changes.