[Bug 24159] New: Short loan collection issues on a day marked as closed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Bug ID: 24159 Summary: Short loan collection issues on a day marked as closed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Scenario: * The library has a 4wk loan item type and a 1hr loan item type. * The library would like 1hr loan item types to be issued and returned on a day marked as closed in the circ calendar, but only allow 4wk loan types to be returned on an open day. Currently, if a 1hr loan is issued on a closed day, the due date is pushed back to the next open day, overriding the duration of the loan. If the usedaysmode syspref is set to "Circulation rules only" due dates for 1hr loan items are calculated at 1hr later as defined in the circ rules, however 4wk loan due dates can potentially be set to closed days. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |mark.gavillet@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99758&action=edit Bug 24159: Move useDaysMode pref to circulation rules Moving the useDaysMode system preference to a circulation rule will add much more flexibility in the calculation of the due date. The initial request was to make hourly loan returned on closed when (when checked out on the same close day). To do so we do not want to take into account the calendar. However the calendar need to be taken into account for other loan item types. Other scenarios are possible, for instance depending on the branch. This patchset will add a new "Days mode" column (next to "Loan period") to the circulation rules page, with the different values of the "useDaysMode" system preference + a "default" value, to default to the system preference value. Test plan: - Define a long loan item type (like 10 days) that will use the calendar (or default to the pref value, if the pref is not set to "ignore the calendar") - and a hourly loan (like 2 hours) that will ignore the calendar - Create items with those item types - Mark today as a closed day - Check the items out => The hourly loan is due the same day => The other loan is due on an open day QA note: There is the need to force the "days_mode" option when Koha::Calendar is initiated for the due date calculation. To make sure devs will not forget it, the methods that need have it defined will throw an exception. Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99759&action=edit Bug 24159: Throw an exception if days_mode option is not given when needed Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99760&action=edit Bug 24159: Add UI changes Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99761&action=edit Bug 24159: Adjust tests Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99762&action=edit Bug 24159: Add new tests for get_useDaysMode_effective_value Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99758|0 |1 is obsolete| | Attachment #99759|0 |1 is obsolete| | Attachment #99760|0 |1 is obsolete| | Attachment #99761|0 |1 is obsolete| | Attachment #99762|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100608&action=edit Bug 24159: Move useDaysMode pref to circulation rules Moving the useDaysMode system preference to a circulation rule will add much more flexibility in the calculation of the due date. The initial request was to make hourly loan returned on closed when (when checked out on the same close day). To do so we do not want to take into account the calendar. However the calendar need to be taken into account for other loan item types. Other scenarios are possible, for instance depending on the branch. This patchset will add a new "Days mode" column (next to "Loan period") to the circulation rules page, with the different values of the "useDaysMode" system preference + a "default" value, to default to the system preference value. Test plan: - Define a long loan item type (like 10 days) that will use the calendar (or default to the pref value, if the pref is not set to "ignore the calendar") - and a hourly loan (like 2 hours) that will ignore the calendar - Create items with those item types - Mark today as a closed day - Check the items out => The hourly loan is due the same day => The other loan is due on an open day QA note: There is the need to force the "days_mode" option when Koha::Calendar is initiated for the due date calculation. To make sure devs will not forget it, the methods that need have it defined will throw an exception. Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100609&action=edit Bug 24159: Throw an exception if days_mode option is not given when needed Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100610&action=edit Bug 24159: Add UI changes Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100611&action=edit Bug 24159: Adjust tests Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100612&action=edit Bug 24159: Add new tests for get_useDaysMode_effective_value Sponsored-by: Institute of Technology Carlow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100613&action=edit Bug 24159: Set days_mode according to circ rules in 3 other places There are 3 other occurrences where the new circ rule can be used: * C4::Circulation::checkHighHolds * Koha::Hold->set_waiting * misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl Test plan: * checkHighHolds Enable decreaseLoanHighHolds and fill decreaseLoanHighHoldsDuration Setup things to hit a "high demand" alert with a shortened due date Check an item out => The due date must be recalculated depending on the circ rule useDaysMode. * set_waiting Set ExcludeHolidaysFromMaxPickUpDelay to "1" (note that there is currently a bug in the description of the syspref, see bug 22381 comment 19) Mark a hold waiting The expiration date should have been set depending on the value of the circ rule. * TalkingTech cronjob Cannot test this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100614&action=edit Bug 24159: Use days_mode circ rule to calculate the dropbox date Calculate the drop box date depending on the circ rule. Note that only the branchcode is taken into account here. Is that correct? Test plan: Use the drop box date feature and confirm that it takes into account the calendar, depending on the circ rule. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100615&action=edit Bug 24159: Fix one occurrence in updatedatabase.pl Here we just want to get the value from the syspref, the circ rule does not exist yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Short loan collection |Short loan collection |issues on a day marked as |issues on a day marked as |closed |closed (move useDaysMode to | |circ rules) Blocks| |15523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Paul Thornton <paul.thornton@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.thornton@educampus.ie --- Comment #14 from Paul Thornton <paul.thornton@educampus.ie> --- Created attachment 101053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101053&action=edit Test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #15 from Paul Thornton <paul.thornton@educampus.ie> --- Created attachment 101054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101054&action=edit Test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #16 from Paul Thornton <paul.thornton@educampus.ie> --- Hello Jonathan I'm coordinating testing with Simon Perry, and he raised the following issue: "I’ve hit problems with this bug. I created a test bibliographic record with two items records attached (one as an hourly loan and one as a long loan – see attachment for details), set yesterday as a closed day in the calendar and issued both items to a patron. I hadn’t changed the UseDaysMode syspref, so I wanted to check the items in, change the syspref and then reissue. I’ve found that I can’t check either item in and am getting a string of error messages when I try to check in (attached). Note that I deleted the closed day entry in the calendar for yesterday to see if it would make a difference to checkin – it didn’t work. Do you want to investigate or create a new sandbox so that I can retest?" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Paul Thornton <paul.thornton@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.perry@itcarlow.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Paul, Can you confirm you were testing with all the patches applied? Mark reported me this error by email, but that should have been fixed by the patches I attached here on March 12th. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #18 from Paul Thornton <paul.thornton@educampus.ie> --- Hello Jonathan I touched base with Simon and he says the best thing would be if PTFS can re-send the link to the sandbox for this bug and he can retest. Can you organise that please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #19 from Simon Perry <simon.perry@itcarlow.ie> --- Created attachment 101556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101556&action=edit Test 24/3/20 Attached is testing completed today. I tested all 4 options available in the useDaysMode syspref. Only for the Ignore and Use calendar to push due date to next pen matching weekday.... syspref settings did the checkout due date/hour remain on the days of checkout. This wouldn't work for our live system settings as noted. Regards, Simon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hello Simon, This development moves the system preference to the circulation rules, for more granularity. On the circulation rules you should see a new column "Days mode" with 5 different options. In your case, I think what you need is: Set the syspref to "Push the due date to next open day" Define a circulation rule for Hourly loan and select "Ignore the Calendar" in the "Days mode" column. Note that there is a small cosmetic bug on the circulation table, the header of the table says "Unit" instead of "Days mode". The footer is correct but there is a shift in the header. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101649&action=edit Bug 24159: Fix shift in the header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #22 from Simon Perry <simon.perry@itcarlow.ie> --- Created attachment 101698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101698&action=edit Test 25/3/20 Hi Jonathan, thanks for clarification. I just retested with today set as closed day in Calendar, Days mode in hourly circulation rule set to 'Calendar' (the dropdown menu for the Days Mode only says 'Calendar' not 'Ignore the Calendar' btw) and useDaysMode syspref set to 'Use the Calendar to push the due date to next due day.' When I checked out an hourly loan item, the due date was moved on to tomorrow, not retained as today's. Please see screenshot attachment for details. Do you want me to test with other options set for useDaysMode etc.? Simon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Simon, I think I understand where the confusion comes from. The values in the circulation rules have the following meaning: Days: Ignore the calendar Calendar: Use the calendar to skip days the library is closed Datedue: Use the calendar to push the due date to the next open day Dayweek: Use the calendar to push the due date to the next open matching weekday for weekly loan periods, or the next open day otherwise They are the "internal values" of the syspref. It's not ideal but we cannot use the long descriptions in the dropdown list in the circ rules table, that will be too wide. It seems that it is not enough but to avoid the confusion there is a tooltip that is displayed (over the cursor on the cell): https://snipboard.io/We6flu.jpg it cannot be seen on the screenshot, but the cursor is on "Days". If you have anything else to suggest to make it less confusing, let me know! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #24 from Simon Perry <simon.perry@itcarlow.ie> --- Thanks for clarification Jonathan, from your comments it looks like I should be selecting the 'Days' (ignore calendar) for the hourly loan. Am I right in assuming that the DaysMode column in the Circulation rules table will override what is set in the useDaysMode syspref? And therefore if the Days Mode column in the Circ. rules table is set to 'Default' it will use whatever value is set for the useDaysMode syspref? Tooltip is useful and I guess the other thing is to ensure it is well documented in the Koha circulation help. I'll retest and feedback results. Regards, Simon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Simon Perry from comment #24)
Thanks for clarification Jonathan, from your comments it looks like I should be selecting the 'Days' (ignore calendar) for the hourly loan. Am I right in assuming that the DaysMode column in the Circulation rules table will override what is set in the useDaysMode syspref? And therefore if the Days Mode column in the Circ. rules table is set to 'Default' it will use whatever value is set for the useDaysMode syspref?
Yes, that's exactly how it is supposed to work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #26 from Simon Perry <simon.perry@itcarlow.ie> --- Created attachment 102009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102009&action=edit testing 270320 Hi Jonathan, I've now tested with UsedaysMode set to 'Push due date to next open day' and Days Mode set to 'Days' for the hourly loan rule. Checkout for an hourly loan item type with today set as a library closed day correctly retained today as the due date with an hour's loan allowed. See screenshots of test. I'd like to do some more testing with different useDaysMode syspref values before signing off. Unfortunately the sandbox has got very slow for some reason this afternoon (in fact I cannot connect to it right now). Maybe it could do with a refresh? I'll check again on Monday. Regards, Simon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #27 from Simon Perry <simon.perry@itcarlow.ie> --- Created attachment 102148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102148&action=edit Bug 24159 test 31 March Hi Jonathan, Just started testing again. I had the sandbox set to the following configuration: (1) useDaysMode syspref – Use Calendar to push due date to the next open day Today – closed day in calendar Circulation rules hourly loan Days Mode column – days (ignore calendar) Result Hourly loan – correct loan due date same 1hr loan Long loan -correct due date 6/4/20 the hourly loan checked out correctly retaining today's date and advancing due time by 1 hour from checkout, but when I tried to check the hourly loan and the long loan I got a checkin error again. See attachment for details. Not sure if this is just sandbox playing up or something else but thought you should know. Regards, Simon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks for reporting that Simon, that seems a sandbox-related bug. I will ask Martin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #28)
Thanks for reporting that Simon, that seems a sandbox-related bug. I will ask Martin.
PTFS-E Sandboxes updated to use a newer MariaDB version with the auto-increment fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #30 from Simon Perry <simon.perry@itcarlow.ie> --- Created attachment 102303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102303&action=edit Sandbox error Hi, I've just tried to complete testing but am getting an error when I try to add a new bib record or item for testing. See attached for details. Thanks, Simon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hello Simon, We have been fighting with an annoying bugs the last 2 days. The error you saw is not related to these patches, but bug 25040 (but you do not need to care about, it's technical). We fixed it in the sandbox manually. I do not know if you have been told to "refresh the schema" before trying the sandbox, but you should not until bug 25040 is pushed to master. Basically the sandbox is ready for testing, biblio and item creation is ok now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #32 from Simon Perry <simon.perry@itcarlow.ie> --- Hi, I lost contact with http://staff-bug24159.sandboxes.ptfs-europe.co.uk/ on Friday afternoon. I still can't connect today. I just want to run a couple more tests before signing off so could access be restored please. Thanks, Simon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Simon Perry <simon.perry@itcarlow.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|jonathan.druart@bugs.koha-c |simon.perry@itcarlow.ie |ommunity.org | --- Comment #33 from Simon Perry <simon.perry@itcarlow.ie> --- Created attachment 102554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102554&action=edit Final patch testing Hi, I've completed final testing (details attached for information). I tried a few different settings in the Circulation Days Mode column just to check that other options worked as I would expect. Now signing off bug. Regards, Simon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100608|0 |1 is obsolete| | --- Comment #34 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 102555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102555&action=edit Bug 24159: Move useDaysMode pref to circulation rules Moving the useDaysMode system preference to a circulation rule will add much more flexibility in the calculation of the due date. The initial request was to make hourly loan returned on closed when (when checked out on the same close day). To do so we do not want to take into account the calendar. However the calendar need to be taken into account for other loan item types. Other scenarios are possible, for instance depending on the branch. This patchset will add a new "Days mode" column (next to "Loan period") to the circulation rules page, with the different values of the "useDaysMode" system preference + a "default" value, to default to the system preference value. Test plan: - Define a long loan item type (like 10 days) that will use the calendar (or default to the pref value, if the pref is not set to "ignore the calendar") - and a hourly loan (like 2 hours) that will ignore the calendar - Create items with those item types - Mark today as a closed day - Check the items out => The hourly loan is due the same day => The other loan is due on an open day QA note: There is the need to force the "days_mode" option when Koha::Calendar is initiated for the due date calculation. To make sure devs will not forget it, the methods that need have it defined will throw an exception. Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100609|0 |1 is obsolete| | --- Comment #35 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 102556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102556&action=edit Bug 24159: Throw an exception if days_mode option is not given when needed Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100610|0 |1 is obsolete| | --- Comment #36 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 102557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102557&action=edit Bug 24159: Add UI changes Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100611|0 |1 is obsolete| | --- Comment #37 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 102558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102558&action=edit Bug 24159: Adjust tests Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100612|0 |1 is obsolete| | --- Comment #38 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 102559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102559&action=edit Bug 24159: Add new tests for get_useDaysMode_effective_value Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100613|0 |1 is obsolete| | --- Comment #39 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 102560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102560&action=edit Bug 24159: Set days_mode according to circ rules in 3 other places There are 3 other occurrences where the new circ rule can be used: * C4::Circulation::checkHighHolds * Koha::Hold->set_waiting * misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl Test plan: * checkHighHolds Enable decreaseLoanHighHolds and fill decreaseLoanHighHoldsDuration Setup things to hit a "high demand" alert with a shortened due date Check an item out => The due date must be recalculated depending on the circ rule useDaysMode. * set_waiting Set ExcludeHolidaysFromMaxPickUpDelay to "1" (note that there is currently a bug in the description of the syspref, see bug 22381 comment 19) Mark a hold waiting The expiration date should have been set depending on the value of the circ rule. * TalkingTech cronjob Cannot test this Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100614|0 |1 is obsolete| | --- Comment #40 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 102561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102561&action=edit Bug 24159: Use days_mode circ rule to calculate the dropbox date Calculate the drop box date depending on the circ rule. Note that only the branchcode is taken into account here. Is that correct? Test plan: Use the drop box date feature and confirm that it takes into account the calendar, depending on the circ rule. Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100615|0 |1 is obsolete| | --- Comment #41 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 102562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102562&action=edit Bug 24159: Fix one occurrence in updatedatabase.pl Here we just want to get the value from the syspref, the circ rule does not exist yet. Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101649|0 |1 is obsolete| | --- Comment #42 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 102563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102563&action=edit Bug 24159: Fix shift in the header Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks for the test session, Simon! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simon.perry@itcarlow.ie |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This no longer applies - can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24159: Move useDaysMode pref to circulation rules Applying: Bug 24159: Throw an exception if days_mode option is not given when needed Applying: Bug 24159: Add UI changes Applying: Bug 24159: Adjust tests Applying: Bug 24159: Add new tests for get_useDaysMode_effective_value Applying: Bug 24159: Set days_mode according to circ rules in 3 other places error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102560|0 |1 is obsolete| | Attachment #102561|0 |1 is obsolete| | Attachment #102562|0 |1 is obsolete| | Attachment #102563|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104197&action=edit Bug 24159: Set days_mode according to circ rules in 3 other places There are 3 other occurrences where the new circ rule can be used: * C4::Circulation::checkHighHolds * Koha::Hold->set_waiting * misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl Test plan: * checkHighHolds Enable decreaseLoanHighHolds and fill decreaseLoanHighHoldsDuration Setup things to hit a "high demand" alert with a shortened due date Check an item out => The due date must be recalculated depending on the circ rule useDaysMode. * set_waiting Set ExcludeHolidaysFromMaxPickUpDelay to "1" (note that there is currently a bug in the description of the syspref, see bug 22381 comment 19) Mark a hold waiting The expiration date should have been set depending on the value of the circ rule. * TalkingTech cronjob Cannot test this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104198&action=edit Bug 24159: Use days_mode circ rule to calculate the dropbox date Calculate the drop box date depending on the circ rule. Note that only the branchcode is taken into account here. Is that correct? Test plan: Use the drop box date feature and confirm that it takes into account the calendar, depending on the circ rule. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104199&action=edit Bug 24159: Fix one occurrence in updatedatabase.pl Here we just want to get the value from the syspref, the circ rule does not exist yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104200&action=edit Bug 24159: Fix shift in the header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104197|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104201&action=edit Bug 24159: Set days_mode according to circ rules in 3 other places There are 3 other occurrences where the new circ rule can be used: * C4::Circulation::checkHighHolds * Koha::Hold->set_waiting * misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl Test plan: * checkHighHolds Enable decreaseLoanHighHolds and fill decreaseLoanHighHoldsDuration Setup things to hit a "high demand" alert with a shortened due date Check an item out => The due date must be recalculated depending on the circ rule useDaysMode. * set_waiting Set ExcludeHolidaysFromMaxPickUpDelay to "1" (note that there is currently a bug in the description of the syspref, see bug 22381 comment 19) Mark a hold waiting The expiration date should have been set depending on the value of the circ rule. * TalkingTech cronjob Cannot test this Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104198|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104202&action=edit Bug 24159: Use days_mode circ rule to calculate the dropbox date Calculate the drop box date depending on the circ rule. Note that only the branchcode is taken into account here. Is that correct? Test plan: Use the drop box date feature and confirm that it takes into account the calendar, depending on the circ rule. Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104199|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104203&action=edit Bug 24159: Fix one occurrence in updatedatabase.pl Here we just want to get the value from the syspref, the circ rule does not exist yet. Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104200|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104204&action=edit Bug 24159: Fix shift in the header Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Move issuingrules into circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102555|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106007&action=edit Bug 24159: Move useDaysMode pref to circulation rules Moving the useDaysMode system preference to a circulation rule will add much more flexibility in the calculation of the due date. The initial request was to make hourly loan returned on closed when (when checked out on the same close day). To do so we do not want to take into account the calendar. However the calendar need to be taken into account for other loan item types. Other scenarios are possible, for instance depending on the branch. This patchset will add a new "Days mode" column (next to "Loan period") to the circulation rules page, with the different values of the "useDaysMode" system preference + a "default" value, to default to the system preference value. Test plan: - Define a long loan item type (like 10 days) that will use the calendar (or default to the pref value, if the pref is not set to "ignore the calendar") - and a hourly loan (like 2 hours) that will ignore the calendar - Create items with those item types - Mark today as a closed day - Check the items out => The hourly loan is due the same day => The other loan is due on an open day QA note: There is the need to force the "days_mode" option when Koha::Calendar is initiated for the due date calculation. To make sure devs will not forget it, the methods that need have it defined will throw an exception. Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102556|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106008&action=edit Bug 24159: Throw an exception if days_mode option is not given when needed Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106007|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106013&action=edit Bug 24159: Move useDaysMode pref to circulation rules Moving the useDaysMode system preference to a circulation rule will add much more flexibility in the calculation of the due date. The initial request was to make hourly loan returned on closed when (when checked out on the same close day). To do so we do not want to take into account the calendar. However the calendar need to be taken into account for other loan item types. Other scenarios are possible, for instance depending on the branch. This patchset will add a new "Days mode" column (next to "Loan period") to the circulation rules page, with the different values of the "useDaysMode" system preference + a "default" value, to default to the system preference value. Test plan: - Define a long loan item type (like 10 days) that will use the calendar (or default to the pref value, if the pref is not set to "ignore the calendar") - and a hourly loan (like 2 hours) that will ignore the calendar - Create items with those item types - Mark today as a closed day - Check the items out => The hourly loan is due the same day => The other loan is due on an open day QA note: There is the need to force the "days_mode" option when Koha::Calendar is initiated for the due date calculation. To make sure devs will not forget it, the methods that need have it defined will throw an exception. Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106008|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106014&action=edit Bug 24159: Throw an exception if days_mode option is not given when needed Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102557|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106015&action=edit Bug 24159: Add UI changes Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102558|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106016&action=edit Bug 24159: Adjust tests Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102559|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106017&action=edit Bug 24159: Add new tests for get_useDaysMode_effective_value Sponsored-by: Institute of Technology Carlow Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104201|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106018&action=edit Bug 24159: Set days_mode according to circ rules in 3 other places There are 3 other occurrences where the new circ rule can be used: * C4::Circulation::checkHighHolds * Koha::Hold->set_waiting * misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl Test plan: * checkHighHolds Enable decreaseLoanHighHolds and fill decreaseLoanHighHoldsDuration Setup things to hit a "high demand" alert with a shortened due date Check an item out => The due date must be recalculated depending on the circ rule useDaysMode. * set_waiting Set ExcludeHolidaysFromMaxPickUpDelay to "1" (note that there is currently a bug in the description of the syspref, see bug 22381 comment 19) Mark a hold waiting The expiration date should have been set depending on the value of the circ rule. * TalkingTech cronjob Cannot test this Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104202|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106019&action=edit Bug 24159: Use days_mode circ rule to calculate the dropbox date Calculate the drop box date depending on the circ rule. Note that only the branchcode is taken into account here. Is that correct? Test plan: Use the drop box date feature and confirm that it takes into account the calendar, depending on the circ rule. Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104203|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106020&action=edit Bug 24159: Fix one occurrence in updatedatabase.pl Here we just want to get the value from the syspref, the circ rule does not exist yet. Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104204|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106021&action=edit Bug 24159: Fix shift in the header Signed-off-by: Simon Perry <simon.perry@itcarlow.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106022&action=edit Bug 24159: (QA follow-up) Make terminology consistent This patch changes the new circulation rule that's introduced from useDaysMode to daysmode to improve consistency with other rule names. We also update the accessors and code using them to reflect the new term. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This works well and passes the qa script. I have added a trivial followup to update the new rule name and introduced accessor to more closely match the existing rules and methods for consistency. I would love to see some future work, and with any luck I can contribute it, to further 'simplify' the Koha::CirculationRules module to make it more self-consistent but that work doesn't need to happen here. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, would you agree that this is not a bug? It appears to add new configuration options in the circulation rules to allow covering more uses cases - this is valid but I'd see it more as an enhancement. I'd also love to see a more descriptive bug title that tells us more about what this patchset does. I really like the default value mentioned in the patch description that allows fallback to the pref - I was worried a bit about having to set yet another value! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Suggestion for the bug title: "Move useDaysMode preference for calculating due dates to the circulation rules" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #67)
Suggestion for the bug title:
"Move useDaysMode preference for calculating due dates to the circulation rules"
I agree it's an enhancement as it stands... as for the title how about: "Allow daysMode to be set at the circulation rules level" I think that still conveys the right message but also hints that the original system preference is intact? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Summary|Short loan collection |Allow daysMode for |issues on a day marked as |calculating due and renewal |closed (move useDaysMode to |dates to be set at the |circ rules) |circulation rules level --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I sneaked in a few more words :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 [Bug 25896] Missing closing </td> tag in smart-rules.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #71 from Andrew Nugged <nugged@gmail.com> --- Small (below trivial :P) postfix: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #72 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting enhancement to 20.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 [Bug 27026] New circulation rule "Days mode" values are not explained anywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This new enhancement is release notes| |adding the ability to make | |hourly loan returned on a | |closed day, if checked out | |on the same close day. | | | |The | |useDaysMode system | |preference has been moved | |to a circulation rule to | |add more flexibility in the | |calculation of the due | |date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nugged@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31235 [Bug 31235] UseDaysMode is used for calculating the expiration date for waiting holds -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org