[Bug 35599] New: Pronoun and HidePersonalPatronDetailOnCirculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Bug ID: 35599 Summary: Pronoun and HidePersonalPatronDetailOnCirculation Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: pierre.genty@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 10950 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950) adds a pronoun text field to the patron record. The display of this field depends on HidePersonalPatronDetailOnCirculation but the description of this syspref only mentions phone number, email address, street address and city. Pronoun should be added to this description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |10950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 [Bug 10950] Add pronoun field to patron record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- I think pronouns are very useful for circulation. When user has first name and surname it makes sense to have pronouns. So I propose to move pronouns outside HidePersonalPatronDetailOnCirculation block. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Version|22.11 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 163821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163821&action=edit Bug 35599: Fix Pronouns and HidePersonalPatronDetailOnCirculation Bug 10950 adds a pronouns text field to the patron record. Currently it is hidden by system preference 'HidePersonalPatronDetailOnCirculation'. This patch moves pronouns outside this system preference influence. Test plan: 1) Add pronouns to a patron 2) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Don't hide" 3) Check you see pronouns in circulation page /cgi-bin/koha/circ/circulation.pl?borrowernumber=X 4) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Hide" 5) Refresh circulation page => Without patch pronouns are hidden => With patch pronouns are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pronoun and |Pronouns and |HidePersonalPatronDetailOnC |HidePersonalPatronDetailOnC |irculation |irculation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Patrons CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 --- Comment #3 from pierre.genty@biblibre.com --- It works for me : address or phone number are hidden but pronom still displays. Someone else to test and sign off ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163821|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 164006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164006&action=edit Bug 35599: Fix Pronouns and HidePersonalPatronDetailOnCirculation Bug 10950 adds a pronouns text field to the patron record. Currently it is hidden by system preference 'HidePersonalPatronDetailOnCirculation'. This patch moves pronouns outside this system preference influence. Test plan: 1) Add pronouns to a patron 2) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Don't hide" 3) Check you see pronouns in circulation page /cgi-bin/koha/circ/circulation.pl?borrowernumber=X 4) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Hide" 5) Refresh circulation page => Without patch pronouns are hidden => With patch pronouns are displayed Signed-off-by: Hebah <hebah@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #5 from hebah@bywatersolutions.com --- Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Trivial change that looks good to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164006|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 164011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164011&action=edit Bug 35599: Fix Pronouns and HidePersonalPatronDetailOnCirculation Bug 10950 adds a pronouns text field to the patron record. Currently it is hidden by system preference 'HidePersonalPatronDetailOnCirculation'. This patch moves pronouns outside this system preference influence. Test plan: 1) Add pronouns to a patron 2) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Don't hide" 3) Check you see pronouns in circulation page /cgi-bin/koha/circ/circulation.pl?borrowernumber=X 4) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Hide" 5) Refresh circulation page => Without patch pronouns are hidden => With patch pronouns are displayed Signed-off-by: Hebah <hebah@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please add a note to the release notes about this change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Text to go in the| |Bug 10950 adds a pronouns release notes| |text field to the patron | |record. | |It was hidden by | |the system preference | |'HidePersonalPatronDetailOn | |Circulation', not anymore. Status|Pushed to main |Pushed to stable Keywords|release-notes-needed | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35599 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org