http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7067 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9393 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14596|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14597&action=edit Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Because of the new feature to allow patrons to register for a card via the opac when you have OPACPatronDetails set to 'don't allow' it still shows a from for the patron details, but you can't edit the form. It would be better if this showed as a text display like it used to so that it's not confusing to patrons ( even with the note about seeing the librarian ). Test Plan: 1) Apply patch 2) Log into OPAC 3) Set OPACPatronDetails to "Allow" 4) Refresh the page and click "my personal details" 5) Verify you get the editable form ( opac-memberentry.pl ) 6) Set OPACPatronDetails to "Don't allow" 7) Refresh the page and click "my personal details" again 8) Verify you get the non-editable non-form details page ( opac-userupdate.pl ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14597|0 |1 is obsolete| | --- Comment #4 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14966&action=edit Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Because of the new feature to allow patrons to register for a card via the opac when you have OPACPatronDetails set to 'don't allow' it still shows a from for the patron details, but you can't edit the form. It would be better if this showed as a text display like it used to so that it's not confusing to patrons ( even with the note about seeing the librarian ). Test Plan: 1) Apply patch 2) Log into OPAC 3) Set OPACPatronDetails to "Allow" 4) Refresh the page and click "my personal details" 5) Verify you get the editable form ( opac-memberentry.pl ) 6) Set OPACPatronDetails to "Don't allow" 7) Refresh the page and click "my personal details" again 8) Verify you get the non-editable non-form details page ( opac-userupdate.pl ) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Passes tests, works as advertised -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14966|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14971&action=edit Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Because of the new feature to allow patrons to register for a card via the opac when you have OPACPatronDetails set to 'don't allow' it still shows a from for the patron details, but you can't edit the form. It would be better if this showed as a text display like it used to so that it's not confusing to patrons ( even with the note about seeing the librarian ). Test Plan: 1) Apply patch 2) Log into OPAC 3) Set OPACPatronDetails to "Allow" 4) Refresh the page and click "my personal details" 5) Verify you get the editable form ( opac-memberentry.pl ) 6) Set OPACPatronDetails to "Don't allow" 7) Refresh the page and click "my personal details" again 8) Verify you get the non-editable non-form details page ( opac-userupdate.pl ) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Passes tests, works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9384 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #7)

This patch works as far as it goes, but it does not add any check to opac-memberentry.pl to redirect the user if they end up on that page with OPACPatronDetails set to "Don't allow," and it really needs to before I push it.

So I think the followup will delete some tests in the opac-memberentry.tt template ([% IF OPACPatronDetails %]). -- You are receiving this mail because: You are watching all bug changes.