https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71125&action=edit Bug 20123 - Allow multiple instances of Koha to have different timezones on the same server Most of Koha depends on the local timezone of the server, except for Koha::Database which support an ENV override with the key TZ. We should take this a step further. We should not only accept the TZ environment variable for all of Koha, we should really be able to set the timezone in the koha conf file as well so we don't have to pass that environment variable to things like cronjobs and one-off scripts. Test Plan: 1) Apply this patch 2) Set a timzone in your koha_conf file, that is *not* your local time zone Available timzones are listed here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones 3) Restart apache/plack 4) Perform some actions, check the timestamps in the database and in the html output, note they are for the set timezone and not the local timezone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #2)

This adds a new function to C4::Context with no test coverage. Our current RM will Fail QA for this. Write some tests please.

Good point, I'll get those written! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71839|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71840&action=edit Bug 20123: Allow multiple instances of Koha to have different timezones on the same server Most of Koha depends on the local timezone of the server, except for Koha::Database which support an ENV override with the key TZ. We should take this a step further. We should not only accept the TZ environment variable for all of Koha, we should really be able to set the timezone in the koha conf file as well so we don't have to pass that environment variable to things like cronjobs and one-off scripts. Test Plan: 1) Apply this patch 2) Set a timzone in your koha_conf file, that is *not* your local time zone Available timzones are listed here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones 3) Restart apache/plack 4) Perform some actions, check the timestamps in the database and in the html output, note they are for the set timezone and not the local timezone. 5) prove t/timezones.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan@calyx.net.au --- Comment #6 from Dilan Johnpullé <dilan@calyx.net.au> --- I'm having some trouble applying this patch in my devbox. My terminal output is as follows: vagrant@kohadevbox:kohaclone((673a40d...))$ git bz apply -s 20123 Bug 20123 - Allow multiple instances of Koha to have different timezones on the same server 71840 - Bug 20123: Allow multiple instances of Koha to have different timezones on the same server Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20123: Allow multiple instances of Koha to have different timezones on the same server Using index info to reconstruct a base tree... M Koha/Database.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Database.pm CONFLICT (content): Merge conflict in Koha/Database.pm Failed to merge in the changes. Patch failed at 0001 Bug 20123: Allow multiple instances of Koha to have different timezones on the same server The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20123-Allow-multiple-instances-of-Koha-to-have-x5v_At.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71840|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72080&action=edit Bug 20123: Allow multiple instances of Koha to have different timezones on the same server Most of Koha depends on the local timezone of the server, except for Koha::Database which support an ENV override with the key TZ. We should take this a step further. We should not only accept the TZ environment variable for all of Koha, we should really be able to set the timezone in the koha conf file as well so we don't have to pass that environment variable to things like cronjobs and one-off scripts. Test Plan: 1) Apply this patch 2) Set a timzone in your koha_conf file, that is *not* your local time zone Available timzones are listed here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones 3) Restart apache/plack 4) Perform some actions, check the timestamps in the database and in the html output, note they are for the set timezone and not the local timezone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72080|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72081&action=edit Bug 20123: Allow multiple instances of Koha to have different timezones on the same server Most of Koha depends on the local timezone of the server, except for Koha::Database which support an ENV override with the key TZ. We should take this a step further. We should not only accept the TZ environment variable for all of Koha, we should really be able to set the timezone in the koha conf file as well so we don't have to pass that environment variable to things like cronjobs and one-off scripts. Test Plan: 1) Apply this patch 2) Set a timzone in your koha_conf file, that is *not* your local time zone Available timzones are listed here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones 3) Restart apache/plack 4) Perform some actions, check the timestamps in the database and in the html output, note they are for the set timezone and not the local timezone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18674 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And what about other timezone problems? Like running cronjobs? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #13)

And what about other timezone problems? Like running cronjobs?

By setting the timezone in the config file, since each instance gets a config file, the timezone setting would be based on the koha-conf.xml file where you've added <timezone>foo/bar</timezone> in. This is the change necessary for the cronjobs, because environment variables aren't generally set, except for the web interface with the apache SetEnv. And plack is a pain, as you have manually start it with the TZ= setting. This is why config overrides env overrides default local time. At least in my understanding. The Koha/Database tweak uses the C4/Context tweak which reads the config file. So, I don't think cronjobs will be an issue. The issue, for which I leave it Failed QA, is 'local' is not valid for MySQL. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #15)

Imagine you host 2 libraries on the same server, UTC and UTC+12 You want to send emails at 8am. It will be 8am in the given timezone, so 2 cronjobs. We need our cronjobs to take a repeatable --library option to make it works in the different timezone correctly.

overdue_notices.pl already handles it, not process_message_queue.pl.

We will need to provide a documentation page on the wiki to raise the different problems and explain how we could configure such installation.

I am not sure if it would be necessary to change the cronjobs (might still be nice for other reasons). I think instead of using koha-foreach, you could schedule the cronjobs individually per instance. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #16)

I am not sure if it would be necessary to change the cronjobs (might still be nice for other reasons). I think instead of using koha-foreach, you could schedule the cronjobs individually per instance.

It may be necessary, but that wouldn't be because it prevents multiple instances from having different timezones. It would be because the expected timing of things would be different. As such, perhaps that is beyond the scope of this patch which adds the capability, but not necessarily corrects all the cronjobs to account for it. It's not a fatal error, and perhaps it could be corrected in another bug report? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Am I missing something? Why not just run fines for one instance at another time than for another? (scheduling 2 jobs that is running at a suitable calculated time for each). And yep, fines for example you don't want to run in the middle of the day :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72255&action=edit Bug 20123 [QA Followup]: If tz is 'local', no need to tell database to set the timezone -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #23 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Tomás Cohen Arazi from comment #19)

Having a new multi-timezone-aware cron tool might be out of the scope of this bug, LOL.

I agree. That is out of scope. +1 for the idea, but let's try to keep scopes small and easy to measure and test.

It's an interesting idea, tough. I've been looking at ways of using Minion for the tasks BTW.

Links? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 for asking questions and documentation - we have too many things hidden away already. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72603|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72605&action=edit Bug 20123: Add commented out example to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like the idea of a wiki page with information on how this will work and where the limits might be. Do you need to change MySQL configuration as well or is the koha-conf variable enough? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #29)

I like the idea of a wiki page with information on how this will work and where the limits might be. Do you need to change MySQL configuration as well or is the koha-conf variable enough?

As Tomas wrote, the koha conf is the only place the timezone will need set. Any entry in the Time Zone Database can be used. It would be a pretty short wiki page, but I can put it up if you want it! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #32)

Maybe a note that cronjobs might need to be set up to run at different times for each instance?

Where would you like that note to be? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #34)

I was thinking on the wiki page :)

Sounds good! Here it is: https://wiki.koha-community.org/wiki/Time_Zone_Configuration -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72202|0 |1 is obsolete| | --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73687&action=edit Bug 20123: Allow multiple instances of Koha to have different timezones on the same server Most of Koha depends on the local timezone of the server, except for Koha::Database which support an ENV override with the key TZ. We should take this a step further. We should not only accept the TZ environment variable for all of Koha, we should really be able to set the timezone in the koha conf file as well so we don't have to pass that environment variable to things like cronjobs and one-off scripts. Test Plan: 1) Apply this patch 2) Set a timzone in your koha_conf file, that is *not* your local time zone Available timzones are listed here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones 3) Restart apache/plack 4) Perform some actions, check the timestamps in the database and in the html output, note they are for the set timezone and not the local timezone. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72605|0 |1 is obsolete| | --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73689&action=edit Bug 20123: Add commented out example to koha-conf.xml Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73690&action=edit Bug 20123: Make the timezone entry empty and uncommented by default Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525 [Bug 20525] Add --timezone switch to koha-create -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Me again, I would add to the wiki page the consequences on log timestamps and also that koha-foreach should no longer be used (i.e. lot of cronjobs will have to be adjusted). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #42)

(In reply to Jonathan Druart from comment #41)

...

Me again, I would add to the wiki page the consequences on log timestamps and also that koha-foreach should no longer be used (i.e. lot of cronjobs will have to be adjusted).

I don't think log timestamps will be affected, because the daemonized starman process doesn't know about this change.

I think we should add (yet) another option switch to koha-foreach:

--timezone

:-D

I think log timestamps having the local time works just fine, we can always add a 'converted' time option later. As for koha-foreach, I like your idea! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Koha is awesome, you broke shibboleth tests, congratulations: t/Auth_with_shibboleth.t .. 1/11 # Failed test 'new user added with no debug' # at t/Auth_with_shibboleth.t line 204. # found warning: Invalid timezone in koha-conf.xml (HASH(0x7ec4188)) at /home/vagrant/kohaclone/C4/Context.pm line 986. # didn't expect to find a warning # Looks like you failed 1 test of 18. # Failed test 'checkpw_shib tests' # at t/Auth_with_shibboleth.t line 248. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- follow-up pushed to master, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- New feature, not backported for 17.11.x -- You are receiving this mail because: You are watching all bug changes.