[Bug 12622] New: Exporting report as Open Document Spreadsheet results in Perl error when report has no results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Bug ID: 12622 Summary: Exporting report as Open Document Spreadsheet results in Perl error when report has no results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To test: - Run a custom report that produces results - Export as Open Document Spreadsheet - Verify export worked correctly - Run a custom report that produces no results - Export as Open Document Spreadsheet - Verify you see a perl error: Can't use an undefined value as an ARRAY reference at /usr/share/koha/intranet/cgi-bin/reports/guided_reports.pl line 817. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@biblibre.co | |m Depends on| |11679 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29952&action=edit Bug 12622: Fix export report as ods Bug 11679 introduces an ods export for reports. It looks quite buggy: 1/ You get a Perl error if the report has no results 2/ The ods file contains 1 lines less than the total results. Test plan: After applying this patch, try to export a report which has no results and verify you get an ods file with headers only. Try to export a report which has a least 1 result and verify the generated ods has the right number of lines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Robert Higgins <robert.higgins@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29952|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|jonathan.druart@biblibre.co |robert.higgins@catalyst.net |m |.nz --- Comment #2 from Robert Higgins <robert.higgins@catalyst.net.nz> --- Created attachment 30067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30067&action=edit Signed off patch Other exported report types seem to work with queries that produce no results -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30067|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30074&action=edit [PASSED QA] Bug 12622: Fix export report as ods Bug 11679 introduces an ods export for reports. It looks quite buggy: 1/ You get a Perl error if the report has no results 2/ The ods file contains 1 lines less than the total results. Test plan: After applying this patch, try to export a report which has no results and verify you get an ods file with headers only. Try to export a report which has a least 1 result and verify the generated ods has the right number of lines. Signed-off-by: Robert Higgins <robert.higgins@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the reported problem, passes all tests and QA script. Added the sign-off line for Robert. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|robert.higgins@catalyst.net |jonathan.druart@biblibre.co |.nz |m --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Resetting Assigned to to Jonathan - as he is the patch writer. Thx for testing Robert! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.3. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_4_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12888 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_4_candidate | Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karamqubsi@gmail.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 13010 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 12888 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org