[Bug 39565] New: OPACVirtualCard system preferences should not be in Suggestions section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Bug ID: 39565 Summary: OPACVirtualCard system preferences should not be in Suggestions section Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aude.charillon@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com OPACVirtualCard and OPACVirtualCardBarcode are currently in the OPAC > Suggestions section. This doesn't make sense, as this section groups together preferences related to purchase suggestions. OPACVirtualCard and OPACVirtualCardBarcode should be moved to a more relevant section with the OPAC preferences, likely Features. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 [Bug 26777] Give the user the option to display their patron card barcode from the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 180722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180722&action=edit Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section This patch changes the OPACVirtualCard and OPACVirtualCardBarcode system preferences from the Suggestions subsection of the OPAC preferences to the Features subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > OPAC 3. Search the page (Ctrl + F) for OPACVirtualCard --> The two preferences (OPACVirtualCard and OPACVirtualCardBarcode) should be in the Features section -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180722|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 180729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180729&action=edit Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section This patch changes the OPACVirtualCard and OPACVirtualCardBarcode system preferences from the Suggestions subsection of the OPAC preferences to the Features subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > OPAC 3. Search the page (Ctrl + F) for OPACVirtualCard --> The two preferences (OPACVirtualCard and OPACVirtualCardBarcode) should be in the Features section Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Works as described - signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Bug 39565 depends on bug 26777, which changed state. Bug 26777 Summary: Give the user the option to display their patron card barcode from the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | CC| |david@davidnind.com Status|Signed Off |Failed QA Text to go in the| |This enhancement moves the release notes| |OPACVirtualCard system | |preferences | |(OPACVirtualCard and | |OPACVirtualCardBarcode) | |from the OPAC suggestion | |section to the OAPC | |features section. --- Comment #4 from David Nind <david@davidnind.com> --- I thought I would have a go at QAing this one as I understand the code for this one! The patch no longer applies 8-(... Once the patch applies again, could you amend the commit message to follow the guidelines? https://wiki.koha-community.org/wiki/Commit_messages - Subject line: Bug 39565: .... - Maybe the title for the commit message should be "Move OPACVirtualCard system preferences to the correct section" David git bz apply 39565 Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section 180729 - Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref error: Failed to merge in the changes. Patch failed at 0001 Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180729|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 181550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181550&action=edit Bug 39565 - OPACVirtualCard system preferences should not be in Suggestions section This patch changes the OPACVirtualCard and OPACVirtualCardBarcode system preferences from the Suggestions subsection of the OPAC preferences to the Features subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > OPAC 3. Search the page (Ctrl + F) for OPACVirtualCard --> The two preferences (OPACVirtualCard and OPACVirtualCardBarcode) should be in the Features section Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks for checking David! I rebased and put it back in Signed Off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 181553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181553&action=edit Bug 39565: Move OPACVirtualCard system preferences to features section This patch moves the OPACVirtualCard and OPACVirtualCardBarcode system preferences from the Suggestions subsection of the OPAC preferences to the Features subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > OPAC 3. Search the page (Ctrl + F) for OPACVirtualCard --> The two preferences (OPACVirtualCard and OPACVirtualCardBarcode) should be in the Features section Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement moves the |This enhancement moves the release notes|OPACVirtualCard system |OPACVirtualCard system |preferences |preferences |(OPACVirtualCard and |(OPACVirtualCard and |OPACVirtualCardBarcode) |OPACVirtualCardBarcode) |from the OPAC suggestion |from the OPAC suggestion |section to the OAPC |section to the OPAC |features section. |features section. --- Comment #8 from David Nind <david@davidnind.com> --- Thanks Caroline! Passed QA: - Edited the commit message to change the title to Bug XXXX: ... (from Bug XXXX - ...) - QA script happy - Works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181550|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Eeasy small enhancement, I backport Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39565 Laure <laure.roy@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |Laure Roy contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1217 Resolution|--- |FIXED CC| |laure.roy@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org