[Bug 21297] New: "More lists" screen missing "Select an Existing list" fieldset when all lists are public.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Bug ID: 21297 Summary: "More lists" screen missing "Select an Existing list" fieldset when all lists are public. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When creating lists from the staff search results page, clicking 'More Lists' launches cgi-bin/koha/virtualshelves/addbybiblionumber.pl in a new window. If the existing lists are all public, only the 'Add to a new list' fieldset is visable. If a private list is added, the 'Select an existing list' fieldset comes in to view. --- To re-create: Start with an account that has no private lists defined. 1) Add 10 public lists (This is when the 'More lists' menu item becomes view-able) 2) Select an item 3) Click Add to list 4) Select 'More Lists' menu item 5) Note that 'Select an existing list' is not an available option Add a private list, then repeat steps 2-4, note that 'Select an existing list' now shows on the 'Add to a list' page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |17886 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit c089df3f3b45782516b63d22c34bc265c667dd35 Bug 17886: Don't show option to add to existing list if there are no lists Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 [Bug 17886] Don't show option to add to existing list if there are no lists in staff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78829&action=edit Bug 21297: Display public lists to existing lists when adding a new item If there are no private lists the public lists are not displayed. Test plan: 1) Add 10 public lists (This is when the 'More lists' menu item becomes view-able) 2) Select an item 3) Click Add to list 4) Select 'More Lists' menu item 5) Note that 'Select an existing list' is an available option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note for QA: The logic is correct OPAC side. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The test should say add *more than* 10 lists. The "More lists" option only appeared after I added my 11th list. But otherwise, the patch works :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78829|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 79292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79292&action=edit Bug 21297: Display public lists to existing lists when adding a new item If there are no private lists the public lists are not displayed. Test plan: 1) Add 10 public lists (This is when the 'More lists' menu item becomes view-able) 2) Select an item 3) Click Add to list 4) Select 'More Lists' menu item 5) Note that 'Select an existing list' is an available option Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|"More lists" screen missing |"More lists" screen missing |"Select an Existing list" |"Select an Existing list" |fieldset when all lists are |fieldset when all lists are |public. |public -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Bug 21297 depends on bug 17886, which changed state. Bug 17886 Summary: Don't show option to add to existing list if there are no lists in staff https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arattler@nwacc.edu --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 21566 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org