[Bug 21854] New: Patron category is not showing during batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Bug ID: 21854 Summary: Patron category is not showing during batch modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To recreate: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 82415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82415&action=edit Bug 21854: Use template plugin to display category description Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To test: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82415|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 82417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82417&action=edit Bug 21854: Use template plugin to display category description Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To test: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82417|0 |1 is obsolete| | --- Comment #3 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 82421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82421&action=edit Bug 21854: Use template plugin to display category description Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To test: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Andreas Roussos <arouss1980@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82421|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82548&action=edit Bug 21854: Use template plugin to display category description Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To test: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |jesse@bywatersolutions.com --- Comment #6 from Jesse Maseto <jesse@bywatersolutions.com> --- Backported to 18.05 for 18.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21854 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org