[Bug 9132] New: Paging through OPAC authority search results does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Bug ID: 9132 Summary: Paging through OPAC authority search results does not work Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl Search for a term with more than 20 hits. Click page 2. Note that you go to the second page of search results of any=* Somehow the searchdata template var is not filled correctly, making the links for other pages not working. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Just wondering if this is the case under 3.10.0 also? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13644&action=edit Proposed patch (main) Some vars where not included in pagination links. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13645&action=edit Proposed patch (follow-up 1) Followup : in some TT, the field "and_or" is "and_ora". Odd. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13644|0 |1 is obsolete| | Attachment #13645|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13647&action=edit Bug 9132: Paging through OPAC authority search results does not work Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13648&action=edit Bug 9132: Paging through OPAC authority search results does not work (followup 1) input with and_ora instread of and_or Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can't seem to reproduce the problem on current master. Can I get a more detailed test plan? I tried a search for contains 'Müller' and got 4 pages with results. I paged back and forward using the numbered links and arrows but didn't notice problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #6)
I can't seem to reproduce the problem on current master. Can I get a more detailed test plan?
I tried a search for contains 'Müller' and got 4 pages with results. I paged back and forward using the numbered links and arrows but didn't notice problems.
I still can. Try this in OPAC? Go to Browse for author and subject. Look for: a Note the (larger) number of hits. Click on page 2. Check the number of hits again. In my case it is now even higher. I have all results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, thx for the hints! I was checking the staff interface - will go back and check the OPAC search. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13647|0 |1 is obsolete| | Attachment #13648|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13701&action=edit [SIGNED-OFF] Bug 9132: Paging through OPAC authority search results does not work Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes paging in authority result list in OPAC. All tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13702&action=edit [SIGNED-OFF] Bug 9132: Paging through OPAC authority search results does not work (followup 1) input with and_ora instread of and_or Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry for the status confusion - seems git bz changed the status back to 'Signed Off' when I attached the second patch. Something to investigate later. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9132 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org