[Bug 19594] New: Move admin templates JavaScript to the footer: MARC-related
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Bug ID: 19594 Summary: Move admin templates JavaScript to the footer: MARC-related Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, nick@bywatersolutions.com, testopia@bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the MARC-related administration templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69042&action=edit Bug 19594: Move admin templates JavaScript to the footer: MARC-related This patch modifies the staff client MARC-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality, tabs, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69042|0 |1 is obsolete| | --- Comment #2 from Simon Pouchol <simon.pouchol@biblibre.com> --- Created attachment 69049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69049&action=edit Bug 19594: Move admin templates JavaScript to the footer: MARC-related This patch modifies the staff client MARC-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.pouchol@biblibre.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 [Bug 19600] Move admin templates JavaScript to the footer: Other catalog pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601 [Bug 19601] Move admin templates JavaScript to the footer: Additional parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607 [Bug 19607] Move admin templates JavaScript to the footer: Basic parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 [Bug 19608] Move admin templates JavaScript to the footer: The rest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19608 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608 [Bug 19608] Move admin templates JavaScript to the footer: The rest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19603 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603 [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69049|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69496&action=edit Bug 19594: Move admin templates JavaScript to the footer: MARC-related This patch modifies the staff client MARC-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Comment for RM: After this patch the bold emphasizing of some items in admin menu will be broken until these bugs are pushed: bug 19600 bug 19601 bug 19607 bug 19608 bug 19603 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10306 Status|Passed QA |Patch doesn't apply --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I will need this to be based on top of bug 10306. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69496|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69572&action=edit Bug 19594: Move admin templates JavaScript to the footer: MARC-related This patch modifies the staff client MARC-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19607 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607 [Bug 19607] Move admin templates JavaScript to the footer: Basic parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Bug 19594 depends on bug 10306, which changed state. Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Skipping for 17.11, enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Bug 19594 depends on bug 10306, which changed state. Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Bug 19594 depends on bug 10306, which changed state. Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 [Bug 13952] Import and export of authority types -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org