[Bug 11869] New: Add more informations to the member printing pages.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Bug ID: 11869 Summary: Add more informations to the member printing pages. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 25712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25712&action=edit Add more informations to the account printing pages. This patch adds additional informations to the "Print summary" and the "Print receipt" templates. Additional informations in "Print summary" : * Registration date * Expiration date * Library * Category * Fines and payments Additional informations in "Print receipt" : * Address Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> --- To test : * Create a member profile with a full address and add some fines and payments to it. * Go to the details page for this member and click on "Print"->"Print summary". * The page should include the informations mentioned in my previous post. * Go back to the details page and click on "Print" -> "Print slip" * The page should include the address of the member. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Why did you change the order of things? todaysdate followed the cardnumber link before. Why did you not just insert the address line? Also, C4::Dates::format_date($accountline->{date}); -- Why not just pass the date, and use the KohaDate plug in in the template to make sure it is formatted correctly? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25712|0 |1 is obsolete| | --- Comment #3 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 25726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25726&action=edit New version of the patch.
Why did you change the order of things? todaysdate followed the cardnumber link before. Why did you not just insert the address line? This is an old patch we did on Koha 3.6 and ported to 3.8, 3.12 and master. I guess the order got switched around during one of our merges. Also, C4::Dates::format_date($accountline->{date}); -- Why not just pass the date, and use the KohaDate plug in in the template to make sure it is formatted correctly? Again, since its an old patch, it still used the old method to generate dates.
Here is a new version of the patch, fixing those two problems. Thanks for the advices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- I can't trigger the moremember-receipts.tt template. The print slip triggers members/printslip.pl which uses circ/printslip.tt. This change was affected by bug 7001 as far as I can tell. This means you've modified the wrong template file for the second part of your patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 25726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25726 New version of the patch. Review of attachment 25726: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11869&attachment=25726) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt @@ +24,4 @@
<li>[% IF ( email ) %][% email %][% ELSE %](no primary email on file)[% END %]</li> [% IF ( emailpro ) %]<li>[% emailpro %]</li>[% END %] </ul> +<ul>
I think deleting lines 26 and 27 would be okay. @@ +120,5 @@
+ <td colspan="2">[% totaldue %]</td> + </tr> + </tfoot> +</table> +[% END %]
Pretty! ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt @@ +19,4 @@
[% IF ( branchname ) %][% branchname %]<br />[% END %] Checked out to [% firstname %] [% surname %] <br /> (<a href="/cgi-bin/koha/circ/circulation.pl?findborrower=[% cardnumber %]">[% cardnumber %]</a>)<br /> +Address: [% address %]<br />
As far as I can tell, there is no way to trigger this template any more. Check circ/printslip.tt? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25726|0 |1 is obsolete| | --- Comment #6 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 25940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25940&action=edit New version of the patch. Here is a new version of the patch. The code in moremember-receipt.tt was removed, since the new version of the slip is now configurable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- This looks better, but I was wondering if you could also tweak issueloo.date_due to also pipe through $KohaDates. It displays ugly, and since we're tweaking the summary, we might as well fix that too. After all, [% USE KohaDates %] was added. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia@hotmail.com --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- The 'print summary' part works. The 'print slip' part says it should show an address but doesn't, however an address shows in 'print summary'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- I don't think it should be Failed QA, since slips are now separately configurable (see comment #6). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25940|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26690&action=edit [SIGNED OFF] Bug 11869 - Add more informations to the account printing page This patch adds additional informations to the "Print summary" and the "Print receipt" templates. Additional informations in "Print summary" : * Registration date * Expiration date * Library * Category * Fines and payments TEST PLAN --------- 1) Go to a patron. 2) Make sure they have something checked out. 3) Manually add a fine. 4) Under the 'Print' button click 'Print summary' -- the resulting preview should: a) have the first for things listed above, and b) have a new fines and payments section. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: The due date of the check out is not part of this patch, and so I signed off. Similarly, anything required for slips is configurable elsewhere now and thus comment 1 does not accurately reflect the intent of this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |fcapovilla@live.ca |ity.org | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frédérick, please assign bugs you have patches for to yourself, thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11340 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26690|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27269&action=edit [PASSED QA] Bug 11869 - Add more informations to the account printing page This patch adds additional informations to the "Print summary" and the "Print receipt" templates. Additional information in "Print summary": * Registration date * Expiration date * Library * Category * Fines and payments TEST PLAN --------- 1) Go to a patron. 2) Make sure they have something checked out. 3) Manually add a fine. 4) Under the 'Print' button click 'Print summary' -- the resulting preview should: a) have the first for things listed above, and b) have a new fines and payments section. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: The due date of the check out is not part of this patch, and so I signed off. Similarly, anything required for slips is configurable elsewhere now and thus comment 1 does not accurately reflect the intent of this patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works as described and passes all tests and the QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that causes the fines and payments table to display only lines that have an outstanding balance, and which omits the table entirely if the patron has a zero net balance. The reason for this follow-up is to make it consistent with the logic governing the display of the checkout and hold requests table. If you really need historical fine data to be included in the printout, please open a new bug for discussion. Thanks, Frédérick! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org