https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #185 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 80467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80467 Bug 14385: (QA follow-up) Additional changes and fixes Review of attachment 80467: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14385&attachment=80467) ----------------------------------------------------------------- Thank you very much for a Passed QA. Just had one question about one optimization you made in opac/opac-search.pl as I eyeball'd through the patch. The other things are just comments as I was looking through it. Regarding the leak via counting being off. This counting problem already leaks and is an issue. Fixing the counting problem is a complex problem, which has had recent comments on the mailing list. Given the size and scope of testing for this patch, I did not want to keep coding for perfection. Perfection is the enemy of good, or some variation thereof. :) ::: C4/Search.pm @@ +2215,5 @@

else { $can_place_holds = 1; $available_count++; + $available_items->{$prefix}->{count}++ if $item->{$hbranch}; + foreach (qw(branchname itemcallnumber description)) {

White space fix. ::: opac/opac-ISBDdetail.pl @@ +82,3 @@

my $borcat = q{}; +if ( $patron && C4::Context->preference('OpacHiddenItemsExceptions') ) { + $borcat = $patron->categorycode;

Nice optimization. ::: opac/opac-basket.pl @@ -59,4 @@

my $borcat = q{}; if ( C4::Context->preference('OpacHiddenItemsExceptions') ) { # we need to fetch the borrower info here, so we can pass the category - my $borrower = Koha::Patron->find( { borrowernumber -> $borrowernumber } );

Oops... should have been => good catch. ::: opac/opac-detail.pl @@ +85,4 @@

my @all_items = GetItemsInfo($biblionumber); my @hiddenitems; my $patron = Koha::Patrons->find( $borrowernumber ); +our $borcat= q{};

I would have preferred passing, rather than changing to our. ::: opac/opac-search.pl @@ +125,4 @@

authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), } ); +my $patron = Koha::Patrons->find( $borrowernumber );

Not an exact copy of 658 during the optimization. Will this affect things? -- You are receiving this mail because: You are watching all bug changes.