[Bug 23915] New: Replace OPAC list sort menu with Bootstrap menu button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Bug ID: 23915 Summary: Replace OPAC list sort menu with Bootstrap menu button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 23913 Created attachment 94816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94816&action=edit Screenshot showing the new menu button (in its active state) After consolidating the menus in Bug 23913, the structure of the resort form lends itself to being replaced, via JavaScript with a Bootstrap menu button. This allows for a more compact toolbar. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913 [Bug 23913] Use a single menu to sort lists in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94817&action=edit Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Owen, This is by far better than the old form! I have two comments: 1. When you pull up the new dropdown I think the .dropdown-header classes look a bit off. Can the text be bold and can we include a margin-left so the text isn't right up against the dropdown. 2. On smaller mobile screens #toolbar disappears entirely eliminating the ability to sort from a phone or small screen size. (This is at 600px and below). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Bug 23915 depends on bug 23913, which changed state. Bug 23913 Summary: Use a single menu to sort lists in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Error message when applying patch - I think this means the patch didn't apply: Applying: Bug 23915: Replace OPAC list sort menu with Bootstrap menu button error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23915: Replace OPAC list sort menu with Bootstrap menu button The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23915-Replace-OPAC-list-sort-menu-with-Bootstr-dRZj3P.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94817|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97975&action=edit Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 --- Comment #5 from David Nind <david@davidnind.com> --- Everything looks and works fine except for the sort by copyright date. - Copyright date (newest to oldest): sorts as asc when it should be desc (for example, lists an 1875 item before 2009) - Copyright date (oldest to newest): sorts as desc when it should be asc (for example, lists an 2009 item before 1875) It looks like this was introduced by Bug 23913 - the above behaviour is in master, but not in 19.11.x. Should this be fixed in this bug, or should it be a new bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97975|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98039&action=edit Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #5)
Should this be fixed in this bug, or should it be a new bug?
I have modified the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98039|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 98045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98045&action=edit Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98045|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98092&action=edit Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 [Bug 24996] Unwanted CSS change unhides OPAC results sorting button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds JavaScript release notes| |to the list contents page | |which converts the resort | |form's <select> menu into a | |Bootstrap dropdown menu. | |This allows for a more | |compact and consistent | |display. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org