[Bug 23624] New: Count rows in report without (potentially) consuming all memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Bug ID: 23624 Summary: Count rows in report without (potentially) consuming all memory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: paul@flo.org QA Contact: testopia@bugs.koha-community.org Created attachment 92841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92841&action=edit Count total number of rows 1,000 at a time C4::Reports::Guided::nb_rows (called by get_prepped_report in reports/guided_reports.pl) uses DBI::fetchall_arrayref to retrieve all rows at once; counts them; and then discards the rows and returns the count. This has the potential, if the number of rows is very large, to exhaust all available memory. (Other code in guided_reports.pl has the same potential effect, but because the solution to that is much less straightforward it will be addressed in a separate bug report.) This patch uses the second ($max_rows) parameter to DBI::fetchall_arrayref to retrieve a smaller number (1,000) of rows at a time, looping until all results have been retrieved. This will only use as much memory as the maximum amount used by a single call to DBI::fetchall_arrayref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23626 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 [Bug 23626] Add a system preference to limit the number of rows of data used in a chart when viewing report results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23626 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #1 from Paul Hoffman <paul@flo.org> --- I've changed the priority and severity on this bug report, along with #23626, to P2/major since the problem they solve can make Koha unusable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal Status|NEW |Needs Signoff Priority|P2 |P5 - low CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92841|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92903&action=edit Bug 23624 - Count rows in report without (potentially) consuming all memory C4::Reports::Guided::nb_rows (called by get_prepped_report in reports/guided_reports.pl) uses DBI::fetchall_arrayref to retrieve all rows at once; counts them; and then discards the rows and returns the count. This has the potential, if the number of rows is very large, to exhaust all available memory. (Other code in guided_reports.pl has the same potential effect, but because the solution to that is much less straightforward it will be addressed in a separate bug report.) This patch uses the second ($max_rows) parameter to DBI::fetchall_arrayref to retrieve a smaller number (1,000) of rows at a time, looping until all results have been retrieved. This will only use as much memory as the maximum amount used by a single call to DBI::fetchall_arrayref. Test Plan: 1) Create a report the will generate a huge number of results 2) Run the report, watch your memory usage spike 3) Apply this patch 4) Restart all the things! 5) Run the report again, note your memory usage is much lower Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- QA thoughts: 1000 per fetch feels arbitrary. Should that number be controllable via a config entry or syspref? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #4 from Paul Hoffman <paul@flo.org> --- It could be, but the number seems more like an implementation detail than a preference or config option. And it seems reasonable -- a million rows, which without this patch would probably kill any Koha instance, is still only 1,000 iterations of the loop. Most importantly, though, I wouldn't want a debate over the number to hold up the patch -- we can always change it later. (I certainly wouldn't object to some other number.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |paul@flo.org |ity.org | QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92903|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92968&action=edit Bug 23624: Count rows in report without (potentially) consuming all memory C4::Reports::Guided::nb_rows (called by get_prepped_report in reports/guided_reports.pl) uses DBI::fetchall_arrayref to retrieve all rows at once; counts them; and then discards the rows and returns the count. This has the potential, if the number of rows is very large, to exhaust all available memory. (Other code in guided_reports.pl has the same potential effect, but because the solution to that is much less straightforward it will be addressed in a separate bug report.) This patch uses the second ($max_rows) parameter to DBI::fetchall_arrayref to retrieve a smaller number (1,000) of rows at a time, looping until all results have been retrieved. This will only use as much memory as the maximum amount used by a single call to DBI::fetchall_arrayref. Test Plan: 1) Create a report the will generate a huge number of results 2) Run the report, watch your memory usage spike 3) Apply this patch 4) Restart all the things! 5) Run the report again, note your memory usage is much lower Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92969&action=edit Bug 23624: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92970&action=edit Bug 23624: (QA follow-up) Optimize even more This patch makes counting the results have no memory footprint by leveraging on the DB to count the rows. To test: - Without this path, run: $ kshell k$ prove t/db_dependent/Reports/Guided.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/Reports/Guided.t => SUCCESS: Tests still pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #8 from Paul Hoffman <paul@flo.org> --- Thanks, that's the perfect solution. I had contemplated (and rejected) munging the SQL to get a count but never thought of using a subquery. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored and written by release notes| |HELM/FLO Change sponsored?|--- |Sponsored CC| |joy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92968|0 |1 is obsolete| | --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92974&action=edit Bug 23624: Count rows in report without (potentially) consuming all memory C4::Reports::Guided::nb_rows (called by get_prepped_report in reports/guided_reports.pl) uses DBI::fetchall_arrayref to retrieve all rows at once; counts them; and then discards the rows and returns the count. This has the potential, if the number of rows is very large, to exhaust all available memory. (Other code in guided_reports.pl has the same potential effect, but because the solution to that is much less straightforward it will be addressed in a separate bug report.) This patch uses the second ($max_rows) parameter to DBI::fetchall_arrayref to retrieve a smaller number (1,000) of rows at a time, looping until all results have been retrieved. This will only use as much memory as the maximum amount used by a single call to DBI::fetchall_arrayref. Test Plan: 1) Create a report the will generate a huge number of results 2) Run the report, watch your memory usage spike 3) Apply this patch 4) Restart all the things! 5) Run the report again, note your memory usage is much lower Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92969|0 |1 is obsolete| | --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92975&action=edit Bug 23624: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92970|0 |1 is obsolete| | --- Comment #11 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92976&action=edit Bug 23624: (QA follow-up) Optimize even more This patch makes counting the results have no memory footprint by leveraging on the DB to count the rows. To test: - Without this path, run: $ kshell k$ prove t/db_dependent/Reports/Guided.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/Reports/Guided.t => SUCCESS: Tests still pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- If the report being run has a syntax error in it, Koha now gets an error: Can't use an undefined value as an ARRAY reference at /kohadevbox/koha/C4/Reports/Guided.pm line 432 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 92995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92995&action=edit Bug 23624: (QA follow-up) Don't fetch the count unless the query was successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92995|0 |1 is obsolete| | --- Comment #14 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 93037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93037&action=edit Bug 23624: (QA follow-up) Don't fetch the count unless the query was successful Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #15 from Paul Hoffman <paul@flo.org> --- Do *I* need to sign off on this? I'm woefully ignorant of Koha community dev practices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Paul Hoffman from comment #15)
Do *I* need to sign off on this? I'm woefully ignorant of Koha community dev practices.
One sign-off is enough to move it forward in the process, so yours is not required. However if you *wanted* to test and sign off it would be welcomed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93153&action=edit Bug 23624: Count rows in report without (potentially) consuming all memory C4::Reports::Guided::nb_rows (called by get_prepped_report in reports/guided_reports.pl) uses DBI::fetchall_arrayref to retrieve all rows at once; counts them; and then discards the rows and returns the count. This has the potential, if the number of rows is very large, to exhaust all available memory. (Other code in guided_reports.pl has the same potential effect, but because the solution to that is much less straightforward it will be addressed in a separate bug report.) This patch uses the second ($max_rows) parameter to DBI::fetchall_arrayref to retrieve a smaller number (1,000) of rows at a time, looping until all results have been retrieved. This will only use as much memory as the maximum amount used by a single call to DBI::fetchall_arrayref. Test Plan: 1) Create a report the will generate a huge number of results 2) Run the report, watch your memory usage spike 3) Apply this patch 4) Restart all the things! 5) Run the report again, note your memory usage is much lower Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93154&action=edit Bug 23624: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93155&action=edit Bug 23624: (QA follow-up) Optimize even more This patch makes counting the results have no memory footprint by leveraging on the DB to count the rows. To test: - Without this path, run: $ kshell k$ prove t/db_dependent/Reports/Guided.t => SUCCESS: Tests pass - Apply this patch - Run: k$ prove t/db_dependent/Reports/Guided.t => SUCCESS: Tests still pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93156&action=edit Bug 23624: (QA follow-up) Don't fetch the count unless the query was successful Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93157&action=edit Bug 23624: (QA follow-up) Test error cases Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Paul Hoffman <paul@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23685 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I am no fan of the derived table name xxx Could you use something with nb_rows_xxx ? Or use something with random or file::temp etc ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Paul, and congratulations on your first patch accepted into the Koha codebase. I've also taken the liberty of giving full sponsorship attribution in a followup commit message only patch. Thanks: Sponsored-by: Higher Education Libraries of Massachusetts Sponsored-by: Fenway Libraries Online -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 [Bug 23982] Count/pagination broken for reports with duplicated column names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored and written by | release notes|HELM/FLO | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Moved sponsorship into a git followup commit ensuring it appears in the release notes and on the about page. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org