[Bug 28446] New: Fix encoding of OverDrive content on Your summary, OverDrive Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 Bug ID: 28446 Summary: Fix encoding of OverDrive content on Your summary, OverDrive Account Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: magnus@libriotech.no Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org Created attachment 121377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121377&action=edit Screenshot of bad encoding If you have borrowed a book from OverDrive it will show on "Your summary", on the "OverDrive Account" tab. The display includes the title and description, but this text is encoded wrong, see attached screenshot. It looks like the fix is to use to_json instead of encode_json in the call to output_with_http_headers in opac/svc/overdrive: output_with_http_headers $cgi, undef, to_json($data), 'json', $status_line; I will submit a patch for this once my customer has verified it does not break anything else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 121411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121411&action=edit Bug 28446: Fix encoding of OverDrive content Descriptions and titles from OverDrive have their non-ascii chars displayed wrong. To test: - Enable OverDrive - Do a search and find a book with non-ascii characters in title and/or description. E.g. "Blomsterbönder". - Check the book out - Go to "your summary" and the "OverDrive Account" tab - Observe the broken characters - Apply the patch and restart all the things - Reload the "your summary" page - Look at the "OverDrive Account" tab again, and verify the text is displayed without broken characters - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, not sure how this can be tested easily - those with Overdrive accounts might not have the required material with special characters. Magnus, do you have someone who could test this maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Magnus have you tested this in master? I can't reproduce in master but I'm not sure if it's specific to 20.11.x or if I don't have an exotic-enough OverDrive record. I see: Lyd & Bilde, Skandinavias største hjemmeelektronikkmagasin â nå også i digitalt format på Zinio! Abonner nå â Et tilbud du ikke kan takke nei til! and Le magazine de référence de la photo. Dans PHOTO se côtoient les plus grands photographes internationaux : reportage, mode, pub, sport, nu, portrait... Le magazine PHOTO incarne les tendances esthétiques d'aujourd'hui et vous fait découvrir les talents. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #3)
Magnus have you tested this in master? I can't reproduce in master but I'm not sure if it's specific to 20.11.x or if I don't have an exotic-enough OverDrive record.
I see:
Lyd & Bilde, Skandinavias største hjemmeelektronikkmagasin â nå også i digitalt format på Zinio! Abonner nå â Et tilbud du ikke kan takke nei til!
and
Le magazine de référence de la photo. Dans PHOTO se côtoient les plus grands photographes internationaux : reportage, mode, pub, sport, nu, portrait... Le magazine PHOTO incarne les tendances esthétiques d'aujourd'hui et vous fait découvrir les talents.
Marking as FIXED. Please reopen if the problem still exists. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org