[Bug 4839] New: System pref for MARC field 008 authorities; additional logic for position 14
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 Summary: System pref for MARC field 008 authorities; additional logic for position 14 Change sponsored?: --- Product: Koha Version: rel_3_0 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Estimated Hours: 0.0 Currently, the default for this marc field is hardcoded in the plugin code of marc21_field_008_authorities.pl (two occurrences). I suggest to move this value to a new system preference. If this pref should not exist, the old hardcoded value could still be used. Furthermore, the default for position 14 (heading use: main or added entry) should be dependent on the authority type. For CHRON_TERM, GENRE/FORM and TOPIC_TERM, it should be b (not appropriate) instead of a (appropriate). Finally, a small bug should be resolved on the line: my $f32 = substr($result,32,2); this field is only one character, so should be: my $f32 = substr($result,32,1); I will send a preview of a patch to the developer list. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I submitted a separate patch for 3.0.x and master today. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2010-11-04 10:54:45 UTC --- Created attachment 2729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2729 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|rel_3_0 |HEAD AssignedTo|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2010-11-04 10:56:11 UTC --- See patch. Is still valid for master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2010-11-29 14:35:02 UTC --- Patch updated and revised. See http://lists.koha-community.org/pipermail/koha-patches/2010-November/013119.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2729|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2010-12-20 12:30:52 UTC --- Created attachment 2889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2889 Patch Still valid for 3c19f22f8625105715f9ba5f4fca2b0502bcd9cc. (master Dec 20, 2010) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|System pref for MARC field |Adjust default values for |008 authorities; additional |MARC21 authority |logic for position 14 |Fixed-Length Data Elements -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2889|0 |1 is obsolete| | --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-17 11:56:55 UTC --- Created attachment 3337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3337 Patch for functionality Rebased. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-17 12:28:07 UTC --- Created attachment 3338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3338 Follow-up patch for installation pref -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 --- Comment #8 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-01 09:42:45 UTC --- This bug is mentioned in: Bug 4839: Adjust default values for MARC21 authority Fixed-Length Data Elements http://lists.koha-community.org/pipermail/koha-patches/2011-March/014107.htm... Bug 4839: Follow-up patch for installing pref http://lists.koha-community.org/pipermail/koha-patches/2011-March/014108.htm... --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-04-07 10:28:13 UTC --- Test this patch with: Goto Authorities in staff make new auth record default, check 008: 110407|| aca||aabn | a|a d make new auth record topic term, check 008 incl pos 14- Heading use--main or added entry: should be b 110407|| aca||babn | a|a d Now change MARCAuthorityControlField008 to || az|||aabn || a|| |d if you copy and paste this example value, start with the first |-char make new auth record default, check 008: SHOULD BE DIFFERENT NOW 110407|| az|||aabn || a|| |d make new auth record topic term, check 008 incl pos 14- Heading use--main or added entry: should be b 110407|| az|||babn || a|| |d -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-04-27 10:04:29 UTC --- Patch for functionality still applies to 3.05.00.001. I will rebase the second install patch if the first patch gets a signoff. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3337|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-30 08:05:39 UTC --- Created attachment 4298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4298 Bug 4839: Adjust default values for MARC21 authority Fixed-Length Data Elements Currently, the default for this MARC control field is hardcoded in the plugin code of marc21_field_008_authorities.pl (two occurrences). This patch moves it into a new syspref. If this pref should not exist, the old hardcoded value is used. Authorities preference file is updated too. A warning is generated if the length of the field is not correct. Furthermore, the default for position 14 (heading use: main or added entry) should be dependent on the authority type. For CHRON_TERM, GENRE/FORM and TOPIC_TERM, it should be b (not appropriate) instead of a (appropriate). Rebased on March 17. Follow-up patch added for installation pref. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-30 08:06:32 UTC --- Signed off on the functionality part, follow up patch needs a rebase. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-06-01 12:11:06 UTC --- (In reply to comment #12)
Signed off on the functionality part, follow up patch needs a rebase.
Thanks for signing off. Rebased the install patch. Setting status to Signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3338|0 |1 is obsolete| | --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-06-01 12:12:03 UTC --- Created attachment 4328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4328 Follow-up patch for install -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 10:35:17 UTC --- QA comments * I don't like when we add sysprefs, but I have no counter-proposition, so OK for this one (the "default value" you can set for biblios don't exist for authorities. Otherwise, that would have made the job isn't it ? ) * I don't know marc21 well enough to confirm the behaviour is correct, so I don't mark it as passed QA. Chris signed-off, I see nothing strange in the code, so Ian, I think you can validate, but I let you do -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #16 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-03 20:42:47 UTC --- Clear test plan provided, patch works according to plan. Database update followup patch includes all languages, and properly differs version setting to RM. Marking as Passed QA. Small followup suggestion (this is very minor): changing the systempreference entry "type" to "free" instead of "textarea"... I don't think that we need that much space to fill in this field, or to hide it behind and "edit this" link. Again, minor. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-03 22:20:48 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4839 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-10-03 07:24:25 UTC --- Closing it myself now; runs in production with us for months. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org