[Bug 7855] New: Bug 7263 does not include maxlength field sets into a fresh install
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Priority: P5 - low Change sponsored?: --- Bug ID: 7855 Assignee: gmcharlt@gmail.com Summary: Bug 7263 does not include maxlength field sets into a fresh install QA Contact: koha.sekjal@gmail.com Severity: major Classification: Unclassified OS: All Reporter: juan.sieira@xercode.es Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha Bug 7263 does not include maxlength field sets into a fresh install. NORMARC is not included into updatedatabase.pl too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Juan Romay Sieira <juan.sieira@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |juan.sieira@xercode.es --- Comment #1 from Juan Romay Sieira <juan.sieira@xercode.es> --- Created attachment 8711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8711&action=edit marcflavour and updatedatabase changed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Related changes for the NORMARC frameworks are made on bug 7850. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7263 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: why do you use an UPDATE instead of updating the the INSERT field ? Being inconsistent like that will undoubtfully have some side-effect on the long term, because we will forget that there is an UPDATE in the middle of the INSERT. Switching to failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the problem is, that the new column for field length is not part of the inserts yet. So this means updating all lines in all sample files to have the additional value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #4)
I think the problem is, that the new column for field length is not part of the inserts yet. So this means updating all lines in all sample files to have the additional value.
I agree, but I think I still let this patch "failed QA". The proper way to fix this problem is to: * upload a framework file * update the default value * dump the tables again (with --extended-insert option, or something like that, not sure of the exact mysqldump parameter) * create a patch from this update That will fix the problem of maxlength not being set AND the problem of those dump not being correct (PS: in UNIMARC, I just checked, and they are correct) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Katrin, on the chat, promised to take care of a better version of this patch after 3.8 I agree it would be unfair to block it and release a 3.8 version with ppl needing to tune their MARC setup manually just after installing. So I'll push this patch and set it back to "assigned" for a better fix for 3.10 ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I plan to work on some other things like missing tags in default frameworks - I think I can address this issue together with those problems then. Thanks Paul! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed. Note that I had to remove the lines for: U installer/data/mysql/ru-RU/marcflavour/unimarc/mandatory/unimarc_bibliographic_[DEFAULT].sql U installer/data/mysql/uk-UA/marcflavour/unimarc/mandatory/unimarc_bibliographic_[DEFAULT].sql because those patches are not here anymore Switching back to "ASSIGNED" and waiting for a more proper bugfix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8018 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7855 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- At least the translated frameworks can now be generated from the English templates, no problems have occurred since we pushed the initial fix. I am not sure that this still needs to be fixed in a different way (changing the INSERTS). Maybe just keep it the way it is? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org