[Bug 31728] New: Duplicate claims modal template markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Bug ID: 31728 Summary: Duplicate claims modal template markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 29983 Return claims uses a modal dialog for handling the resolution process. The modal markup is currently duplicated in the templates, once in modal-claims.inc and once in checkouts-table.inc. I think this was a mistake in Bug 29983, which added the modal include without removing the markup in checkouts-table.inc. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 141579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141579&action=edit Bug 31728: Remove duplicate claims modal template markup This patch removes some markup which duplicates markup now in a separate include file. modal-claims.inc contains the same markup for #claims-returned-modal as checkouts.table.inc. To test, apply the patch and make sure a LOST authorized value code is defined in the ClaimReturnedLostValue system preference. - Check an item out to a patron, e.g. item 39999000001334 to patron 23529000179433. - In the table showing the patron's checkouts, click the "Claim returned" button. - A "Claim returned" modal should appear. - Click "Make claim." - Switch to the "Claims" tab. You should see the item listed there. - Check out another item, e.g. 39999000013313, to the patron and test the return claim process again from the patron detail page. - Check out another item, e.g. 39999000018691, to the patron with a due date specified which is in the past. - Go to Circulation -> Overdues. You should see the item in the list of overdues. Test that the "Claim returned" button works correctly on this page too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141579|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 141580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141580&action=edit Bug 31728: Remove duplicate claims modal template markup This patch removes some markup which duplicates markup now in a separate include file. modal-claims.inc contains the same markup for #claims-returned-modal as checkouts.table.inc. To test, apply the patch and make sure a LOST authorized value code is defined in the ClaimReturnedLostValue system preference. - Check an item out to a patron, e.g. item 39999000001334 to patron 23529000179433. - In the table showing the patron's checkouts, click the "Claim returned" button. - A "Claim returned" modal should appear. - Click "Make claim." - Switch to the "Claims" tab. You should see the item listed there. - Check out another item, e.g. 39999000013313, to the patron and test the return claim process again from the patron detail page. - Check out another item, e.g. 39999000018691, to the patron with a due date specified which is in the past. - Go to Circulation -> Overdues. You should see the item in the list of overdues. Test that the "Claim returned" button works correctly on this page too. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to set assignee! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141580|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141926&action=edit Bug 31728: Remove duplicate claims modal template markup This patch removes some markup which duplicates markup now in a separate include file. modal-claims.inc contains the same markup for #claims-returned-modal as checkouts.table.inc. To test, apply the patch and make sure a LOST authorized value code is defined in the ClaimReturnedLostValue system preference. - Check an item out to a patron, e.g. item 39999000001334 to patron 23529000179433. - In the table showing the patron's checkouts, click the "Claim returned" button. - A "Claim returned" modal should appear. - Click "Make claim." - Switch to the "Claims" tab. You should see the item listed there. - Check out another item, e.g. 39999000013313, to the patron and test the return claim process again from the patron detail page. - Check out another item, e.g. 39999000018691, to the patron with a due date specified which is in the past. - Go to Circulation -> Overdues. You should see the item in the list of overdues. Test that the "Claim returned" button works correctly on this page too. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31728 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org