[Bug 33358] New: Do not use editorconfig for vue files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Bug ID: 33358 Summary: Do not use editorconfig for vue files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 12545 Using vscodium I noticed that the settings set in the editor were not used (for instance to not add semi colons at the end of the lines). This is because they get ignored when a .editorconfig exists. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545 [Bug 12545] Add EditorConfig file to the source tree -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de, | |pedro.amorim@ptfs-europe.co | |m, tomascohen@gmail.com Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148929&action=edit Bug 33358: Do not use .editorconfig for vue files Using vscodium I noticed that the settings set in the editor were not used (for instance to not add semi colons at the end of the lines). This is because they get ignored when a .editorconfig exists. I didn't find the syntax "all but vue files", but it would be better than listing the different extensions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Paul, Pedro, can you help with this one please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148929|0 |1 is obsolete| | --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 150654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150654&action=edit Bug 33358: Do not use .editorconfig for vue files I looked at the docs for editorconfig and I think I found the right syntax to achieve what we want. Correct me, if I'm wrong. To test: 1. Try this pattern on every filetype we use. 2. Assert it respects the rules. 3. Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch does not work for me, using vscodium. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I finally found what caused the original problem (vscodium not taking into account its own config). There is a "Prettier: Use Editor Config" that was set. I removed it and now it's working without any changes in Koha. I think that's the best solution for now, as nobody else seems to have problems. Closing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Another solution would be to have our prettier options defined in a .prettierrc. For ts, vue and js files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33358 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I really like the idea of a prettierrc file. Let's do it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org