[Bug 19371] New: Change template table column text from 'Delete?' to ' Cancel?' on the patron circulation page holds tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Bug ID: 19371 Summary: Change template table column text from 'Delete?' to 'Cancel?' on the patron circulation page holds tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com At present on the circ/circulation.tt file there is a table column header with the text: 'Delete?' However after the user has selected the 'Yes' option in the dropdown boxes in this column then there is no button on the page with the text 'Delete' in it instead they have to click a button with the text 'Cancel marked holds' Using both 'Delete' and 'Cancel' on the same page causes confusion and so this minor patch will change the table column text to 'Cancel?' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67391&action=edit Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page Test plan: 1. Place a hold on an item 2. Search for the patron who the hold is associated with 3. View the Hold(s) tab of the Checkouts page and notice there is a column with the text 'Delete?' and a button below the table with the text 'Cancel marked holds' 4. Apply patch 5. Notice that the column text described in step 3 now has the text 'Cancel?' and the button text is the same as it was in step 3 Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67391|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 67425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67425&action=edit Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page Test plan: 1. Place a hold on an item 2. Search for the patron who the hold is associated with 3. View the Hold(s) tab of the Checkouts page and notice there is a column with the text 'Delete?' and a button below the table with the text 'Cancel marked holds' 4. Apply patch 5. Notice that the column text described in step 3 now has the text 'Cancel?' and the button text is the same as it was in step 3 Sponsored-By: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67425|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67755&action=edit Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page Test plan: 1. Place a hold on an item 2. Search for the patron who the hold is associated with 3. View the Hold(s) tab of the Checkouts page and notice there is a column with the text 'Delete?' and a button below the table with the text 'Cancel marked holds' 4. Apply patch 5. Notice that the column text described in step 3 now has the text 'Cancel?' and the button text is the same as it was in step 3 Sponsored-By: Catalyst IT Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org