[Bug 11740] New: Use new DataTables include in quotes upload template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Bug ID: 11740 Summary: Use new DataTables include in quotes upload template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/quotes-upload.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 11720 The quotes upload template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25195&action=edit Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( "source","text" ). Go to Tools -> Quote editor and click the "Import quotes" button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25195|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25400&action=edit [SIGNED OFF] Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( "source","text" ). Go to Tools -> Quote editor and click the "Import quotes" button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25400|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25438&action=edit Bug 11740 - Use new DataTables include in quotes upload template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the quotes upload page. To test you need a CSV file of quotes to upload ( "source","text" ). Go to Tools -> Quote editor and click the "Import quotes" button. Upload the CSV file and confirm that the table which previews the import results loads correctly. Sorting is not enabled, but pagination and searching should work. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> No regression found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11740 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org