[Bug 7751] New: Decrease loan period on items with a high number of holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Priority: P5 - low Change sponsored?: --- Bug ID: 7751 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: Decrease loan period on items with a high number of holds QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: chris@bigballofwax.co.nz Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Controlled by a syspref, this will reduce the amount of time something can be onloan, if it has a lot of holds on it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- I am going to attach 2 patches I removed from the bug 5549 work (hourly loans) I have not tested these, so please test them thoroughly. I have rebased them off master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 8313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8313&action=edit Bug 7751 : Decrease loan period on checkout for items with high holds -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5549 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- The second patch depends on bug 5549, the first one doesn't/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 8314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8314&action=edit Bug 7751 : Make Reduce Duedate aware of New Date formats -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 8315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8315&action=edit Bug 7751 : Fix a couple of comparisons in C4::Circulation Changed a string comparison called on an integer Deal with case where value is not set without runtime warnings This is dependent on bug 5549 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- This bug is missing a detailled test plan: what does the syspref do? How is the reduction calculated? (not trying to test, just checking if this patch is included in the feature freeze i'll declare today. still not sure...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #6)
This bug is missing a detailled test plan: what does the syspref do? How is the reduction calculated?
(not trying to test, just checking if this patch is included in the feature freeze i'll declare today. still not sure...)
Hopefully Colin knows. I just removed it from hourly loans and put it on its own bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com, | |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to comment #7)
(In reply to comment #6)
This bug is missing a detailled test plan: what does the syspref do? How is the reduction calculated?
(not trying to test, just checking if this patch is included in the feature freeze i'll declare today. still not sure...)
Hopefully Colin knows. I just removed it from hourly loans and put it on its own bug.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark.gavillet@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ack, that last comment went through before I'd actually written it. Just wanted to clarify. Mark Gavillet actually wrote most of the code for the above patches and is therefore probably the best to ask about testing. I can say though, it's been working in production on at a couple of our sites for some time now. I'm about to update them to the latest and greatest so will test them against master and signoff once I'm happy it all still works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8313|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 9801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9801&action=edit Rebased Patch - Decrease loan period Patch rebased against master and from the original code by Mark Gavillet. Two further patches to follow. None of which are dependant up bug5549. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 9803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9803&action=edit Updates HIGHHOLDS data-structure. Additional patch to correct data-structure of HIGHHOLDS. Data should be returned as data, not as a flag. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 9804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9804&action=edit Bug 7751 : Selfcheckout should be aware of the Reduced Loan Periods Additional patch to make Selfcheckout "Decreased Loan Period" aware. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mark and Martin, Do all 5 patches have to be applied in that sequence in order to test the patch? If not, could you mark the unneeded patches as obsolete? (Details > Edit details > obsolete flag). This makes it easier to test, especially for people using the sandboxes. I notice the system preferences are not added in a standard way. Could you perhaps provide a follow up or squashed patch? The SQL for adding new system preferences goes into installer/data/mysql/kohastructure.sql and they also have to be added to one of the .pref files in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences. Thx for your work on that feature :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, as an additional hint - there is a new module in Koha/DateUtils.pm that might be worth taking a look at, as this patch deals a lot with dates. There was also a recent mail to the mailing list about the topic: http://lists.koha-community.org/pipermail/koha-devel/2012-May/037381.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to comment #14) Thanks for your comments Katrin, I'm now looking at rolling this into two clearer patches (one that does everything upto the but not including the reliance on Bug 5549, and one for everything thereafter.. I'll also try and work out how DateUtils fits in too).. Cheers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9801|0 |1 is obsolete| | Attachment #9803|0 |1 is obsolete| | Attachment #9804|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 9810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9810&action=edit Bug 7751 : Decrease Loans for Items with Highholds Combined patches that don't rely on hourly loans work and added preferences to circulation.pref. I have not appended the sql to sysprefs.sql under installer/data/mysql as I'm not sure of the process yet (any hints?). Initial testing: Apply only this patch. Three new preferences should appear under Home › Administration › System preferences (Circulation). decreaseLoanHighHolds (Enable/Don't Enable) to enable the function, decreaseLoanHighHoldsDuration (Integer) the number of days to reduce a loan by if enables and finally decreaseLoanHighHoldsValue (Integer) the threshold number of holds an item can have before the the decreased loan period kicks in. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8314|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 9811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9811&action=edit Bug 7751 : Make Reduce Duedate aware of New Date formats -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8315|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 9812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9812&action=edit Bug 7751 : Fix a couple of comparisons in C4::Circulation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just tested the additional two patches that apply the New Date Formats, they seem to apply and work as expected. So.. to summarise testing. Apply all three patches, 'Decrease Loans for...' first followed by 'Make Reduce Duedate...' and finally 'Fix a couple of comparisons...' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I have not appended the sql to sysprefs.sql under installer/data/mysql as I'm >not sure of the process yet (any hints?).
Appending the new system preferences at the end of the file is fine. That's all that needs to be done in there. Be careful that the line before ends with ;. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9810|0 |1 is obsolete| | Attachment #9811|0 |1 is obsolete| | Attachment #9812|0 |1 is obsolete| | Assignee|kyle.m.hall@gmail.com |martin.renvoize@ptfs-europe | |.com --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 9834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9834&action=edit Bug 7751 : Decrease Loans for Items with Highholds OK.. Rolled all into one Patch for easy application and changed sql to conform with koha standards. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9834|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 10040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10040&action=edit Bug 7751 : Decrease Loans for Items with Highholds Re-based again to apply to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10040|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 10199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10199&action=edit Bug 7751 : Decrease Loans for Items with Highholds Rebased yet again for master.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10199|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 10204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10204&action=edit Bug 7751 : Decrease Loans for Items with Highholds -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10204|0 |1 is obsolete| | --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11477&action=edit Bug 7751 : Fix a couple of comparisons in C4::Circulation Changed a string comparison called on an integer Deal with case where value is not set without runtime warnings This is dependent on bug 5549 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10204|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10204|0 |1 is obsolete| | --- Comment #26 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 11672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11672&action=edit Updated Patch Had to update this for an upgraded site. Have merged all the separate patches to one and updated it to be applicable to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11672|0 |1 is obsolete| | --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11676&action=edit Bug 7751: Decrease Loans for Items in Demand for Holds Rebase and merge based on Mark Gavillet's patch to reduce the loan period given to items on renewal when they are in high demand for holds Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #28 from Mason James <mtj@kohaaloha.com> ---
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 77d74bb Bug 7751: Decrease Loans for Items in Demand for Holds C4/Circulation.pm C4/SIP/ILS/Transaction/Checkout.pm installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt * C4/Circulation.pm OK * C4/SIP/ILS/Transaction/Checkout.pm OK * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- I must be dumb but I still not sure to see well how this feature work. Am I right if I say "It reduces the check-out duration of an item by [decreaseLoanHighHolds] days for items that have more than [decreaseLoanHighHoldsValue] holds pending." ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #30 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Yes thats it, except DecreaseLoanHighholdsDuration is the value to reduce the loan by. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #31 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master There was a conflict in C4/Circulation.pm, with bug 6151 (AllowToReturnBranch syspref that added a sub that was at the same place) and 7621 (Age Restriction) I fixed the conflict, tested circulation was working well. I was surprised to see no updatedatabase.pl, when I realised it was not needed : if they are not defined, there is no value, the feature is not enabled. Entering values in preference.pl create them (I've checked) Colin = was it intended or a mistake with a nice effect ? Isn't there a typo in the syspref description: "A loan should be reduced by decreaseLoanHighHoldsDuration when holds have been places (if decreaseLoanHighHolds is enables)" shouldn't it be "have been placed" and "is enabled" ? (as Colin is english native, I feel less authoritative on this as he is ;-) ) (not enought to reject the patch though, so it's pushed ;-) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, can we maybe get a follow-up with the database update and system preferences? I like it better because it's more consistent, the scripts will pick up the new sys prefs for the release notes, people will see them in the update database and the syspref sql file will be a complete reference too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #33 from Chris Cormack <chris@bigballofwax.co.nz> --- I concur. Having them for release notes and in the message for the update means users know it's there. Saving our time is always secondary to saving the users time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #34 from Chris Cormack <chris@bigballofwax.co.nz> --- Jenkins will also keep complaining (as would the unit tests if run locally) that the sysprefs don't match. So can we please get a follow up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #35 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #34)
Jenkins will also keep complaining (as would the unit tests if run locally) that the sysprefs don't match. So can we please get a follow up.
Follow-up pushed Note that I thought jenkins was doing a fresh install (from kohastructure.sql & sysprefs.sql). Those sysprefs are in the sysprefs.sql file, so I was not understanding what was happening. Now I understand ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #36 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 12337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12337&action=edit Supplementary Patch (db update to add sysprefs) Add the missing db update. Also fixed the text which as Paul spotted was written in nonsense rather than English -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #37 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #36)
Created attachment 12337 [details] Supplementary Patch (db update to add sysprefs)
Add the missing db update. Also fixed the text which as Paul spotted was written in nonsense rather than English
Sorry Colin, but I beated you (see comment 35) and already have pushed the updatedatabase one. I haven't fixed the string one. Note that, in your string fix: holds have been placed (if decreaseLoanHighHolds is enables) shouldn't we write "(if decreaseLoanHighHolds is enableD)" ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12337|0 |1 is obsolete| | --- Comment #38 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 12345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12345&action=edit Supplemental tidy-up patch Trivial tidy up of the typos - All credit to Paul's proofreading -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #39 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12528&action=edit [FOLLOW UP] Bug 7751: Decrease loan length with many holds This patch merges the three preferences in to one sentence to make it clear that they are all linked together and to eliminate confusion that can come by having them as individual preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |nengard@gmail.com --- Comment #40 from Nicole C. Engard <nengard@gmail.com> --- Submitting a follow up to clean up the preferences in to one sentence. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #41 from Nicole C. Engard <nengard@gmail.com> --- Follow up needs sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12345|0 |1 is obsolete| | --- Comment #42 from Nicole C. Engard <nengard@gmail.com> --- Comment on attachment 12345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12345 Supplemental tidy-up patch Obsoleted by the merging of the three preferences in to one sentence. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12528|0 |1 is obsolete| | --- Comment #43 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12643&action=edit [SIGNED-OFF] Bug 7751: Decrease loan length with many holds This patch merges the three preferences in to one sentence to make it clear that they are all linked together and to eliminate confusion that can come by having them as individual preferences. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #44 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I believe the patch that has been signed off is fixing a bug in the feature which was already pushed to 3.10. Updating report to match that understanding. If I am mistaken, please set the severity back to "enhancement." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #45 from Nicole C. Engard <nengard@gmail.com> --- You are correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #46 from Paul Poulain <paul.poulain@biblibre.com> --- follow-up is string (syspref) only, passes QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Severity|normal |enhancement --- Comment #47 from Paul Poulain <paul.poulain@biblibre.com> --- follow-up pushed (status changed back to ENH to have it in the release notes) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #48 from Nicole C. Engard <nengard@gmail.com> --- Documentation question: I don't see a detailed test plan here, so I need to know for sure what this does for the manual. So, my questions: Patron A has an item checked out with a due date of Nov 1, someone comes along and places a hold on the item they have checked out and the preference is set to decrease the loan length, does Patron A have a new due date? or do they still have a due date of Nov 1? Patron B comes around and checked out a book today, normally they would get 2 weeks but the item has too many holds on it, does that change their due date at the time they check out by the number of days in the preference? Basically - when does this preference kick in? Does it only apply to new checkouts, or checkouts in progress already? Based on a chat in IRC I think it's the former, so that's how I'm documenting it, but I want to confirm. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11676|0 |1 is obsolete| | Attachment #12643|0 |1 is obsolete| | --- Comment #49 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12786&action=edit Bug 7751: Follow up: fix preference text The preference used to read 'loan period by' but it's actually reducing the checkout period 'to' the number of days entered in the preference. This patch changes 'by' to 'to'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Severity|enhancement |critical --- Comment #50 from Nicole C. Engard <nengard@gmail.com> --- Obsoleted the patches that were pushed. This patch is needed to make the preference clear. Changing from ENH back to BUG to get this fix in to 3.10. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #51 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12787&action=edit warning message that appears This is why I changed the preference description - the warning says that it reduces the loan TO a certain number of days and my tests confirmed that is what's happening. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12786|0 |1 is obsolete| | --- Comment #52 from Marc Véron <veron@veron.ch> --- Created attachment 12802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12802&action=edit [SIGNED-OFF] Bug 7751: Follow up: fix preference text The preference used to read 'loan period by' but it's actually reducing the checkout period 'to' the number of days entered in the preference. This patch changes 'by' to 'to'. Signed-off-by: Marc Veron <veron@veron.ch> Tiny patch, text change only, text apears as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #53 from Marc Véron <veron@veron.ch> --- Created attachment 12803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12803&action=edit Due date is not cleared, affecting NEXT check out! After testing / singning off the patch to fix preference text I noticed an issue that should be addressed in a follow up: After checking out or trying to check out such item, the due date is not cleared. As a conseqence the NEXT item one wants to check out will get a shorter loan period. See screenshot attached. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #54 from Paul Poulain <paul.poulain@biblibre.com> --- 51 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED Severity|critical |normal --- Comment #55 from Paul Poulain <paul.poulain@biblibre.com> --- follow-up for fixing preference test passed QA & pushed in one go. switching back to "ASSIGNED", because the problem described in comment 53 must be adressed. Lowering the severity of the problem: if the user look at what is written on the screen, it's easy to fix the usability problem. But Colin, please, provide a follow-up to fix this annoying problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #56 from Chris Cormack <chris@bigballofwax.co.nz> --- Patch doesn't apply to 3.8.x please format one for 3.8.x if it is needed there -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Severity|normal |enhancement --- Comment #57 from Paul Poulain <paul.poulain@biblibre.com> --- This bug is an ENH for 3.10 (thus, the follow-up don't apply to 3.8 and don't need to/can't be) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org