[Bug 32705] New: Display actual cost in foreign currency and currency from the invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Bug ID: 32705 Summary: Display actual cost in foreign currency and currency from the invoice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 25655 On bug 25655 we are going to store the cost and currency from the invoice. On this bug we will display them on the invoice summary. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |michaela.sieber@kit.edu Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145913&action=edit Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, I've decided to format them but they are not accurate to the currency. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 --- Comment #2 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Jonathan Druart from comment #1)
We could discuss the display of the prices here, I've decided to format them but they are not accurate to the currency. We cannot do better for now as we are not storing the format along with the currency.
We would prefer unitprice and currency code (not symbol) [% order.invoice_unitprice | currency => order.invoice_currency %] Exemplar: 52.33 EUR 876.42 USD 69.38 CAD ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145913|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146307&action=edit Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146307|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 146382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146382&action=edit Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146382|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146477&action=edit Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146477|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146486&action=edit Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am happy with this one and ready to PQA, but moving to BLOCKED until we have resolved the question on the dependent bug 25655. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146659&action=edit Bug 32705: Display the column if 1 order has an invoice price On 25655 we added a new patch to store the invoice unitprice and currency even if it's the active currency. Here we then want to display the column if at least one order has an invoice price in a currency that is not the active one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The last patch needs a signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Michaela Sieber <michaela.sieber@kit.edu> --- I did some tests and everything was ok ! Sign-Off via sandbox was not possible, so I change the status to 'Signed Off' manually This error message occured: No local changes to save git: 's' is not a git command. See 'git --help'. The most similar commands are show sparse-checkout status switch am bz fsck gc mv push rm No stash entries found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Michaela Sieber from comment #10)
I did some tests and everything was ok !
Sign-Off via sandbox was not possible, so I change the status to 'Signed Off' manually
This error message occured: No local changes to save git: 's' is not a git command. See 'git --help'.
Reported on https://gitlab.com/koha-community/koha-sandboxes-docker/-/issues/85 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146486|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146814&action=edit Bug 32705: Display invoice price On bug 25655 we are storing the unit price and currency used for invoicing. Here we are displaying them on the invoice page. Test plan: Reuse the test plan from 25655 and go to the invoice page Notice that a new 'Invoice price' column is displayed if at least one order of the invoice had a price given in a foreign currency We could discuss the display of the prices here, we've decided to not format them. We cannot do better for now as we are not storing the format along with the currency. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146659|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146815&action=edit Bug 32705: Display the column if 1 order has an invoice price On 25655 we added a new patch to store the invoice unitprice and currency even if it's the active currency. Here we then want to display the column if at least one order has an invoice price in a currency that is not the active one. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have added the SO line for Michaela on the last patch in the QA step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x. Setting to Needs documenting. Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Bug 32705 depends on bug 25655, which changed state. Bug 25655 Summary: Additionally store actual cost in foreign currency and currency from the invoice https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The original price of an release notes| |order in a foreign currency | |and the currency will now | |display on the invoice | |summary page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40537 [Bug 40537] Sum total cost in ordered / foreign currency on invoice summary page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org