[Bug 18703] New: Translatability: Resolve some remaining %%] problems for staff client in 6 Files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Bug ID: 18703 Summary: Translatability: Resolve some remaining %%] problems for staff client in 6 Files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr There are some more files that expose parts of tt diretives to translations, mostly due to line breaks inside directives. Files covered with this Bug: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63852&action=edit Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files There are some more files that expose parts of tt diretives to translations, mostly due to line breaks inside directives. Files covered with this Bug: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt To test: - Review code, verify that line breaks are removed - Run QA tools - Bonus test: Create a "language" aa-AA and verify that no fragments containign %%] are picked for the 6 files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63852|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 64031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64031&action=edit [SIGNED-OFF] Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files There are some more files that expose parts of tt diretives to translations, mostly due to line breaks inside directives. Files covered with this Bug: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt To test: - Review code, verify that line breaks are removed - Run QA tools - Bonus test: Create a "language" aa-AA and verify that no fragments containign %%] are picked for the 6 files Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 64032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64032&action=edit [SIGNED-OFF] Bug 18703 - Followup, fix typo "statment" Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64031|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 64411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64411&action=edit Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files There are some more files that expose parts of tt diretives to translations, mostly due to line breaks inside directives. Files covered with this Bug: koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt To test: - Review code, verify that line breaks are removed - Run QA tools - Bonus test: Create a "language" aa-AA and verify that no fragments containign %%] are picked for the 6 files Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 64412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64412&action=edit Bug 18703 - Followup, fix typo "statment" Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Attachment #64032|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.02 Trivial enhancement and useful for translation on stable branches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.10. Changes to members-update.tt did not apply to 16.11.x and were removed from the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org