[Bug 29075] New: OPAC info should not be raw in libraries table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Bug ID: 29075 Summary: OPAC info should not be raw in libraries table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 --- Comment #1 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 126975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126975&action=edit Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone here and in opac-library.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jeremy.breuillard@biblibre. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126975|0 |1 is obsolete| | --- Comment #2 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 126987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126987&action=edit Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126987|0 |1 is obsolete| | --- Comment #3 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 126994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126994&action=edit Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126994|0 |1 is obsolete| | --- Comment #4 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 126996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126996&action=edit Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jeremy.breuillard@biblibre. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126996|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127072&action=edit Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone Signed-off-by: Owen <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I think this patch makes good sense, but it does raise the question: Why don't we have a "view" page for libraries? That would be the logical place to put all the information we store about libraries. It might even be useful to have that page accessible to all staff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127072|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127127&action=edit Bug 29075: 'OPAC info' removed in branches.pl In Administration › Libraries, we see content of OPAC info as escaped HTML. This content may be long and seeing HTML tags is strange. We should not show it in this table. Or maybe create a modal preview of it (not escaped HTML). To test : 1) Home > Administration > Libraries 2) In 'Address' column notice the 'OPAC info' field (if this one is filled) with visible HTML tags 3) Apply patch 4) Repeat 1) and 'OPAC info' field should be gone Signed-off-by: Owen <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #6)
I think this patch makes good sense, but it does raise the question: Why don't we have a "view" page for libraries? That would be the logical place to put all the information we store about libraries. It might even be useful to have that page accessible to all staff.
I am also in favor of this change - OPAC info doesn't really belong in the address column anyway. I am not sure about the view page concect as I think we only have this for suggestions so far but it could be something to look into. Another option might be a preview button like we have for news entries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC info should not be raw |OPAC info should not be |in libraries table |displayed in libraries | |table CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Will be in 21.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.06 |21.11.00,21.05.06,20.11.12 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29075 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org