https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Let's start with the good: authbylogin -- cleaned up. SCOUserJS, SCOUserCSS -- both fixed. AllowSelfCheckReturns -- remnant left behind, but variable is used, so that's okay. Then the weird: display_patron_image -- something isn't quite right. It is only set if there is an image to display, whereas the preference change makes no such distinction. cardnumber is currently only set if there is an image, you could expand the condition. Strangely, cardnumber isn't even used in the template currently. The image logic is using borrower number. Something is wrong. Recommendation: Perhaps a prequel bug is in order to deal with this patron image bug in self-checkout? And lastly the reason I'm Failing QA. $selfchecktimeout -- Remnant left behind, which deals with system preference not being set. Logic in sco-main.tt line 343 does not deal with system preference not being set. Also line 419 in sco-main.tt was unchanged. Recommendation: leave the logic for this as was OR put the logic into the TT file. -- You are receiving this mail because: You are watching all bug changes.