[Bug 18957] New: Book renewed online does not show the time of renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Bug ID: 18957 Summary: Book renewed online does not show the time of renewal Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mishravk79@gmail.com QA Contact: testopia@bugs.koha-community.org Dear All, I have activated the renewal date in messages, but if a member renewed the book from koha staf client it reflect the Time of renewal but not if book is renewed online. Please suggest (Koha 16.11.07). Renewal message through Koha staff client : The following Book/s have been renewed on 19/07/2017 10:37: Renewal Message through OPAC : The following Book/s have been renewed on 19/07/2017 00:00: (Time is missing here) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What notice template are you using for RENEWAL? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 --- Comment #2 from Vinod <mishravk79@gmail.com> --- I am using the following template in my defined library "Dear Patron, The following Book/s have been renewed on <<issues.lastreneweddate>>: ---- <<biblio.title>>" ---- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am seeing "The following items have been renewed on 10/10/2017 00:00"
From both OPAC and staff interface.
You must use the "dateonly" filter if you want to get rid of the time part (00:00): The following items have been renewed on <<issues.lastreneweddate | dateonly
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 --- Comment #4 from Vinod <mishravk79@gmail.com> --- Ok, But what if i need time part also to have some reason/observation on user activities on renewal time? At least staff if renewed from staff slient it shows time but not if renewed from OPAC. Hope this may be a genuine bug to resolve. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Vinod from comment #4)
At least staff if renewed from staff slient it shows time but not if renewed from OPAC.
Are you sure? How? I do not see the time part, even if renewed from the staff side. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 --- Comment #6 from Vinod <mishravk79@gmail.com> --- Yes Jonathan, i can see the time when renewed from staff client, but now i have to check the behavior again and i have upgraded to Koha 16.11.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|16.11 |master --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've done some tests: - Renew from OPAC - Renew from staff: patron account - Renew from staff: renewal tab In all cases the time of the renewal was not recorded. The column issues.datelastrenewed is a datetime datatype, so it gets set to 00:00:00. This is a bit irritating. Maybe we could fix it to record not only the date, but the time as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85527&action=edit Bug 18957: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85528&action=edit Bug 18957: Record the time part of the last renewed date issues.lastreneweddate is a datetime and we could record the time part of the date. Test plan: Renew an issue note that the time part of the last renewed date is set correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com Severity|minor |normal Component|OPAC |Circulation Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85527|0 |1 is obsolete| | Attachment #85528|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85565&action=edit Bug 18957: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85566&action=edit Bug 18957: Record the time part of the last renewed date issues.lastreneweddate is a datetime and we could record the time part of the date. Test plan: Renew an issue note that the time part of the last renewed date is set correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85565|0 |1 is obsolete| | Attachment #85566|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85598&action=edit Bug 18957: Add tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85599&action=edit Bug 18957: Record the time part of the last renewed date issues.lastreneweddate is a datetime and we could record the time part of the date. Test plan: Renew an issue note that the time part of the last renewed date is set correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Book renewed online does |Item renewed online does |not show the time of |not show the time of |renewal |renewal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jesse@bywatersolutions.com Status|Pushed to Stable |RESOLVED --- Comment #16 from Jesse Maseto <jesse@bywatersolutions.com> --- Doesn't apply cleanly to 18.05.x. Please rebase to 18.05.x if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org