[Bug 10935] New: CSV for basket and basketgroup are broken when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Bug ID: 10935 Summary: CSV for basket and basketgroup are broken when translated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21377&action=edit Bug 10935: CSV are broken using other language than english. To reproduce: - cd misc/translator - ./translate update LANG - ./translate install LANG - go to the Koha mainpage and change the language. - go to acqui/basketgroup.pl?booksellerid=XX and try to export a basketgroup. The headers is followed by the first basketgroup information. There is no carriage return. It looks like it is caused by a routine used by the translator script (TmplTokenizer::string_canon). To test this patch: - apply it - cd misc/translator - ./translate -f update LANG - translate headers in your po file - ./translate -f install LANG - go to acqui/basketgroup.pl?booksellerid=XX and try to export a basketgroup. - verify that the csv looks good now. - same thing for basket. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10931 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21377|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21388&action=edit [SIGNED OFF] Bug 10935: CSV are broken using other language than english. To reproduce: - cd misc/translator - ./translate update LANG - ./translate install LANG - go to the Koha mainpage and change the language. - go to acqui/basketgroup.pl?booksellerid=XX and try to export a basketgroup. The headers is followed by the first basketgroup information. There is no carriage return. It looks like it is caused by a routine used by the translator script (TmplTokenizer::string_canon). To test this patch: - apply it - cd misc/translator - ./translate -f update LANG - translate headers in your po file - ./translate -f install LANG - go to acqui/basketgroup.pl?booksellerid=XX and try to export a basketgroup. - verify that the csv looks good now. - same thing for basket. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good idea and seems to work - just fixing a small glitch with the first entry of the list in a follow-up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21389&action=edit Bug 10935: Follow-up - adding a line break to fix first list item Without the line break after the include the first entry of our list of orders was behind the header row in the first row of the spreadsheet. Adding the line break seems to fix that and translated CSV can be exported correctly now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, can you please check my follow-up and sign off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7298 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
Hi Jonathan, can you please check my follow-up and sign off?
Katrin, Yes! I started on the same way but it did not work. An empty line existed between the headers and the first row. In fact, if there is no entry in the po file, it does not work. But if an entry exists, your patch fixes the issue. Thanks for testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21389|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21397&action=edit Bug 10935: Follow-up - adding a line break to fix first list item Without the line break after the include the first entry of our list of orders was behind the header row in the first row of the spreadsheet. Adding the line break seems to fix that and translated CSV can be exported correctly now. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21388|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21400&action=edit Bug 10935: CSV are broken using other language than english. To reproduce: - cd misc/translator - ./translate update LANG - ./translate install LANG - go to the Koha mainpage and change the language. - go to acqui/basketgroup.pl?booksellerid=XX and try to export a basketgroup. The headers is followed by the first basketgroup information. There is no carriage return. It looks like it is caused by a routine used by the translator script (TmplTokenizer::string_canon). To test this patch: - apply it - cd misc/translator - ./translate -f update LANG - translate headers in your po file - ./translate -f install LANG - go to acqui/basketgroup.pl?booksellerid=XX and try to export a basketgroup. - verify that the csv looks good now. - same thing for basket. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good idea and seems to work - just fixing a small glitch with the first entry of the list in a follow-up. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21397|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21401&action=edit Bug 10935: Follow-up - adding a line break to fix first list item Without the line break after the include the first entry of our list of orders was behind the header row in the first row of the spreadsheet. Adding the line break seems to fix that and translated CSV can be exported correctly now. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9189 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this bug has made a new appearance - I am seeing the problem again on master and 3.16 stable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the problem again is a missing line break, but I don't know how to fix it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Turns out, I was looking at the wrong installation. 3.14: All information appears on one single line for the translated version, the English CSV is ok. Master: We have way too many line breaks: 2 blank lines between the header row and the first line and 1 blank line after each order line? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually... after fixing some mess here it works wonderfully on master and I can only reproduce it on 3.14.6. Sorry for causing so much confusion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could someone do me a favor and retest this? Because I think I am going a bit crazy here... first it was 2 different installations I was looking at, now I missed to undo a change to the file I had done to see if that would fix the problem. But I am pretty sure now that it's really broken in 3.14 and on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested in braod daylight... the bug can no longer be found on current master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- I reproduced on 3.14.x... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Version|master |3.14 Resolution|FIXED |--- --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note: The problem still exist on 3.14.x, even with these 2 patches. The 2 files modules/acqui/csv/basket.tt and includes/csv_headers/acqui/basket.tt are the same on 3.14.x and on master. BUT if they are translated, on master a blank line exist between headers and the first data row, on 3.14.x, they are on the same line. I am reopening it for 3.14.x Note that I didn't find the problem, if somebody want to have a look... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Version|3.14 |master Resolution|--- |FIXED --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Good news! It seems to be fixed in 3.14.7. I used git-bisect and the following commit fixes the problem: c0dd6bf598da1214d279977286762611eeff372b is the first bad commit commit c0dd6bf598da1214d279977286762611eeff372b Author: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Date: Mon May 26 05:43:05 2014 -0300 Translation updates for 3.14.07 release :040000 040000 36759bb1e8c5b2904e5925852c2ad616f8672a40 7b0369787a19884a9dc84de400dc0fba44639870 M misc -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org