[Bug 34831] New: Add input types "tel", "email" and "url" to vendor edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 Bug ID: 34831 Summary: Add input types "tel", "email" and "url" to vendor edit form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Replacing the generic input type attribute "text" can improve browsers' handling of the fields, for instance "validation parameters and relevant keyboard in supporting browsers and devices with dynamic keyboards." https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155898&action=edit Bug 34831: Add input types "tel", "email" and "url" to vendor edit form This patch updates the vendor edit form so that phone, email, and url fields have an input type corresponding to the field's content. To test, apply the patch and go to Acquisitions. - Create or edit a vendor. - In the form, check that each field looks correct: - Company details -> - Phone - Fax - Website - Contact details - Phone - Alternative phone - Fax - Email - Interfaces - URI - Account email In a desktop browser the inputs won't display any differently, but if you test the patch in a sandbox you can try it in a mobile device browser to confirm that the onscreen keyboard changes based on the type of input. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155898|0 |1 is obsolete| | --- Comment #2 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 156235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156235&action=edit Bug 34831: Add input types "tel", "email" and "url" to vendor edit form This patch updates the vendor edit form so that phone, email, and url fields have an input type corresponding to the field's content. To test, apply the patch and go to Acquisitions. - Create or edit a vendor. - In the form, check that each field looks correct: - Company details -> - Phone - Fax - Website - Contact details - Phone - Alternative phone - Fax - Email - Interfaces - URI - Account email In a desktop browser the inputs won't display any differently, but if you test the patch in a sandbox you can try it in a mobile device browser to confirm that the onscreen keyboard changes based on the type of input. Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156235|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156409&action=edit Bug 34831: Add input types "tel", "email" and "url" to vendor edit form This patch updates the vendor edit form so that phone, email, and url fields have an input type corresponding to the field's content. To test, apply the patch and go to Acquisitions. - Create or edit a vendor. - In the form, check that each field looks correct: - Company details -> - Phone - Fax - Website - Contact details - Phone - Alternative phone - Fax - Email - Interfaces - URI - Account email In a desktop browser the inputs won't display any differently, but if you test the patch in a sandbox you can try it in a mobile device browser to confirm that the onscreen keyboard changes based on the type of input. Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34831 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org