[Bug 31517] New: C4::Tags should use Koha::Tags objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Bug ID: 31517 Summary: C4::Tags should use Koha::Tags objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: joonas.kylmala@iki.fi Reporter: joonas.kylmala@iki.fi QA Contact: testopia@bugs.koha-community.org C4::Tags module does currently a lot of raw SQL queries. We should use the Koha object methods for these instead (Koha::Tags and so on). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140187&action=edit Bug 31517: Replace raw SQL queries in C4::Tags with Koha object accesses To test: 1) Create a few new tags to any biblio by visiting the biblio's detail page on OPAC 2) The visit http://localhost:8080/cgi-bin/koha/opac-tags.pl and try deleting those tags. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140188&action=edit Bug 31517: Remove unused get_tag function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Please ignore the following failure from the QA script:
forbidden pattern: tab char (line 130)
C4/Tags.pl already uses tabs so it doesn't make sense to change format part of the file with spaces as it will look strange on editors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Tags should use |C4::Tags should use |Koha::Tags objects |Koha::Tags objects instead | |of raw SQL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140187|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 142847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142847&action=edit Bug 31517: Replace raw SQL queries in C4::Tags with Koha object accesses To test: 1) Create a few new tags to any biblio by visiting the biblio's detail page on OPAC 2) The visit http://localhost:8080/cgi-bin/koha/opac-tags.pl and try deleting those tags. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140188|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 142848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142848&action=edit Bug 31517: Remove unused get_tag function Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142847|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143046&action=edit Bug 31517: Replace raw SQL queries in C4::Tags with Koha object accesses To test: 1) Create a few new tags to any biblio by visiting the biblio's detail page on OPAC 2) The visit http://localhost:8080/cgi-bin/koha/opac-tags.pl and try deleting those tags. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142848|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143047&action=edit Bug 31517: Remove unused get_tag function Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143048&action=edit Bug 31517: (QA follow-up) Fix indentation Also removes commented out Data::Dumper. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31517 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org