[Bug 25468] New: Preserve line breaks in hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Bug ID: 25468 Summary: Preserve line breaks in hold notes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104791&action=edit Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104791|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 104792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104792&action=edit Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104792|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 104854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104854&action=edit Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104854|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 104923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104923&action=edit Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- @RM: Touches a template but should not result in translation changes. Just a %s ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org