https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113877&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20885 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113877|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114712&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi --- Comment #5 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Victor Grousset/tuxayo from comment #4)

...

16 - Transfer again and choose 'cancel'

I go back to the "Reserve found" page with the 3 options. I'm trapped there if I only click 'cancel' ^^"

And the hold is not canceled.

Can confirm this happening, transfer is generated but hold isn't cancelled. It seems reserve_id is not send as query parameter when 'Cancel' is clicked. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Adding Joonas to the CC list as he's turned into the expert in this area of late ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Seems to works as expected but I see 4 transfers in the UI (Transferred items) And I'm not sure if the data is correct. (tried to make the table compact, so stuff was abridged) --+--------+--------+----+-------+--------+---+------------+----------- id|dt_rqstd|datesent|from|darrive|dcancel |to |reason |canc_reason --+--------+--------+----+-------+--------+---+------------+----------- ↓↓↓↓↓↓↓↓↓↓ 6) set the hold waiting - click it ↓↓↓↓↓ 1|18:50:39|18:50:39|CPL |8:50:48| |FFL|Manual |NULL ↓↓↓↓↓↓↓↓↓↓ Revert the hold or cancel and place a new one (NOT SURE ABOUT THAT)↓↓↓ 2|18:52:43|18:52:43|CPL | |18:53:19|FFL|Manual |Manual ↓↓↓↓↓↓↓↓↓ 14) Click that↓↓↓↓↓ 3|18:53:19|18:53:19|CPL | |18:53:24|FFL|Manual |CancelRes ↓↓↓↓↓↓↓↓↓ 16) choose 'cancel↓↓↓↓↓ 4|18:53:24| |CPL | |18:53:24|CPL|TransfCancel|Manual 5|18:53:24|18:53:24|CPL | | |FFL|Manual |NULL --+--------+--------+----+-------+--------+---+------------+----------- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 120764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120764&action=edit Bug 27064: (QA follow-up) Do not send tobranchcd twice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #8)

Seems to works as expected but I see 4 transfers in the UI (Transferred items) And I'm not sure if the data is correct.

(tried to make the table compact, so stuff was abridged)

--+--------+--------+----+-------+--------+---+------------+----------- id|dt_rqstd|datesent|from|darrive|dcancel |to |reason |canc_reason --+--------+--------+----+-------+--------+---+------------+----------- ↓↓↓↓↓↓↓↓↓↓ 6) set the hold waiting - click it ↓↓↓↓↓ 1|18:50:39|18:50:39|CPL |8:50:48| |FFL|Manual |NULL ↓↓↓↓↓↓↓↓↓↓ Revert the hold or cancel and place a new one (NOT SURE ABOUT THAT)↓↓↓ 2|18:52:43|18:52:43|CPL | |18:53:19|FFL|Manual |Manual ↓↓↓↓↓↓↓↓↓ 14) Click that↓↓↓↓↓ 3|18:53:19|18:53:19|CPL | |18:53:24|FFL|Manual |CancelRes ↓↓↓↓↓↓↓↓↓ 16) choose 'cancel↓↓↓↓↓ 4|18:53:24| |CPL | |18:53:24|CPL|TransfCancel|Manual 5|18:53:24|18:53:24|CPL | | |FFL|Manual |NULL --+--------+--------+----+-------+--------+---+------------+-----------

To highlight the issue I'm referring to using Victors test data above.. It's the final transfer that's an error, not with this bug, but with another that's already in master. It's is a 'return to sending branch' that's triggered by the cancellation.. this happens automatically when the item is perceived to be 'in_transit'.. problem is.. ModItemTransfer always puts items immediately in transit.. but there are times when that isn't the right action and the item hasn't actually left the building as such yet.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120759|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121065&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121067&action=edit Bug 27064: (QA follow-up) Do not create transfer prior to accepting it This patch prevents the cancellations we were seeing. Transfers were being created pre-emtively for reserves in branchtransfers before the librarian had selected their prefered action. As such, we were getting double lines in the branchtransfers table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6473 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 [Bug 6473] Test bug for Git-bz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

15 - Hold is in transit and transfer is generated correctly

Ok I have "Item is now in transit to Fairfield" Shouldn't this create a record in branchtransfers ? Shouldn't this be shown in the biblio record details? In addition to "There is an item level hold on this item (priority = 0)." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28294 |12362 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 [Bug 12362] Branch transfer records orphaned on cancelled holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22160 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121066|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121091&action=edit Bug 27064: (QA follow-up) Do not send tobranchcd twice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121093&action=edit Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel The `replace` option found in Koha::Item->request_transfer should be passed through to Koha::Item::Transfer->cancel and prevent any reverse transfers from being queued in such cases. This prevents modItemTransfer from adding superflous reverse transfers whenever it is used. Test plan 1/ Run t/db_dependent/Koha/Item.t to prove the new tests pass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

15 - Hold is in transit and transfer is generated correctly

I'm still not getting a record added to the branchtransfers table >_< And the hold tab says that it's in transfer, where is that even stored... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

And the hold tab says that it's in transfer, where is that even stored...

A diff on database dump before and after the transfer shows that the info is from the reserves table. found = T => Hold is in transit and the reserves table stores the pickup library so here we have the data behind the message. And nothing added in the branchtransfers table. Puzzling. Should we switch to need signoff to have more chances of someone else trying this out? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121091|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121142&action=edit Bug 27064: (QA follow-up) Do not send tobranchcd twice -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121093|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121144&action=edit Bug 27064: (QA follow-up) Pass 'replace' through to Koha::Item::Transfer->cancel The `replace` option found in Koha::Item->request_transfer should be passed through to Koha::Item::Transfer->cancel and prevent any reverse transfers from being queued in such cases. This prevents modItemTransfer from adding superflous reverse transfers whenever it is used. Test plan 1/ Run t/db_dependent/Koha/Item.t to prove the new tests pass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28382 [Bug 28382] 'Reserve' should be passed through as transfer reason appropriately in branchtransfers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

15 - Hold is in transit and transfer is generated correctly

record detail page:

In transit from Centerville to Fairfield since 05/19/2021 There is an item level hold on this item (priority = 0).

nice :D and branchtransfers have a new line! yay! ---

16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated

|8|657|39:09|NULL |CPL|NUL|39:09|CPL|NUL|TransferCancellation|Manual |9|657|39:09|39:09|CPL|NUL|NUL |FFL|NUL|Manual |NULL Is that what it should be? ---

15 - Hold is in transit and transfer is generated correctly

There is a second box https://wtf.roflcopter.fr/pics/2gNHxIgK/9YCZaWRZ.png It's new, after checking it's not there with the previous patches, from comment 20 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121141|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121670&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121143|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121672&action=edit Bug 27064: (QA follow-up) Do not create transfer prior to accepting it This patch prevents the cancellations we were seeing. Transfers were being created pre-emtively for reserves in branchtransfers before the librarian had selected their prefered action. As such, we were getting double lines in the branchtransfers table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121674&action=edit Bug 27064: (QA follow-up) Remove superflous error message The reserve found error message should not be included in the errmsgloop as it's handled as a question in the previous step. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121670|0 |1 is obsolete| | Attachment #121671|0 |1 is obsolete| | Attachment #121672|0 |1 is obsolete| | Attachment #121673|0 |1 is obsolete| | Attachment #121675|0 |1 is obsolete| | --- Comment #39 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 121676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121676&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #41 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 121678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121678&action=edit Bug 27064: (QA follow-up) Do not create transfer prior to accepting it This patch prevents the cancellations we were seeing. Transfers were being created pre-emtively for reserves in branchtransfers before the librarian had selected their prefered action. As such, we were getting double lines in the branchtransfers table. Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #43 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 121680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121680&action=edit Bug 27064: (QA follow-up) Add error message only if we have one defined This moves the DestinationEqualsHolding error message addition to if clause so the value is added to %err hash only when there is actually an error. Then we only append to the @errmsgloop array the error message if one was defined. To test: 1) Create a hold request to a pickup library where the item currently is not 2) Add transfer to the pickup library using branchtransfers.pl and notice without this patch we get and empty message box but with this patch we don't get it. Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121676|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121681&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121678|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121683&action=edit Bug 27064: (QA follow-up) Do not create transfer prior to accepting it This patch prevents the cancellations we were seeing. Transfers were being created pre-emtively for reserves in branchtransfers before the librarian had selected their prefered action. As such, we were getting double lines in the branchtransfers table. Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121680|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121685&action=edit Bug 27064: (QA follow-up) Add error message only if we have one defined This moves the DestinationEqualsHolding error message addition to if clause so the value is added to %err hash only when there is actually an error. Then we only append to the @errmsgloop array the error message if one was defined. To test: 1) Create a hold request to a pickup library where the item currently is not 2) Add transfer to the pickup library using branchtransfers.pl and notice without this patch we get and empty message box but with this patch we don't get it. Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #51 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Failing tests, please fix ASAP kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Circulation/transferbook.t [4/69] t/db_dependent/Circulation/transferbook.t .. 2/6 # Failed test 'Transfer of reserved item succeeded without ignore reserves' # at t/db_dependent/Circulation/transferbook.t line 151. # got: '0' # expected: '1' # Looks like you failed 1 test of 5. # Failed test 'transfer already at destination' # at t/db_dependent/Circulation/transferbook.t line 154. # Failed test 'Transfer of reserved item succeeded without ignore reserves' # at t/db_dependent/Circulation/transferbook.t line 208. # got: '0' # expected: '1' # Looks like you failed 1 test of 5. t/db_dependent/Circulation/transferbook.t .. 4/6 # Failed test 'transfer an issued item' # at t/db_dependent/Circulation/transferbook.t line 212. # Failed test 'Transfer of reserved item succeeded without ignore reserves' # at t/db_dependent/Circulation/transferbook.t line 248. # got: '0' # expected: '1' # Failed test 'Transfer of reserved item succeeded with ignore reserves: false' # at t/db_dependent/Circulation/transferbook.t line 260. # got: '0' # expected: '1' # Failed test 'We got the expected failure message: DestinationEqualsHolding' # at t/db_dependent/Circulation/transferbook.t line 273. # Structures begin differing at: # $got->{ResFound} = HASH(0x558e901b2fa0) # $expected->{ResFound} = Does not exist # Failed test 'We did not return that we found a reserve' # at t/db_dependent/Circulation/transferbook.t line 278. # got: 'Reserved' # expected: anything else # Failed test 'We did not return the reserve info' # at t/db_dependent/Circulation/transferbook.t line 279. # got: '989' # expected: anything else # Looks like you failed 5 tests of 10. # Failed test 'ignore_reserves flag' # at t/db_dependent/Circulation/transferbook.t line 280. t/db_dependent/Circulation/transferbook.t .. 6/6 # Looks like you failed 3 tests of 6. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #53 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Jonathan Druart from comment #51)

Failing tests, please fix ASAP

Attached a patch to correct the test scenarios. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32765 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32765 [Bug 32765] Transfer is not retried after cancelling hold -- You are receiving this mail because: You are watching all bug changes.