https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #71 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Marcel de Rooy from comment #58)

I am requesting another signoff here. The third patch has no signoff line yet. And additionally please tell me explicitly what you tested!

I have been looking more carefully at CourseReserves.pm and I am not really impressed by what I saw unfortunately. I have the impression that this patch set might improve things a bit, but I am not sure if we break something else now.

Saw tricky things like: push( @values, $params{$_} || undef ); Together with constructions like: foreach (@FIELDS) { if ( defined($params{$_}) ) { push( @fields_to_update, $_ ); push( @values_to_update, $params{$_} ); } } ModCourseItem adds an course item without affecting items or updates it and does affect items. EnableOrDisable etc. etc. The way we handle the data between items and course items is unclear. Including handling empty string and null values.

I am not unwilling to pass QA after another signoff but the traffic lights will not be green :)

Can you explain with more detail. I'm not sure everyone understands the concern. If we have a little bit more understanding of what this piece of code is doing, more of us can weigh in. -- You are receiving this mail because: You are watching all bug changes.