[Bug 27266] New: Move C4::Biblio::GetMarcAuthors to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Bug ID: 27266 Summary: Move C4::Biblio::GetMarcAuthors to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Blocks| |3150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 114503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114503&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_marc_authors. This is so get_marc_authors can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114503|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 114580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114580&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114580|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 117239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117239&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Notes from testing with koha-testing-docker: - I couldn't send email (it comes up with an error message when you click on the send buttons - problem sending email). I didn't have this issue when testing bug 3150, so I applied that and everything worked as expected with the test plan. - To review the email I copied the HTML from the database (koha-mysql kohadev, select * from message_queue;) and saved it as an HTML file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry, this no longer applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117239|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118311&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118311|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118312&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests pass, QA scripts pass and the code looks reasonable. I'm not entirely sure about the method name.. we now have: Koha::Biblio->get_marc_notes; and Koha::Biblio->get_authors_from_MARC; For consistency, I think I'd prefer this patch to introduce Koha::Biblio->get_marc_authors; But... I think we can leave that decision to the RM.. so Passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #9)
Tests pass, QA scripts pass and the code looks reasonable.
I'm not entirely sure about the method name.. we now have:
Koha::Biblio->get_marc_notes;
and
Koha::Biblio->get_authors_from_MARC;
For consistency, I think I'd prefer this patch to introduce
Koha::Biblio->get_marc_authors;
But... I think we can leave that decision to the RM.. so Passing QA :)
I would also prefer get_marc_authors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118312|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123017&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123018&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123019&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123017|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123026&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123018|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123027&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123019|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123028&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 123026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123026 Bug 27266: Move GetMarcAuthors to Koha namespace Review of attachment 123026: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27266&attachment=123026) ----------------------------------------------------------------- ::: Koha/Biblio.pm @@ +870,5 @@
+ # tagslib useful only for UNIMARC author responsibilities + my $tagslib; + if ( $marcflavour eq "UNIMARC" ) { + # FIXME : we don't have the framework available, we take the default framework. May be buggy on some setups, will be usually correct. + $tagslib = C4::Biblio::GetMarcStructure( 1, '', { unsafe => 1 });
I wonder if we aught to fix the FIXME here? $tagslib = C4::Biblio::GetMarcStructure( 1, $self->frameworkcode, { unsafe => 1 }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Martin Renvoize from comment #17)
Comment on attachment 123026 [details] [review] Bug 27266: Move GetMarcAuthors to Koha namespace
Review of attachment 123026 [details] [review]: -----------------------------------------------------------------
::: Koha/Biblio.pm @@ +870,5 @@
+ # tagslib useful only for UNIMARC author responsibilities + my $tagslib; + if ( $marcflavour eq "UNIMARC" ) { + # FIXME : we don't have the framework available, we take the default framework. May be buggy on some setups, will be usually correct. + $tagslib = C4::Biblio::GetMarcStructure( 1, '', { unsafe => 1 });
I wonder if we aught to fix the FIXME here?
$tagslib = C4::Biblio::GetMarcStructure( 1, $self->frameworkcode, { unsafe => 1 });
True, may as well. Follow-up on it's way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #19 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123067&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123026|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125440&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123027|0 |1 is obsolete| | --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125441&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123028|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125442&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123067|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125443&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125444&action=edit Bug 27266: (follow-up) Show MARC author notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125440|0 |1 is obsolete| | Attachment #125444|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125465&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. xslt) 6. Log in to the OPAC. Find the record and add it to the cart and a list 7. View the cart and click 'more details'. Confirm authors show as normal. 8. Click 'send' and confirm the email sent shows the authors as normal. 9. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 10. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125441|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125466&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125442|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125467&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125443|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125468&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #29 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 125469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125469&action=edit Bug 27266: (follow-up) Remove get_marc_authors from opac-detail There's no way to use 'no' XSLT now, so don't need to use this to show authors on the detail page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125465|0 |1 is obsolete| | --- Comment #30 from David Nind <david@davidnind.com> --- Created attachment 125719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125719&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. xslt) 6. Log in to the OPAC. Find the record and add it to the cart and a list 7. View the cart and click 'more details'. Confirm authors show as normal. 8. Click 'send' and confirm the email sent shows the authors as normal. 9. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 10. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125466|0 |1 is obsolete| | --- Comment #31 from David Nind <david@davidnind.com> --- Created attachment 125720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125720&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125467|0 |1 is obsolete| | --- Comment #32 from David Nind <david@davidnind.com> --- Created attachment 125721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125721&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125468|0 |1 is obsolete| | --- Comment #33 from David Nind <david@davidnind.com> --- Created attachment 125722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125722&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125469|0 |1 is obsolete| | --- Comment #34 from David Nind <david@davidnind.com> --- Created attachment 125723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125723&action=edit Bug 27266: (follow-up) Remove get_marc_authors from opac-detail There's no way to use 'no' XSLT now, so don't need to use this to show authors on the detail page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125719|0 |1 is obsolete| | --- Comment #35 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126539&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. xslt) 6. Log in to the OPAC. Find the record and add it to the cart and a list 7. View the cart and click 'more details'. Confirm authors show as normal. 8. Click 'send' and confirm the email sent shows the authors as normal. 9. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 10. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125720|0 |1 is obsolete| | --- Comment #36 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126540&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125721|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126541&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125722|0 |1 is obsolete| | --- Comment #38 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126542&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125723|0 |1 is obsolete| | --- Comment #39 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126543&action=edit Bug 27266: (follow-up) Remove get_marc_authors from opac-detail There's no way to use 'no' XSLT now, so don't need to use this to show authors on the detail page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29421 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29421 [Bug 29421] Remove C4::Biblio::GetBiblioData -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126539|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127330&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. xslt) 6. Log in to the OPAC. Find the record and add it to the cart and a list 7. View the cart and click 'more details'. Confirm authors show as normal. 8. Click 'send' and confirm the email sent shows the authors as normal. 9. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 10. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126540|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127331&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126541|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127332&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126542|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127333&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126543|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127334&action=edit Bug 27266: (follow-up) Remove get_marc_authors from opac-detail There's no way to use 'no' XSLT now, so don't need to use this to show authors on the detail page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127335&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts We are adding (or already doing) a Koha::Biblios->find, so we should get rid of GetBiblioData, fetching the same data. It returned a few extra columns, but unused here: $dat->{bnotes}, $dat->{bi_notforloan} Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127336&action=edit Bug 27266: (QA follow-up) Indentation in opac-sendshelf Minimal fix to improve bad indentation a bit, moving to 2 spaces. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127337&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too Applies to opac and intranet script. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127335|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127340&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts We are adding (or already doing) a Koha::Biblios->find, so we should get rid of GetBiblioData, fetching the same data. It returned a few extra columns, but unused here: $dat->{bnotes}, $dat->{bi_notforloan} Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127336|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127341&action=edit Bug 27266: (QA follow-up) Indentation in opac-sendshelf Minimal fix to improve bad indentation a bit, moving to 2 spaces. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127337|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127342&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too Applies to opac and intranet script. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancment moves release notes| |C4::Biblio::GetMarcAuthors | |to | |Koha::Biblio->get_authors_f | |rom_MARC. This is so the | |method can be used in | |templates and notices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I get Applying: Bug 27266: (follow-up) Remove get_marc_authors from opac-detail error: sha1 information is lacking or useless (opac/opac-detail.pl). error: could not build fake ancestor Patch failed at 0001 Bug 27266: (follow-up) Remove get_marc_authors from opac-detail Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29441 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #53 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 27266: Move GetMarcAuthors to Koha namespace Using index info to reconstruct a base tree... M C4/Biblio.pm M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging C4/Biblio.pm Applying: Bug 27266: (QA follow-up) Rename to get_marc_authors Applying: Bug 27266: (follow-up) Remove instances of GetMarcAuthors Applying: Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Applying: Bug 27266: (follow-up) Remove get_marc_authors from opac-detail Using index info to reconstruct a base tree... M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Applying: Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts Applying: Bug 27266: (QA follow-up) Indentation in opac-sendshelf Applying: Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Wait. I am on the wrong branch ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Makes no difference: Applying: Bug 27266: Move GetMarcAuthors to Koha namespace Using index info to reconstruct a base tree... M C4/Biblio.pm M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging C4/Biblio.pm Applying: Bug 27266: (QA follow-up) Rename to get_marc_authors Applying: Bug 27266: (follow-up) Remove instances of GetMarcAuthors Applying: Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Applying: Bug 27266: (follow-up) Remove get_marc_authors from opac-detail Using index info to reconstruct a base tree... M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Applying: Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts Applying: Bug 27266: (QA follow-up) Indentation in opac-sendshelf Applying: Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127330|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127561&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. xslt) 6. Log in to the OPAC. Find the record and add it to the cart and a list 7. View the cart and click 'more details'. Confirm authors show as normal. 8. Click 'send' and confirm the email sent shows the authors as normal. 9. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 10. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127331|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127562&action=edit Bug 27266: (QA follow-up) Rename to get_marc_authors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127332|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127563&action=edit Bug 27266: (follow-up) Remove instances of GetMarcAuthors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127333|0 |1 is obsolete| | --- Comment #59 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127564&action=edit Bug 27266: (follow-up) Using biblio frameworkcode to get rid of FIXME Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127334|0 |1 is obsolete| | --- Comment #60 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127565&action=edit Bug 27266: (follow-up) Remove get_marc_authors from opac-detail There's no way to use 'no' XSLT now, so don't need to use this to show authors on the detail page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127340|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127566&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts We are adding (or already doing) a Koha::Biblios->find, so we should get rid of GetBiblioData, fetching the same data. It returned a few extra columns, but unused here: $dat->{bnotes}, $dat->{bi_notforloan} Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127341|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127567&action=edit Bug 27266: (QA follow-up) Indentation in opac-sendshelf Minimal fix to improve bad indentation a bit, moving to 2 spaces. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127342|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127568&action=edit Bug 27266: (QA follow-up) Remove GetBiblioData from sendshelf too Applies to opac and intranet script. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancment moves |This enhancment moves release notes|C4::Biblio::GetMarcAuthors |C4::Biblio::GetMarcAuthors |to |to |Koha::Biblio->get_authors_f |Koha::Biblio->get_marc_auth |rom_MARC. This is so the |ors. This is so the method |method can be used in |can be used in templates |templates and notices. |and notices. CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29690 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #64 from Fridolin Somers <fridolin.somers@biblibre.com> --- Please have a look at Bug 29690. We need to catch invalid metadata record so get_marc_authors() is concerned. I'd like QA to confirm this is the correct way to implement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #65 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #64)
Please have a look at Bug 29690. We need to catch invalid metadata record so get_marc_authors() is concerned. I'd like QA to confirm this is the correct way to implement.
Since this one is already passed-QA I push it and will amend Bug 29690 for get_marc_authors(). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 [Bug 29690] Software error in details.pl when invalid MARCXML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #66 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org