[Bug 41698] New: Add maintenance script to revert found holds for items currently checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Bug ID: 41698 Summary: Add maintenance script to revert found holds for items currently checked out Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz For reasons unknown, it is possible to get into a situation where an item is both checked out to one patron and associated with a found hold for another patron. We should add a script to Koha to fix items in this situation by reverting the found holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 191978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191978&action=edit Bug 41698 - Add maintenance script to revert found holds for items currently checked out For reasons unknown, it is possible to get into a situation where an item is both checked out to one patron and associated with a found hold for another patron. We should add a script to Koha to fix items in this situation by reverting the found holds. Test Plan: 1) Check an item out to a patron 2) Place an item specific hold for another patron 3) Manually set the priority to 0 and found to "W" for that hold 4) Run misc/maintenance/fix_holds_waiting_and_issued.pl 5) Note the hold has been reverted! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191978|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 191979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191979&action=edit Bug 41698 - Add maintenance script to revert found holds for items currently checked out For reasons unknown, it is possible to get into a situation where an item is both checked out to one patron and associated with a found hold for another patron. We should add a script to Koha to fix items in this situation by reverting the found holds. Test Plan: 1) Check an item out to a patron 2) Place an item specific hold for another patron 3) Manually set the priority to 0 and found to "W" for that hold 4) Run misc/maintenance/fix_holds_waiting_and_issued.pl 5) Note the hold has been reverted! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 191980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191980&action=edit Bug 41698: Add maintenance script to revert found holds for items currently checked out For reasons unknown, it is possible to get into a situation where an item is both checked out to one patron and associated with a found hold for another patron. We should add a script to Koha to fix items in this situation by reverting the found holds. Test Plan: 1) Check an item out to a patron 2) Place an item specific hold for another patron 3) Manually set the priority to 0 and found to "W" for that hold 4) Run misc/maintenance/fix_holds_waiting_and_issued.pl 5) Note the hold has been reverted! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37694 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This script needs to have some feedback/output on the holds changed - I think the hold changes will be logged in the action logs but the script should output how many were changed, and optionally verbosely, list all changes Also we should add cronlogaction to record when this is run -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191980|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 211671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211671&action=edit Bug 41698: (QA follow-up) Add output and cronlogaction * Print how many holds were reverted, so the result of each run is visible * Add -v/--verbose to list each hold as it is reverted * Record start and end of each run with cronlogaction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211671|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 211672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211672&action=edit Bug 41698: Add maintenance script to revert found holds for items currently checked out For reasons unknown, it is possible to get into a situation where an item is both checked out to one patron and associated with a found hold for another patron. We should add a script to Koha to fix items in this situation by reverting the found holds. Test Plan: 1) Check an item out to a patron 2) Place an item specific hold for another patron 3) Manually set the priority to 0 and found to "W" for that hold 4) Run misc/maintenance/fix_holds_waiting_and_issued.pl 5) Note the hold has been reverted! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 --- Comment #7 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 211673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211673&action=edit Bug 41698: (QA follow-up) Add output and cronlogaction * Print how many holds were reverted, so the result of each run is visible * Add -v/--verbose to list each hold as it is reverted * Record start and end of each run with cronlogaction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41698 --- Comment #8 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 211674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211674&action=edit Bug 41698: (follow-up) Remove holds queue entries for holds that no longer exist When a patron with a title level hold checks out a different copy of the title than the one the holds queue picked for them, the hold is filled but its entry stays in the holds queue. Koha::Hold::fill doesn't touch tmp_holdsqueue or hold_fill_targets, and AddIssue only removes queue entries for the item being checked out. With RealTimeHoldsQueue disabled, the entry for the other copy stays in the queue until the next full rebuild, so staff at that library are asked to pull an item for a hold that has already been filled. This patch makes the script also remove holds queue entries whose hold is no longer in the reserves table. Test Plan: 1) Disable RealTimeHoldsQueue 2) Find a record with two available items at two different libraries 3) Place a title level hold for a patron, with pickup at the library holding the second item 4) Run misc/cronjobs/holds/build_holds_queue.pl 5) Browse to the holds queue ( /cgi-bin/koha/circ/view_holdsqueue.pl ), note the hold is listed for one of the two items, make a note of which one 6) Check the *other* item out to the patron 7) Note the hold is now filled and no longer shows on the patron record 8) Browse to the holds queue, note the hold is still listed! 9) Apply this patch 10) Run misc/maintenance/fix_holds_waiting_and_issued.pl -c -v 11) Note the script reports removing the holds queue entry for that hold! 12) Browse to the holds queue, note the hold is gone! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org