https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Mohd Hafiz Yusoff <mhby87@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Software error while check |Software error while check |in, The method noreturn is |in, The method noreturn is |not covered by tests! |not covered by tests! after | |upgrade from 16.05 to 17.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |normal --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Mohd, How did you install Koha? Are you sure it is not a customized version of Koha? What returns the following commands? cd /usr/share/koha; grep -r noreturn | grep -v translator I do not find any relevant occurrences of "noreturn" in our code that could produce such error. Do you have something else in the Koha log file? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #5 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- Return from command lib/C4/Circulation.pm: noreturn: do not return, let item remain where checked in (floating collections) lib/C4/Circulation.pm: # if $hbr was "noreturn" or any other non-item table value, then it should 'float' (i.e. stay at this branch) intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [% IF ( default_returnbranch == 'noreturn' ) %] intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: <option value="noreturn" selected="selected"> intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: <option value="noreturn"> intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [% ELSIF ( branch_item_rule_loo.returnbranch == 'noreturn' ) %] intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: <option value="noreturn">Item floats</option> intranet/cgi-bin/installer/data/mysql/kohastructure.sql: `returnbranch` varchar(15) default NULL, -- the branch the item returns to (homebranch, holdingbranch, noreturn) man/man3/C4::Circulation.3pm: noreturn: do not return, let item remain where checked in (floating collections) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Software error while check |Software error while check |in, The method noreturn is |in, The method noreturn is |not covered by tests! after |not covered by tests! |upgrade from 16.05 to 17.11 | Severity|normal |critical Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Version|17.11 |master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok I recreate the problem, it happens when "Return policy" is "Item floats" (value noreturn) in circ rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18276 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Certainly caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70290&action=edit Bug 19899: Restore Item floats feature - do not crash Error is "The method noreturn is not covered by tests!" caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn) the library must be the current library (from userenv). This behaviour is used in C4::Circulation::AddReturn On bug 18276 I assumed that the value was either holdingbranch or homebranch, and forgot it could be "noreturn" Test plan: Set Return policy to Item floats Check an item in => without this patch it explodes => With this patch applied it will check the item in -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #10 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- Created attachment 70316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70316&action=edit Error after edit code line 279 After edit code at line 279, the error like attachment -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, you could try adding a ; to the end of this line: $returnbranch = $hbr eq 'noreturn' ? $item->$hbr : $userenv_branch; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Oops indeed, there is a semicolon missing at the end. I am going to reattach a patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #16 from Mohd Hafiz Yusoff <mhby87@gmail.com> --- Created attachment 70318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70318&action=edit Successful fix the problem, thank you Your code has been successful fix the problem. Now I can return my book easier. Thank you all -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #18 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Mohd Hafiz Yusoff <mhby87@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #19 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 70319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70319&action=edit Bug 19899: Restore Item floats feature - do not crash Error is "The method noreturn is not covered by tests!" caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn) the library must be the current library (from userenv). This behaviour is used in C4::Circulation::AddReturn On bug 18276 I assumed that the value was either holdingbranch or homebranch, and forgot it could be "noreturn" Test plan: Set Return policy to Item floats Check an item in => without this patch it explodes => With this patch applied it will check the item in Signed-off-by: Mohd Hafiz Yusoff <mhby87@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70319|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70332&action=edit Bug 19899: Restore Item floats feature - do not crash Error is "The method noreturn is not covered by tests!" caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones When the "Return policy" (var returnbranch) is set to "Item floats" (value noreturn) the library must be the current library (from userenv). This behaviour is used in C4::Circulation::AddReturn On bug 18276 I assumed that the value was either holdingbranch or homebranch, and forgot it could be "noreturn" Test plan: Set Return policy to Item floats Check an item in => without this patch it explodes => With this patch applied it will check the item in Signed-off-by: Mohd Hafiz Yusoff <mhby87@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.