http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39921&action=edit Bug 14346: t/Biblio.t fails because of new warning Running $ prove t/Biblio.t fails because of us now using DBIx to retrieve sysprefs. Then our mocked DBI is not "supported" by DBIx hence a warning that makes our test fail (there is one more warning now). The cool thing about this, is that it actually helped spot a situation where GetMarcBiblio is doing wrong things because is not checking its parameters are undefined, so we have the chance to fix it. This patch makes GetMarcBiblio return undef if no biblionumber is passed, and also raises a conveniently carped warning. This change is tested in t/Biblio.t with new tests. To test: - In current master, run $ prove t/Biblio.t => FAIL: a test detects a wrong warning count and fails. - Apply the patch and run $ prove t/Biblio.t => SUCCESS: Tests now pass, and there are 2 new ones. - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39921|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39928&action=edit Bug 14346: t/Biblio.t fails because of new warning Running $ prove t/Biblio.t fails because of us now using DBIx to retrieve sysprefs. Then our mocked DBI is not "supported" by DBIx hence a warning that makes our test fail (there is one more warning now). The cool thing about this, is that it actually helped spot a situation where GetMarcBiblio is doing wrong things because is not checking its parameters are undefined, so we have the chance to fix it. This patch makes GetMarcBiblio return undef if no biblionumber is passed, and also raises a conveniently carped warning. This change is tested in t/Biblio.t with new tests. To test: - In current master, run $ prove t/Biblio.t => FAIL: a test detects a wrong warning count and fails. - Apply the patch and run $ prove t/Biblio.t => SUCCESS: Tests now pass, and there are 2 new ones. - Sign off :-D Regards Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Tested both patches together. Looked at tests, and they make sense to me, and the one was modified to match the added carp message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39928|0 |1 is obsolete| | Attachment #39929|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39944&action=edit [PASSED QA] Bug 14346: t/Biblio.t fails because of new warning Running $ prove t/Biblio.t fails because of us now using DBIx to retrieve sysprefs. Then our mocked DBI is not "supported" by DBIx hence a warning that makes our test fail (there is one more warning now). The cool thing about this, is that it actually helped spot a situation where GetMarcBiblio is doing wrong things because is not checking its parameters are undefined, so we have the chance to fix it. This patch makes GetMarcBiblio return undef if no biblionumber is passed, and also raises a conveniently carped warning. This change is tested in t/Biblio.t with new tests. To test: - In current master, run $ prove t/Biblio.t => FAIL: a test detects a wrong warning count and fails. - Apply the patch and run $ prove t/Biblio.t => SUCCESS: Tests now pass, and there are 2 new ones. - Sign off :-D Regards Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.